fix!: remove deprecated API from auth & crashlytics (#8636)

Author: russellwheatley

docs/migrating-to-v23.md

@@ -5,9 +5,25 @@ previous: /migrate-to-v22
 next: /typescript
 ---
 
-⚠️ **REMOVED** ⚠️
+# Firebase Crashlytics
+
+Modular API method `isCrashlyticsCollectionEnabled(crashlytics)` has been removed, please use the property on Crashlytics instance
+`getCrashlytics().isCrashlyticsCollectionEnabled` instead.
+
+# Firebase Auth
+
+`MultiFactorUser.enrolledFactor` has been removed, please use `MultiFactorUser.enrolledFactors`. See example:
 
-# Firebase Dynamic Links has been Removed
+```js
+const credential = await signInWithEmailAndPassword(getAuth(), 'dummy@example.com', 'password');
+const multiFactorUser = credential.user.multiFactor;
+// Use below - remove any instances of `multiFactorUser.enrolledFactor`
+console.log(multiFactorUser.enrolledFactors);
+```
+
+# Firebase Dynamic Links
+
+⚠️ **REMOVED** ⚠️
 
 This package has been deprecated and removed from the React Native Firebase repository.
 

packages/auth/lib/multiFactor.js

@@ -14,8 +14,6 @@ export class MultiFactorUser {
     }
     this._user = user;
     this.enrolledFactors = user.multiFactor.enrolledFactors;
-    // @deprecated kept for backwards compatibility, please use enrolledFactors
-    this.enrolledFactor = user.multiFactor.enrolledFactors;
   }
 
   getSession() {

packages/crashlytics/__tests__/crashlytics.test.ts

@@ -8,7 +8,6 @@ import {
 import {
   firebase,
   getCrashlytics,
-  isCrashlyticsCollectionEnabled,
   checkForUnsentReports,
   deleteUnsentReports,
   didCrashOnPreviousExecution,
@@ -46,10 +45,6 @@ describe('Crashlytics', function () {
       expect(getCrashlytics).toBeDefined();
     });
 
-    it('`isCrashlyticsCollectionEnabled` function is properly exposed to end user', function () {
-      expect(isCrashlyticsCollectionEnabled).toBeDefined();
-    });
-
     it('`checkForUnsentReports` function is properly exposed to end user', function () {
       expect(checkForUnsentReports).toBeDefined();
     });
@@ -210,16 +205,5 @@ describe('Crashlytics', function () {
         'setCrashlyticsCollectionEnabled',
       );
     });
-
-    it('isCrashlyticsCollectionEnabled', function () {
-      const crashlytics = getCrashlytics();
-      checkV9Deprecation(
-        // swapped order here because we're deprecating the modular method and keeping the property on Crashlytics instance
-        () => crashlytics.isCrashlyticsCollectionEnabled,
-        () => isCrashlyticsCollectionEnabled(crashlytics),
-        '',
-        '`isCrashlyticsCollectionEnabled()` is deprecated, please use `Crashlytics.isCrashlyticsCollectionEnabled` property instead',
-      );
-    });
   });
 });

packages/crashlytics/lib/modular/index.d.ts

@@ -11,17 +11,6 @@ type FirebaseCrashlytics = FirebaseCrashlyticsTypes.Module;
  */
 export declare function getCrashlytics(): FirebaseCrashlytics;
 
-/**
- * Whether Crashlytics reporting is enabled.
- *
- * #### Example
- *
- * ```js
- * const crashlytics = getCrashlytics();
- * const isEnabled = isCrashlyticsCollectionEnabled(crashlytics);
- * ```
- */
-export declare function isCrashlyticsCollectionEnabled(crashlytics: FirebaseCrashlytics): boolean;
 /**
  * Determines whether there are any unsent crash reports cached on the device. The callback only executes
  * if automatic data collection is disabled.

packages/crashlytics/lib/modular/index.js

@@ -19,27 +19,6 @@ export function getCrashlytics() {
   return getApp().crashlytics();
 }
 
-/**
- * Whether Crashlytics reporting is enabled.
- *
- * #### Example
- *
- * ```js
- * const crashlytics = getCrashlytics();
- * const isEnabled = isCrashlyticsCollectionEnabled(crashlytics);
- * ```
- * @param {FirebaseCrashlytics} crashlytics
- * @returns {boolean}
- */
-export function isCrashlyticsCollectionEnabled(crashlytics) {
-  // Unique. Deprecating modular method and allow it as a property on Crashlytics instance.
-  // eslint-disable-next-line no-console
-  console.warn(
-    '`isCrashlyticsCollectionEnabled()` is deprecated, please use `Crashlytics.isCrashlyticsCollectionEnabled` property instead',
-  );
-  return crashlytics.isCrashlyticsCollectionEnabled;
-}
-
 /**
  * Determines whether there are any unsent crash reports cached on the device. The callback only executes
  * if automatic data collection is disabled.

packages/firestore/lib/index.js

@@ -314,10 +314,6 @@ class FirebaseFirestoreModule extends FirebaseModule {
     }
 
     if (!isUndefined(settings.host)) {
-      // eslint-disable-next-line no-console
-      console.warn(
-        'host in settings to connect with firestore emulator is deprecated. Use useEmulator instead.',
-      );
       if (!isString(settings.host)) {
         return Promise.reject(
           new Error("firebase.firestore().settings(*) 'settings.host' must be a string value."),