lint

Author: sugarmanz

.editorconfig

@@ -1,2 +1,4 @@
 [*.{kt,kts}]
-disabled_rules=no-wildcard-imports
+ktlint_code_style = ktlint_official
+ktlint_disabled_rules = no-wildcard-imports
+ij_kotlin_allow_trailing_comma_on_call_site = true

build.gradle.kts

@@ -60,8 +60,9 @@ tasks {
 
     val publish by creating {
         group = "publishing"
-        if (!isSnapshot)
+        if (!isSnapshot) {
             finalizedBy("closeAndReleaseSonatypeStagingRepository", ":docs:orchidDeploy", ":gradle-plugin:publishPlugins")
+        }
     }
 
     val version by creating {

docs/src/orchid/kotlin/com/intuit/hooks/docs/HooksTheme.kt

@@ -35,6 +35,6 @@ class HooksTheme @Inject constructor(context: OrchidContext) : Theme(context, "H
             listOfNotNull(super.getResourceSource(), delegateTheme.resourceSource),
             emptyList(),
             priority,
-            ThemeResourceSource
+            ThemeResourceSource,
         )
 }

example-library/src/test/kotlin/CarHooksTest.kt

@@ -1,7 +1,7 @@
 package com.intuit.hooks.example.library
 
 import com.intuit.hooks.example.library.car.Car
-import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Test
 
 internal class CarHooksTest {

example-library/src/test/kotlin/GenericHookTests.kt

@@ -1,6 +1,7 @@
 package com.intuit.hooks.example.library
 
-import com.intuit.hooks.BailResult.*
+import com.intuit.hooks.BailResult.Bail
+import com.intuit.hooks.BailResult.Continue
 import com.intuit.hooks.HookContext
 import com.intuit.hooks.LoopResult
 import com.intuit.hooks.example.library.generic.GenericHooksImpl
@@ -140,6 +141,7 @@ class GenericHookTests {
         val result = h.call("Kian")
         Assertions.assertEquals("bail now", result)
     }
+
     @Test
     fun `async series loop`() = runBlocking {
         var incrementedA = 0

gradle-plugin/src/main/kotlin/com/intuit/hooks/plugin/gradle/HooksGradlePlugin.kt

@@ -21,17 +21,18 @@ public class HooksGradlePlugin : Plugin<Project> {
 
     private fun Project.addDependency(configuration: String, dependencyNotation: String) = configurations
         .getByName(configuration).dependencies.add(
-            dependencies.create(dependencyNotation)
+            dependencies.create(dependencyNotation),
         )
 
     override fun apply(project: Project): Unit = with(project) {
         extensions.create(
             "hooks",
-            HooksGradleExtension::class.java
+            HooksGradleExtension::class.java,
         )
 
-        if (!pluginManager.hasPlugin("com.google.devtools.ksp"))
+        if (!pluginManager.hasPlugin("com.google.devtools.ksp")) {
             pluginManager.apply("com.google.devtools.ksp")
+        }
 
         addDependency("api", "com.intuit.hooks:hooks:$hooksVersion")
         addDependency("ksp", "com.intuit.hooks:processor:$hooksVersion")

gradle-plugin/src/test/kotlin/HooksGradlePluginTest.kt

@@ -33,15 +33,15 @@ class HooksGradlePluginTest {
                 kotlin("jvm")
                 id("com.intuit.hooks")
             }
-        """
+        """,
         )
     }
 
     @Test fun `can apply plugin`() {
         buildFile.appendKotlin(
             """
             hooks {}
-        """
+        """,
         )
 
         assertDoesNotThrow {
@@ -66,7 +66,7 @@ class HooksGradlePluginTest {
                 @Sync<(String) -> Unit>
                 abstract val testSyncHook: Hook
             }
-        """
+        """,
         )
 
         val runner = GradleRunner.create()

hooks/src/main/kotlin/com/intuit/hooks/BaseHook.kt

@@ -37,7 +37,7 @@ public data class TapInfo<FWithContext : Function<*>> internal constructor(
     public val name: String,
     public val id: String,
     public val type: String,
-    public val f: FWithContext,
+    public val f: FWithContext
     // val stage: Int, // todo: maybe this should be forEachIndexed?
     // before?: string | Array // todo: do we even really need this?
 )

hooks/src/main/kotlin/com/intuit/hooks/dsl/Hooks.kt

@@ -60,7 +60,8 @@ public abstract class Hooks {
         ReplaceWith("@Hooks.AsyncParallelBail<F>"),
         DeprecationLevel.ERROR,
     )
-    @ExperimentalCoroutinesApi protected fun <F : Function<BailResult<*>>> asyncParallelBailHook(): AsyncParallelBailHook<*, *> = stub()
+    @ExperimentalCoroutinesApi
+    protected fun <F : Function<BailResult<*>>> asyncParallelBailHook(): AsyncParallelBailHook<*, *> = stub()
 
     protected annotation class AsyncSeries<F : Function<*>>
 

hooks/src/test/kotlin/com/intuit/hooks/AsyncSeriesLoopHookTests.kt

@@ -1,6 +1,8 @@
 package com.intuit.hooks
 
-import io.mockk.*
+import io.mockk.coEvery
+import io.mockk.coVerify
+import io.mockk.mockk
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.runBlocking
 import org.junit.jupiter.api.Assertions
@@ -10,7 +12,7 @@ class AsyncSeriesLoopHookTests {
     class LoopHook1<T1> : AsyncSeriesLoopHook<suspend (HookContext, T1) -> LoopResult, suspend (HookContext, T1) -> Unit>() {
         suspend fun call(p1: T1) = super.call(
             invokeTap = { f, context -> f(context, p1) },
-            invokeInterceptor = { f, context -> f(context, p1) }
+            invokeInterceptor = { f, context -> f(context, p1) },
         )
     }