Skip to content

Commit baefd5b

Browse files
Merge pull request #135 from intuit/error-handling-updates
Error handling updates
2 parents 90c58fd + 13eab5c commit baefd5b

File tree

25 files changed

+461
-209
lines changed

25 files changed

+461
-209
lines changed

ipp-v3-java-data/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>com.intuit.quickbooks-online</groupId>
66
<artifactId>ipp-v3-java-devkit-pom</artifactId>
7-
<version>6.0.5</version>
7+
<version>6.0.6</version>
88
</parent>
99

1010
<artifactId>ipp-v3-java-data</artifactId>
@@ -13,7 +13,7 @@
1313

1414
<properties>
1515
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
16-
<javadocExecutable>${java.home}/../bin/javadoc</javadocExecutable>
16+
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable>
1717
</properties>
1818

1919
<dependencies>

ipp-v3-java-devkit/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<artifactId>ipp-v3-java-devkit-pom</artifactId>
66
<groupId>com.intuit.quickbooks-online</groupId>
7-
<version>6.0.5</version>
7+
<version>6.0.6</version>
88
</parent>
99

1010
<artifactId>ipp-v3-java-devkit</artifactId>
@@ -15,14 +15,14 @@
1515
<properties>
1616
<sonar.langauge>java</sonar.langauge>
1717
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
18-
<javadocExecutable>${java.home}/../bin/javadoc</javadocExecutable>
18+
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable>
1919
</properties>
2020

2121
<dependencies>
2222
<dependency>
2323
<groupId>com.intuit.quickbooks-online</groupId>
2424
<artifactId>ipp-v3-java-data</artifactId>
25-
<version>6.0.5</version>
25+
<version>6.0.6</version>
2626
</dependency>
2727
<dependency>
2828
<groupId>cglib</groupId>

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/PrepareRequestInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ private <T extends IEntity> String prepareQBOUri(String entityName, Context cont
310310

311311
if(context.getMinorVersion() == null)
312312
{
313-
context.setMinorVersion("51");
313+
context.setMinorVersion(Config.getProperty(Config.LATEST_MINOR_VERSION));
314314
}
315315

316316
uri.append("minorversion").append("=").append(context.getMinorVersion()).append("&");

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/util/Config.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ public final class Config {
184184
public static final String BIGDECIMAL_SCALE_SHIFT = "feature.bigDecimalScaleShift";
185185

186186
public static final String WEBHOOKS_VERIFIER_TOKEN = "webhooks.verifier.token";
187+
188+
public static final String LATEST_MINOR_VERSION = "minorVersion.latestMinorVersion";
187189

188190
/**
189191
* variable ThreadLocal

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/util/MessageUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ public static List<Object> getWhitelistedEnums() {
108108
enumList.add(FaultTypeEnum.class);
109109
enumList.add(Gender.class);
110110
enumList.add(GlobalTaxCalculationEnum.class);
111+
enumList.add(GTMConfigTypeEnum.class);
111112
enumList.add(IdDomainEnum.class);
112113
enumList.add(ItemCategoryTypeEnum.class);
113114
enumList.add(ItemTypeEnum.class);

ipp-v3-java-devkit/src/main/resources/intuit-default-config.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,9 @@
4545
<connectionTimeout></connectionTimeout>
4646
<requestTimeout></requestTimeout>
4747
</timeout>
48+
49+
<minorVersion>
50+
<latestMinorVersion>51</latestMinorVersion>
51+
</minorVersion>
52+
4853
</intuit-config>

ipp-v3-java-devkit/src/main/resources/ippdevkit.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Devkit Version
44
# This version has to be updated according to the pom version
5-
version = 6.0.5
5+
version = 6.0.6
66

77
# This is to have the request source to be sent to IDS request header
88
request.source = V3JavaSDK

ipp-v3-java-devkit/src/test/java/com/intuit/ipp/interceptors/PrepareRequestInterceptorTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ public void setUp() throws FMSException {
5959
public void testExecute_QBO_URI() throws FMSException {
6060
instance.execute(message);
6161
String actual = message.getRequestElements().getRequestParameters().get("uri");
62-
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion=51&");
62+
String minorVersion = Config.getProperty(Config.LATEST_MINOR_VERSION);
63+
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion="+minorVersion+"&");
6364
}
6465

6566
@Test

ipp-v3-java-devkit/src/test/resources/ippdevkit.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
### IPP Dev Kit helper properties
22

33
## Devkit version
4-
version = 6.0.5
4+
version = 6.0.6
55

66
# This is to have the request source to be sent to IDS request header
77
request.source = V3JavaSDK

oauth2-platform-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<parent>
2121
<artifactId>ipp-v3-java-devkit-pom</artifactId>
2222
<groupId>com.intuit.quickbooks-online</groupId>
23-
<version>6.0.5</version>
23+
<version>6.0.6</version>
2424
</parent>
2525
<artifactId>oauth2-platform-api</artifactId>
2626
<name>Quickbooks API Helper for OAuth2</name>

0 commit comments

Comments
 (0)