Skip to content

Commit afb080d

Browse files
Move minor version to config file
1 parent 2a064c9 commit afb080d

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/PrepareRequestInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ private <T extends IEntity> String prepareQBOUri(String entityName, Context cont
310310

311311
if(context.getMinorVersion() == null)
312312
{
313-
context.setMinorVersion("51");
313+
context.setMinorVersion(Config.getProperty(Config.LATEST_MINOR_VERSION));
314314
}
315315

316316
uri.append("minorversion").append("=").append(context.getMinorVersion()).append("&");

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/util/Config.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ public final class Config {
184184
public static final String BIGDECIMAL_SCALE_SHIFT = "feature.bigDecimalScaleShift";
185185

186186
public static final String WEBHOOKS_VERIFIER_TOKEN = "webhooks.verifier.token";
187+
188+
public static final String LATEST_MINOR_VERSION = "minorVersion.latestMinorVersion";
187189

188190
/**
189191
* variable ThreadLocal

ipp-v3-java-devkit/src/main/resources/intuit-default-config.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,9 @@
4545
<connectionTimeout></connectionTimeout>
4646
<requestTimeout></requestTimeout>
4747
</timeout>
48+
49+
<minorVersion>
50+
<latestMinorVersion>51</latestMinorVersion>
51+
</minorVersion>
52+
4853
</intuit-config>

ipp-v3-java-devkit/src/test/java/com/intuit/ipp/interceptors/PrepareRequestInterceptorTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ public void setUp() throws FMSException {
5959
public void testExecute_QBO_URI() throws FMSException {
6060
instance.execute(message);
6161
String actual = message.getRequestElements().getRequestParameters().get("uri");
62-
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion=51&");
62+
String minorVersion = Config.getProperty(Config.LATEST_MINOR_VERSION);
63+
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion="+minorVersion+"&");
6364
}
6465

6566
@Test

0 commit comments

Comments
 (0)