Skip to content

Commit 947c0f1

Browse files
committed
update minor version 43
1 parent a078f4d commit 947c0f1

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/PrepareRequestInterceptor.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ private <T extends IEntity> String prepareQBOUri(String entityName, Context cont
308308

309309
if(context.getMinorVersion() == null)
310310
{
311-
context.setMinorVersion("41");
311+
context.setMinorVersion("43");
312312
}
313313

314314
uri.append("minorversion").append("=").append(context.getMinorVersion()).append("&");
@@ -419,6 +419,17 @@ private String prepareEntitlementUri(Context context) throws FMSException {
419419
StringBuilder uri = new StringBuilder();
420420
uri.append(getBaseUrl(Config.getProperty(Config.BASE_URL_ENTITLEMENTSERVICE))).append("/").
421421
append("entitlements").append("/").append("v3").append("/").append(context.getRealmID());
422+
// adds the generated request id as a parameter
423+
uri.append("?").append("requestid").append("=").append(context.getRequestID()).append("&");
424+
//set RequestId to null once appended, so the next random num can be generated
425+
context.setRequestID(null);
426+
427+
if(context.getMinorVersion() == null)
428+
{
429+
context.setMinorVersion("43");
430+
}
431+
432+
uri.append("minorversion").append("=").append(context.getMinorVersion()).append("&");
422433
return uri.toString();
423434
}
424435

ipp-v3-java-devkit/src/test/java/com/intuit/ipp/interceptors/PrepareRequestInterceptorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void setUp() throws FMSException {
5959
public void testExecute_QBO_URI() throws FMSException {
6060
instance.execute(message);
6161
String actual = message.getRequestElements().getRequestParameters().get("uri");
62-
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion=41&");
62+
Assert.assertEquals(actual, Config.getProperty(Config.BASE_URL_QBO) + "/fakeRealm/fakeAction?requestid=anyRequestID&minorversion=43&");
6363
}
6464

6565
@Test
@@ -79,7 +79,7 @@ public void testExecuteWithEntitlementService() throws FMSException {
7979
message.setEntitlementService(true);
8080
instance.execute(message);
8181

82-
Assert.assertEquals(message.getRequestElements().getRequestParameters().get(RequestElements.REQ_PARAM_RESOURCE_URL), Config.getProperty(Config.BASE_URL_ENTITLEMENTSERVICE) + "/entitlements/v3/fakeRealm");
82+
Assert.assertEquals(message.getRequestElements().getRequestParameters().get(RequestElements.REQ_PARAM_RESOURCE_URL), Config.getProperty(Config.BASE_URL_ENTITLEMENTSERVICE) + "/entitlements/v3/fakeRealm?requestid=anyRequestID&minorversion=43&");
8383
Assert.assertEquals(message.getRequestElements().getRequestHeaders().get(RequestElements.HEADER_PARAM_CONTENT_TYPE), "application/xml");
8484
Assert.assertEquals(message.getRequestElements().getRequestHeaders().get(RequestElements.HEADER_PARAM_ACCEPT), "application/xml");
8585
Assert.assertNull(message.getRequestElements().getRequestHeaders().get(Config.COMPRESSION_REQUEST_FORMAT));

0 commit comments

Comments
 (0)