Skip to content

Commit 081e2dc

Browse files
authored
Merge pull request #80 from amatiushkin/issue75
Propagate fault even there is no responses (#75)
2 parents 61799ea + 41adb1f commit 081e2dc

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/CallbackHandlerInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ private List<CDCQueryResult> getCDCQueryResult(List<CDCResponse> cdcResponses) {
227227
private CDCQueryResult getCDCQueryResult(CDCResponse cdcResponse) {
228228
CDCQueryResult cdcQueryResult = new CDCQueryResult();
229229
List<QueryResponse> queryResponses = cdcResponse.getQueryResponse();
230-
if (queryResponses != null) {
230+
if (!queryResponses.isEmpty()) {
231231
Map<String, QueryResult> queryResults = new HashMap<String, QueryResult>();
232232
Iterator<QueryResponse> queryResponseItr = queryResponses.iterator();
233233
while (queryResponseItr.hasNext()) {

ipp-v3-java-devkit/src/test/java/com/intuit/ipp/interceptors/CallbackHandlerInterceptorCDCTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,12 @@ public void errorNoResponse() throws FMSException {
6565
final Fault fault = new Fault();
6666
final Error error = new Error();
6767
fault.setError(Collections.singletonList(error));
68-
error.setDetail("My custom error");
68+
error.setDetail("My custom request error");
6969
o.setFault(fault);
7070
o.setQueryResponse(null);
7171

72-
assertEmptyResult(invokeCDC(Collections.singletonList(o)));
72+
new ResultChecker( assertAndGetFirst(invokeCDC(Collections.singletonList(o))))
73+
.assertErrorsDetails("My custom request error");
7374
}
7475

7576
@Test

0 commit comments

Comments
 (0)