Skip to content

Conversation

@rhuanbarreto
Copy link
Contributor

@rhuanbarreto rhuanbarreto commented Jul 25, 2025

Closes #210

Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, tusen takk! ☺️

I'm on vacation, so I won't be able to do a proper review until late next week/early August.

@rhuanbarreto
Copy link
Contributor Author

Hi @JonasKs . Any chance to look into it?

@JonasKs
Copy link
Member

JonasKs commented Aug 22, 2025

Hi, om so sorry, I've totally forgotten. I'll try to get to it this weekend. Thanks for the ping!

@JonasKs
Copy link
Member

JonasKs commented Aug 29, 2025

Sorry! I didn't get time to do this. I'll get to it next week!

Comment on lines 22 to 23
- id: flake8
additional_dependencies: [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you keeping these flake8 hooks?

hooks:
- id: isort
"flake8-deprecated==2.1", # Looks for method deprecations
"flake8-use-fstring==1.4", # Enforces use of f-strings over .format and %s
Copy link

@Kilo59 Kilo59 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8-use-fstring can be handled by the UP032 rule.
You don't need to keep flake8 around for this.
https://docs.astral.sh/ruff/rules/f-string/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to uv, rye and ruff

3 participants