Merge pull request #434 from intersystems/allow-quotes-commit-message

Double quotes allowed in commit and amend messages

Author: isc-hwojnick

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - WebUI workspace view now works properly for filenames with spaces (#423)
 - Fixed error popups in interop editors in Studio on 2024.1 (#417)
 - Reintroduced amend (#425)
+- Double quotes now permissible in commit messages (#433)
 
 ## [2.4.0] - 2024-07-08
 

git-webui/release/share/git-webui/webui/js/git-webui.js

@@ -2551,6 +2551,9 @@ webui.NewChangedFilesView = function(workspaceView) {
 
     self.amend = function(message, details) {
         var selectedFilesAsString = selectedItems.join(" ");
+        message = self.doubleQuotesToSingleQuotes(message);
+        details = self.doubleQuotesToSingleQuotes(details);
+
         if (self.commitMsgEmpty()) {
             webui.git("add " + selectedFilesAsString);
             webui.git("commit --amend --no-edit -- " + selectedFilesAsString, function(output) {
@@ -2573,8 +2576,14 @@ webui.NewChangedFilesView = function(workspaceView) {
 
     }
 
+    self.doubleQuotesToSingleQuotes = function(string) {
+        return string.replace(/"/g, "'");
+    }
+
     self.commit = function(message, details) {
         var selectedFilesAsString = selectedItems.join(" ");
+        message = self.doubleQuotesToSingleQuotes(message);
+        details = self.doubleQuotesToSingleQuotes(details);
 
         webui.git("add " + selectedFilesAsString);
         webui.git('commit -m "' + message + '" -m "' + details + '" -- ' + selectedFilesAsString, function(output) {

git-webui/src/share/git-webui/webui/js/git-webui.js

@@ -2551,6 +2551,9 @@ webui.NewChangedFilesView = function(workspaceView) {
 
     self.amend = function(message, details) {
         var selectedFilesAsString = selectedItems.join(" ");
+        message = self.doubleQuotesToSingleQuotes(message);
+        details = self.doubleQuotesToSingleQuotes(details);
+
         if (self.commitMsgEmpty()) {
             webui.git("add " + selectedFilesAsString);
             webui.git("commit --amend --no-edit -- " + selectedFilesAsString, function(output) {
@@ -2573,8 +2576,14 @@ webui.NewChangedFilesView = function(workspaceView) {
 
     }
 
+    self.doubleQuotesToSingleQuotes = function(string) {
+        return string.replace(/"/g, "'");
+    }
+
     self.commit = function(message, details) {
         var selectedFilesAsString = selectedItems.join(" ");
+        message = self.doubleQuotesToSingleQuotes(message);
+        details = self.doubleQuotesToSingleQuotes(details);
 
         webui.git("add " + selectedFilesAsString);
         webui.git('commit -m "' + message + '" -m "' + details + '" -- ' + selectedFilesAsString, function(output) {