Fixed reviewed changes

isc-etamarch · isc-etamarch · commit f0b6b5b2e161 · 2024-10-21T11:28:56.000-04:00
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
@@ -2862,9 +2862,6 @@ ClassMethod ConfigureFavoriteNamespaces(username As %String, newNamespaces As %S
         set link = "/isc/studio/usertemplates/gitsourcecontrol/pull.csp?$NAMESPACE=" _ installNamespace
         &sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))
     }
-
-    // Update Security.Applications
-    &sql(UPDATE Security.Applications SET GroupById = '%ISCMgtPortal' WHERE ID = '/isc/studio/usertemplates')
 }
 
 ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef nonFavNamespaces As %DynamicArray)
diff --git a/csp/pull.csp b/csp/pull.csp
@@ -11,12 +11,14 @@
 <body>
 <pre for="contextSelect" style="padding-top: 2em;white-space: pre-wrap;height: 60px;">Change Context:  <select id="newContext" onchange="updateContext()">
 	<server>
-		set $NAMESPACE = %request.Data("$NAMESPACE",1)
-		set contextList = ##class(SourceControl.Git.Utils).GetContexts(1)
-        set iterator = contextList.%GetIterator()
-		&html<<option>Select</option>>
-        while iterator.%GetNext(.key, .value) {
-				&html<<option value=#(value)#>#(value)#</option>>
+		if (%request.Data("$NAMESPACE")) {
+			set $NAMESPACE = %request.Data("$NAMESPACE",1)
+			set contextList = ##class(SourceControl.Git.Utils).GetContexts(1)
+			set iterator = contextList.%GetIterator()
+			&html<<option>Select</option>>
+			while iterator.%GetNext(.key, .value) {
+					&html<<option value=#(value)#>#(value)#</option>>
+			}
 		}
 	</server>
 </select>

Original file line number	Diff line number	Diff line change
`@@ -2862,9 +2862,6 @@ ClassMethod ConfigureFavoriteNamespaces(username As %String, newNamespaces As %S`
`2862`	`2862`	`set link = "/isc/studio/usertemplates/gitsourcecontrol/pull.csp?$NAMESPACE=" _ installNamespace`
`2863`	`2863`	`&sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))`
`2864`	`2864`	`}`
`2865`		`-`
`2866`		`- // Update Security.Applications`
`2867`		`- &sql(UPDATE Security.Applications SET GroupById = '%ISCMgtPortal' WHERE ID = '/isc/studio/usertemplates')`
`2868`	`2865`	`}`
`2869`	`2866`
`2870`	`2867`	`ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef nonFavNamespaces As %DynamicArray)`