Merge pull request #422 from intersystems/fix-stash-view-diff

WebUI stash list now shows diff for selected stash item

Author: isc-tleavitt

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 - Fixed JS errors in Studio on certain operations (#416)
+- Fixed issue where selecting different item in stash list didn't update diff view (#265)
 - Tooltip in workspace now shows user who made uncommitted change if not current user (#411)
 - Files are added to source control upon creation properly (#404)
 - Files show in uncommitted queue when automatically added (#407)

git-webui/release/share/git-webui/webui/js/git-webui.js

@@ -1256,11 +1256,7 @@ webui.StashCommitView = function(stashView) {
     var self = this;
 
     self.update = function(entry) {
-        if (currentCommit == entry.commit) {
-            // We already display the right data. No need to update.
-            return;
 
-        }
         currentCommit = entry.commit;
         self.showDiff();
         diffView.update("stash show -p stash@{"+entry.stashIndex+"}");
@@ -2060,11 +2056,6 @@ webui.CommitView = function(historyView) {
     var self = this;
 
     self.update = function(entry) {
-        if (currentCommit == entry.commit) {
-            // We already display the right data. No need to update.
-            return;
-
-        }
         currentCommit = entry.commit;
         self.showDiff();
         buttonBox.select(0);

git-webui/src/share/git-webui/webui/js/git-webui.js

@@ -1256,11 +1256,7 @@ webui.StashCommitView = function(stashView) {
     var self = this;
 
     self.update = function(entry) {
-        if (currentCommit == entry.commit) {
-            // We already display the right data. No need to update.
-            return;
 
-        }
         currentCommit = entry.commit;
         self.showDiff();
         diffView.update("stash show -p stash@{"+entry.stashIndex+"}");
@@ -2060,11 +2056,6 @@ webui.CommitView = function(historyView) {
     var self = this;
 
     self.update = function(entry) {
-        if (currentCommit == entry.commit) {
-            // We already display the right data. No need to update.
-            return;
-
-        }
         currentCommit = entry.commit;
         self.showDiff();
         buttonBox.select(0);