Converted dynamic sql to embedded

Author: isc-akadoo

cls/SourceControl/Git/Utils.cls

@@ -2845,45 +2845,53 @@ ClassMethod SetConfiguredRemote(url) As %String
 
 ClassMethod ConfigureFavoriteNamespaces(username As %String, newNamespaces As %String)
 {
-    // Delete all the GIT favorite links for the user
-    set iterator = newNamespaces.%GetIterator()
-    while iterator.%GetNext(.key, .value) {
-        set sql = "delete from %SYS_Portal.Users where Username='"_username_"' and Page like '%Git%'"
-        set statement = ##class(%SQL.Statement).%New()
-        do ##class(%SQL.Statement).%ExecDirect(statement,sql)
-    }
+    // Delete all the GIT favorite links for the user 
+    &sql(DELETE FROM %SYS_Portal.Users WHERE Username = :username AND Page LIKE '%Git%')
 
     set iterator = newNamespaces.%GetIterator()
     while iterator.%GetNext(.key, .value) {
         set installNamespace = value
-        new $Namespace
-        set $Namespace = "%SYS"
-        set sql = "insert or update into %SYS_Portal.Users (Username, Page, Data) "_
-            "select ID,?,? from Security.Users where ID='"_username_"'"
-        set caption = "Git: "_installNamespace
-        set link = "/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/"_installNamespace_"/"
-        set statement = ##class(%SQL.Statement).%New()
-        set statement.%SelectMode = 0
-        do ##class(%SQL.Statement).%ExecDirect(statement,sql,caption,link)
-        set caption = "Git Pull: "_installNamespace
-        set link = "/isc/studio/usertemplates/gitsourcecontrol/pull.csp?$NAMESPACE="_installNamespace
-        do ##class(%SQL.Statement).%ExecDirect(statement,sql,caption,link)
-        set sql = "update Security.Applications set GroupById='%ISCMgtPortal' where ID = '/isc/studio/usertemplates'"
-        do ##class(%SQL.Statement).%ExecDirect(statement,sql)
-    }
-}
-
-ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef nonFavNamespaces As %DynamicArray) {
+        
+        // Insert Git link
+        set caption = "Git: " _ installNamespace
+        set link = "/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/" _ installNamespace _ "/"
+        &sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))
+        
+        // Insert Git Pull link
+        set caption = "Git Pull: " _ installNamespace
+        set link = "/isc/studio/usertemplates/gitsourcecontrol/pull.csp?$NAMESPACE=" _ installNamespace
+        &sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))
+    }
+
+    // Update Security.Applications
+    &sql(UPDATE Security.Applications SET GroupById = '%ISCMgtPortal' WHERE ID = '/isc/studio/usertemplates')
+}
+
+ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef nonFavNamespaces As %DynamicArray)
+{
     set allNamespaces = ..GetContexts(1)
     set iterator = allNamespaces.%GetIterator()
 
+    set username = $USERNAME
+    set pagePrefix = "Git:"    
+    &sql(DECLARE FavCursor CURSOR FOR SELECT Page into :page from %SYS_Portal.Users where username = :username and page %STARTSWITH :pagePrefix)
+
     while iterator.%GetNext(.key, .value) {
-        set sql = "select * from %SYS_Portal.Users where username='"_$username_"' and page='Git: "_value_"'"
-        set statement = ##class(%SQL.Statement).%New()
-        set res = ##class(%SQL.Statement).%ExecDirect(statement,sql)
-        if (res.%Next()) {
-            do favNamespaces.%Push(value)
-        } else {
+        set foundFlag = 0
+        &sql(OPEN FavCursor)
+        throw:SQLCODE<0 ##class(%Exception.SQL).CreateFromSQLCODE(SQLCODE, %msg)
+        &sql(FETCH FavCursor)
+        while (SQLCODE = 0) {
+            set pageValue = "Git: "_value 
+            if (page = pageValue) {
+                do favNamespaces.%Push(value)
+                set foundFlag = 1
+            }
+            &sql(FETCH FavCursor)
+        }
+        &sql(CLOSE FavCursor)
+
+        if ('foundFlag) {
             do nonFavNamespaces.%Push(value)
         }
     }