fix: editing remote in settings pages now works if you are adding, updating, or removing the remote.

adds the constraint that we only operate on a single remote named origin. previously multiple remotes had undefined behavior.

Author: isc-pbarton

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Deletes are now properly owned by the user who did the delete (#729)
 - Pull page output now displays better when pull preview shows a lot of changes (#740)
+- Changing remotes in the git project settings pages now works if remote is not already defined (#746)
 
 ## [2.11.0] - 2025-04-23
 

cls/SourceControl/Git/Utils.cls

@@ -3019,15 +3019,23 @@ ClassMethod BaselineExport(pCommitMessage = "", pPushToRemote = "") As %Status
     return sc
 }
 
-/// Returns the url for the remote repository (censoring the username)
-ClassMethod GetConfiguredRemote() As %String
-{
-    d ..RunGitCommand("remote",.err,.out,"-v")
-    set line = out.ReadLine()
-    set url = $piece($piece(line,$char(9),2)," ",1)
+/// Returns the url for the "origin" remote repository
+ClassMethod GetConfiguredRemote(Output remoteExists As %Boolean = 0) As %String
+{
+    set exitCode = ..RunGitCommand("remote",.err,.out,"get-url","origin")
+    if (exitCode = 0) {
+        set remoteExists = 1
+        set url = out.ReadLine()
+    } elseif (exitCode = 2) {
+        set remoteExists = 0
+        set url = ""
+    } else {
+        $$$ThrowStatus($$$ERROR($$$GeneralError,"git reported failure"))
+    }
     return url
 }
 
+/// Returns the url for the "origin" remote repository, redacting the username
 ClassMethod GetRedactedRemote() As %String
 {
     set url = ..GetConfiguredRemote()
@@ -3038,7 +3046,15 @@ ClassMethod GetRedactedRemote() As %String
 
 ClassMethod SetConfiguredRemote(url) As %String
 {
-    do ##class(SourceControl.Git.Utils).RunGitCommandWithInput("remote",,.errStream,.outStream,"set-url","origin",url)
+    do ..GetConfiguredRemote(.remoteExists)
+    set returnCode = $select(
+        remoteExists&&(url=""): ##class(SourceControl.Git.Utils).RunGitCommandWithInput("remote",,.errStream,.outStream,"remove","origin"),
+        remoteExists&&(url'=""): ##class(SourceControl.Git.Utils).RunGitCommandWithInput("remote",,.errStream,.outStream,"set-url","origin",url),
+        'remoteExists&&(url'=""): ##class(SourceControl.Git.Utils).RunGitCommandWithInput("remote",,.errStream,.outStream,"add","origin",url),
+        1: 0)
+    if (returnCode '= 0) {
+        $$$ThrowStatus($$$ERROR($$$GeneralError,"git reported failure"))
+    }
     set output = outStream.ReadLine(outStream.Size)
     quit output
 }
@@ -3198,4 +3214,3 @@ ClassMethod IsSchemaStandard(pName As %String = "") As %Boolean [ Internal ]
 }
 
 }
-