Allow users to set basicMode even if settingsUIReadOnly is true

Previously despite basicMode being editable on the settings screen it would not save when settingsUIReadOnly was true. The fact that it is grouped on the settings screen with the already editable and savable gitUserName and gitUserEmail settings suggests that basicMode is intended to be set by users and the inability to do is an oversight.

Author: raymond-rebbeck

csp/gitprojectsettings.csp

@@ -108,6 +108,16 @@ body {
         for param="gitUserName","gitUserEmail" {
             set $Property(settings,param) = $Get(%request.Data(param,1))
         }
+
+        // Users may set basicMode even if settingsUIReadOnly is true
+        if ($Get(%request.Data("basicMode", 1)) = 1) {
+            set settings.basicMode = 1
+        } elseif ($Get(%request.Data("basicMode", 1)) = "system"){
+            set settings.basicMode = "system"
+        } else {
+            set settings.basicMode = 0
+        }
+
         if ('settings.settingsUIReadOnly) {
             for param="gitBinPath","namespaceTemp","privateKeyFile","pullEventClass","percentClassReplace", "defaultMergeBranch","environmentName","mappingsToken" {
                 set $Property(settings,param) = $Get(%request.Data(param,1))
@@ -125,14 +135,6 @@ body {
             set settings.decomposeProdAllowIDE = ($Get(%request.Data("decomposeProdAllowIDE", 1)) = 1)
             set settings.lockBranch = ($Get(%request.Data("lockBranch", 1)) = 1)
 
-            if ($Get(%request.Data("basicMode", 1)) = 1) {
-                set settings.basicMode = 1
-            } elseif ($Get(%request.Data("basicMode", 1)) = "system"){
-                set settings.basicMode = "system"
-            } else {
-                set settings.basicMode = 0
-            }
-
             if ($Get(%request.Data("systemBasicMode", 1)) = 1) {
                 set settings.systemBasicMode = 1
             } else {