feat: instance wide uncommitted queue check for opened file

Author: isc-hwojnick

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.0] - Unreleased
+
+### Added
+- Files in uncommitted queue in any namespace warn users when opened except for in VSCode (#370)
+
 ## [2.4.1] - Unreleased
 
 ### Fixed

cls/SourceControl/Git/Change.cls

@@ -185,6 +185,46 @@ ClassMethod RefreshUncommitted(Display = 0, IncludeRevert = 0, Output gitFiles,
     quit sc
 }
 
+Query InstanceUncommitted() As %Query(ROWSPEC = "InternalName:%String,User:%String")
+{
+}
+
+ClassMethod InstanceUncommittedExecute(ByRef qHandle As %Binary) As %Status
+{
+    set qHandle("q") = "SELECT InternalName, ChangedBy FROM SourceControl_Git.Change"
+    set namespaces = ##class(SourceControl.Git.Utils).GetGitEnabledNamespaces()
+    set tPtr = 0
+    set qHandle("i") = 1
+    while $LISTNEXT(namespaces, tPtr, tValue) {
+        set namespace = $ZCONVERT(tValue, "U")
+        set $NAMESPACE = namespace
+        set resultSet = ##class(%SQL.Statement).%ExecDirect(, qHandle("q"))
+        while resultSet.%Next() {
+            set qHandle("changes", $increment(qHandle("changes")), "InternalName") = resultSet.%GetData(1)
+            set qHandle("changes", qHandle("changes"), "User") = resultSet.%GetData(2)
+        }
+    }
+    
+    Quit $$$OK
+}
+
+ClassMethod InstanceUncommittedFetch(ByRef qHandle As %Binary, ByRef Row As %List, ByRef AtEnd As %Integer = 0) As %Status [ PlaceAfter = InstanceUncommittedExecute ]
+{
+    set i = qHandle("i")
+    set Row = $listbuild(qHandle("changes", i, "InternalName"), qHandle("changes", i, "User"))
+    if i = qHandle("changes") {
+        set AtEnd = 1
+    } else {
+        set qHandle("i") = $increment(qHandle("i"))
+    }
+    Quit $$$OK
+}
+
+ClassMethod InstanceUncommittedClose(ByRef qHandle As %Binary) As %Status [ PlaceAfter = InstanceUncommittedFetch ]
+{
+    Quit $$$OK
+}
+
 Storage Default
 {
 <Data name="ChangeDefaultData">

cls/SourceControl/Git/Extension.cls

@@ -50,6 +50,15 @@ Method UserAction(Type As %Integer, Name As %String, InternalName As %String, Se
         set Name = "%SourceMenu,Status"
     } 
 
+    if (Type = 1) && (Name = 3) {
+        set user = ""
+        if ##class(SourceControl.Git.Utils).FileIsUncommitted(InternalName, .user) && (user '= $USERNAME){
+            set Target = InternalName _ " is currently being modified by " _ user
+            write !, Target
+            set Action = 6
+        }
+    }
+
     if (Type = 1) && ((Name = 1) || (Name = 7)) {
         do ..AddToSourceControl(InternalName)
     }

cls/SourceControl/Git/Utils.cls

@@ -2423,7 +2423,7 @@ ClassMethod GetGitEnabledNamespaces() As %String
 {
     // Get all namespaces
     set allNamespaces = ""
-    do ##class(%SYS.Namespace).GetList(.allNamespaces)
+    do ##class(%SYS.Namespace).ListAll(.allNamespaces)
 
     set enabledNamespaces = ""
 
@@ -2460,38 +2460,19 @@ ClassMethod GetGitEnabledNamespaces() As %String
     quit enabledNamespaces
 }
 
-
-Query InstanceUncommitted() As %Query() 
+ClassMethod FileIsUncommitted(InternalName As %String, Output User) As %Boolean
 {
-}
-
-ClassMethod InstanceUncommittedExecute(ByRef qHandle As %Binary) As %Status {
-    set qHandle("q") = "SELECT InternalName FROM SourceControl_Git.Change"
-    set namespaces = ..GetGitEnabledNamespaces()
-    set tPtr = 0
-    while $LISTNEXT(namespaces, tPtr, tValue) {
-        set qHandle("n", $increment(qHandle("n"))) = $ZCONVERT(tValue, "U")
-    }
-    
-    Quit $$$OK
-}
-
-ClassMethod InstanceUncommittedFetch(ByRef qHandle As %Binary, ByRef Row As %List, ByRef AtEnd As %Integer = 0) As %Status [PlaceAfter = InstanceUncommittedExecute]{
-    #dim tResult as %SQL.StatementResult
-    New $Namespace
-    set tSC = $$$OK
-    try {
-        set namespace = ""
-        for {
-            set namespace = $ORDER(
+    set isUncommitted = 0
+    set resultSet = ##class(SourceControl.Git.Change).InstanceUncommittedFunc()
+    while resultSet.%Next() {
+        set fileName = resultSet.InternalName
+        if InternalName = fileName {
+            set isUncommitted = 1
+            set User = resultSet.User
         }
-    } catch e {
-        set tSC = e.AsStatus()
     }
-}
-
-ClassMethod InstanceUncommittedClose(ByRef qHandle As %Binary) As %Status [PlaceAfter = InstanceUncommittedFetch] {
 
+    quit isUncommitted
 }
 
 ClassMethod BuildCEInstallationPackage(ByRef destination As %String) As %Status