Skip to content

Make server-side error messages easier to read #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-bsaviano merged 1 commit into from
Jun 17, 2025
Merged

Make server-side error messages easier to read #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/providers/FileSystemProvider/FileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,8 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
})
.catch((error) => {
// Throw all failures
throw vscode.FileSystemError.Unavailable(stringifyError(error) || uri);
const errorStr = stringifyError(error);
throw errorStr ? errorStr : vscode.FileSystemError.Unavailable(uri);
});
},
(error) => {
Expand All @@ -527,7 +528,8 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
)
.catch((error) => {
// Throw all failures
throw vscode.FileSystemError.Unavailable(stringifyError(error) || uri);
const errorStr = stringifyError(error);
throw errorStr ? errorStr : vscode.FileSystemError.Unavailable(uri);
})
.then((data) => {
// New file has been written
Expand Down Expand Up @@ -771,7 +773,8 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
)
.catch((error) => {
// Throw all failures
throw vscode.FileSystemError.Unavailable(stringifyError(error) || newUri);
const errorStr = stringifyError(error);
throw errorStr ? errorStr : vscode.FileSystemError.Unavailable(newUri);
})
.then(async (response) => {
// New file has been written
Expand Down Expand Up @@ -985,9 +988,12 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
)
.catch((error) => {
if (error?.statusCode == 304 && cachedFile) return cachedFile;
const errArg = stringifyError(error) || uri;
if (error?.statusCode == 404) throw vscode.FileSystemError.FileNotFound(errArg);
throw vscode.FileSystemError.Unavailable(errArg);
const errorStr = stringifyError(error);
throw error?.statusCode == 404
? vscode.FileSystemError.FileNotFound(uri)
: errorStr
? errorStr
: vscode.FileSystemError.Unavailable(uri);
});
}

Expand Down