fix: Fix constant gateway resume/invalid session loop. (#1070)

* fix: Added zlib + compression, disabled msg size limit

* fix: Removed `$` on identify call for future-proofing.

Author: FayeDel

interactions/api/gateway/client.py

@@ -19,6 +19,7 @@
 from sys import platform, version_info
 from time import perf_counter
 from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Type, Union
+from zlib import decompressobj
 
 from aiohttp import ClientWebSocketResponse, WSMessage, WSMsgType
 
@@ -98,6 +99,7 @@ class WebSocketClient:
         "__heartbeater",
         "__shard",
         "__presence",
+        "_zlib",
         "_task",
         "__heartbeat_event",
         "__started",
@@ -148,7 +150,7 @@ def __init__(
 
         self.__closed: Event = Event(loop=self._loop) if version_info < (3, 10) else Event()
         self._options: dict = {
-            "max_msg_size": 1024**2,
+            "max_msg_size": 0,
             "timeout": 60,
             "autoclose": False,
             "compress": 0,
@@ -180,6 +182,8 @@ def __init__(
 
         self.__stopping: Optional[Task] = None
 
+        self._zlib = decompressobj()
+
     @property
     def latency(self) -> float:
         """
@@ -827,6 +831,8 @@ async def _reconnect(self, to_resume: bool, code: Optional[int] = 1012) -> None:
 
             self._client = None
 
+            self._zlib = decompressobj()
+
             # We need to check about existing heartbeater tasks for edge cases.
 
             if self._task:
@@ -863,6 +869,8 @@ async def __receive_packet(self, ignore_lock: bool = False) -> Optional[Dict[str
         :rtype: Optional[Dict[str, Any]]
         """
 
+        buffer = bytearray()
+
         while True:
 
             if not ignore_lock:
@@ -874,12 +882,9 @@ async def __receive_packet(self, ignore_lock: bool = False) -> Optional[Dict[str
             if packet.type == WSMsgType.CLOSE:
                 log.debug(f"Disconnecting from gateway = {packet.data}::{packet.extra}")
 
-                if packet.data >= 4000:  # suppress 4001 because of weird presence errors
+                if packet.data >= 4000:
                     # This means that the error code is 4000+, which may signify Discord-provided error codes.
 
-                    # However, we suppress 4001 because of weird presence errors with change_presence
-                    # The payload is correct, and the presence object persists. /shrug
-
                     raise LibraryException(packet.data)
 
                 if ignore_lock:
@@ -919,8 +924,20 @@ async def __receive_packet(self, ignore_lock: bool = False) -> Optional[Dict[str
             if packet.data is None:
                 continue  # We just loop it over because it could just be processing something.
 
+            if isinstance(packet.data, bytes):
+                buffer.extend(packet.data)
+
+                if len(packet.data) < 4 or packet.data[-4:] != b"\x00\x00\xff\xff":
+                    # buffer isn't done we need to wait
+                    continue
+
+                msg = self._zlib.decompress(buffer)
+                msg = msg.decode("utf-8")
+            else:
+                msg = packet.data
+
             try:
-                msg = loads(packet.data)
+                _msg = loads(msg)
             except Exception as e:
                 import traceback
 
@@ -929,9 +946,9 @@ async def __receive_packet(self, ignore_lock: bool = False) -> Optional[Dict[str
                 )
                 # There's an edge case when the packet's None... or some other deserialisation error.
                 # Instead of raising an exception, we just log it to debug, so it doesn't annoy end user's console logs.
-                msg = None
+                _msg = None
 
-            return msg
+            return _msg
 
     async def _send_packet(self, data: Dict[str, Any]) -> None:
         """
@@ -972,10 +989,11 @@ async def __identify(
                 "token": self._http.token,
                 "intents": self._intents.value,
                 "properties": {
-                    "$os": platform,
-                    "$browser": "interactions.py",
-                    "$device": "interactions.py",
+                    "os": platform,
+                    "browser": "interactions.py",
+                    "device": "interactions.py",
                 },
+                "compress": True,
             },
         }
 
@@ -1037,5 +1055,4 @@ async def close(self) -> None:
         """
         if self._client:
             await self._client.close()
-
         self.__closed.set()