Added cog command remove function

Author: eunwoo1104

README.md

@@ -22,7 +22,7 @@ async def _test(ctx: SlashContext):
 bot.run("discord_token")
 ```
 
-Cog (__Not Recommended__):
+Cog:
 ```py
 import discord
 from discord.ext import commands
@@ -33,12 +33,15 @@ from discord_slash import SlashContext
 
 class Slash(commands.Cog):
     def __init__(self, bot):
-        self.bot = bot
         if not hasattr(bot, "slash"):
             # Creates new SlashCommand instance to bot if bot doesn't have.
-            self.bot.slash = SlashCommand(bot, override_type=True)
+            bot.slash = SlashCommand(bot, override_type=True)
+        self.bot = bot
         self.bot.slash.get_cog_commands(self)
 
+    def cog_unload(self):
+        self.bot.slash.remove_cog_commands(self)
+
     @cog_ext.cog_slash(name="test")
     async def _test(self, ctx: SlashContext):
         embed = discord.Embed(title="embed test")

discord_slash/client.py

@@ -52,6 +52,9 @@ def remove(self):
         """
         Removes :func:`on_socket_response` event listener from discord.py Client.
 
+        .. warning::
+            This is deprecated and will be removed soon.
+
         .. note::
             This only works if it is :class:`discord.ext.commands.Bot` or
             :class:`discord.ext.commands.AutoShardedBot`.
@@ -61,6 +64,12 @@ def remove(self):
         self._discord.remove_listener(self.on_socket_response)
 
     def get_cog_commands(self, cog: commands.Cog):
+        """
+        Gets slash command from :class:`discord.ext.commands.Cog`.
+
+        :param cog: Cog that has slash commands.
+        :type cog: discord.ext.commands.Cog
+        """
         func_list = [getattr(cog, x) for x in dir(cog)]
         res = [x for x in func_list if
                isinstance(x, model.CogCommandObject) or isinstance(x, model.CogSubcommandObject)]
@@ -92,9 +101,39 @@ def get_cog_commands(self, cog: commands.Cog):
                     self.subcommands[x.base][x.name] = x
 
     def remove_cog_commands(self, cog):
+        """
+        Removes slash command from :class:`discord.ext.commands.Cog`.
+
+        :param cog: Cog that has slash commands.
+        :type cog: discord.ext.commands.Cog
+        """
         func_list = [getattr(cog, x) for x in dir(cog)]
         res = [x for x in func_list if
                isinstance(x, model.CogCommandObject) or isinstance(x, model.CogSubcommandObject)]
+        for x in res:
+            if isinstance(x, model.CogCommandObject):
+                if x.name not in self.commands.keys():
+                    continue # Just in case it is removed due to subcommand.
+                if x.name in self.subcommands.keys():
+                    self.commands[x.name].func = None
+                    continue # Let's remove completely when every subcommand is removed.
+                del self.commands[x.name]
+            else:
+                if x.base not in self.subcommands.keys():
+                    continue # Just in case...
+                if x.subcommand_group:
+                    del self.subcommands[x.base][x.subcommand_group][x.name]
+                    if not self.subcommands[x.base][x.subcommand_group]:
+                        del self.subcommands[x.base][x.subcommand_group]
+                else:
+                    del self.subcommands[x.base][x.name]
+                if not self.subcommands[x.base]:
+                    del self.subcommands[x.base]
+                    if x.base in self.commands.keys():
+                        if self.commands[x.base].func:
+                            self.commands[x.base].has_subcommands = False
+                        else:
+                            del self.commands[x.base]
 
     async def register_all_commands(self):
         """

discord_slash/error.py

@@ -25,3 +25,11 @@ class IncorrectFormat(SlashCommandError):
     """
     def __init__(self, msg: str):
         super().__init__(msg)
+
+
+class DuplicateCommand(SlashCommandError):
+    """
+    There is a duplicate command name.
+    """
+    def __init__(self, name: str):
+        super().__init__(f"Duplicate command name detected: {name}")