Skip to content

CVS-175119-[OVEP] Fixed possibility of array index out of bounds in subgraph partitioning #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 19, 2025
Merged

CVS-175119-[OVEP] Fixed possibility of array index out of bounds in subgraph partitioning #838

Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
479b319
added a line to add initializers to be a part of meta_def -> inputs
RajeevSekar Oct 27, 2025
9406caf
fixed possible array index out of bound problem which caused some mod…
RajeevSekar Oct 27, 2025
dd51bde
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Oct 28, 2025
154d895
changed loop logic
RajeevSekar Oct 28, 2025
9609408
Merge branch 'rajeev/get_capability_fix' of https://github.com/intel/…
RajeevSekar Oct 28, 2025
4ed9884
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 3, 2025
b04746f
reverting to the previous logic to ensure j value is retained and not…
RajeevSekar Nov 3, 2025
92714b4
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 3, 2025
b63bc77
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 4, 2025
8cf2fa3
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 11, 2025
b24d874
updated loop logic
RajeevSekar Nov 12, 2025
338c03b
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 12, 2025
a43d040
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 14, 2025
ef414c0
Merge branch 'ovep-develop' into rajeev/get_capability_fix
RajeevSekar Nov 19, 2025
e86fb0a
Merge branch 'ovep-develop' into rajeev/get_capability_fix
preetha-intel Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onnxruntime/core/providers/openvino/ov_versions/capability.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ std::vector<std::unique_ptr<ComputeCapability>> GetCapability::Execute() {
bool append_node = false;
while (j < total_clusters && !append_node) {
Copy link

@preetha-intel preetha-intel Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the increment part of loop so that the additional check can be removed.

something like
while (++j < total_clusters && !append_node)

Copy link
Author

@RajeevSekar RajeevSekar Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Preetha, I have made that change, thanks for pointing it out

Copy link
Author

@RajeevSekar RajeevSekar Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Preetha, due to this change of adding the increment part in the loop, an issue was created.

Old logic (larger loop)
In the case where j < total_clusters is true but append node is also true (the loop is not entered), j is not incremented

New logic (shorter loop)
In the case ++j is still < total_clusters but append node is true, the loop is not entered but j is aldready incremented (unlike the first logic).

so, just after the loop, in this block

if (append_node) {
connected_clusters[j].emplace_back(index);
}

incorrect value of j is used which causes some model to fail.

So we cant use "while (++j < total_clusters && !append_node)"

Is there a way to optimize the loop logic but retain the j if we exit the loop due to append_node == true

j = j + 1;
if (j >= total_clusters) {
break;
}
append_node = AddTrivialClusterToNextClusterIfConnected(graph_viewer_, index, connected_clusters[j]);
}
if (append_node) {
Expand Down
Loading