CVS-167480 : Report import failure error code #715

javier-intel · 2025-06-18T08:26:23Z

Description

Report invalid binary when context model can't be imported by OV

Motivation and Context

Correctly communicate to ORT core the failure to import EpCtx

https://jira.devtools.intel.com/browse/CVS-167480

MayureshV1

@javier-intel .. DO we have a way to trigger compatibility failure and ensure exception triggered by elf loader and UMD is caught here?

onnxruntime/core/providers/openvino/exceptions.h

MayureshV1

LGTM !

sfatimar · 2025-07-14T04:50:25Z

@javier-intel can you please rebase this branch so I can merge it in. Mayuresh has already approved.

sfatimar · 2025-08-01T06:02:46Z

Why has this not been merged yet ? @javier-intel ?

sfatimar · 2025-08-01T06:03:19Z

@MayureshV1 please merge PR if you are approving ..You must have permissions

javier-intel · 2025-08-04T22:26:50Z

@sfatimar I think it flew under the radar. It's a simple change but will probably need careful rebase as it's been some time since it was implemented. This week as I'll be busy with traveling so either I do it next week or someone from your team picks it up.

javier-intel · 2025-08-23T01:17:30Z

@MayureshV1 can you please review again? I just built, haven't tested :(

Copilot

Pull Request Overview

This PR introduces proper error handling for OpenVINO model import failures by creating typed exceptions that can communicate specific error codes back to the ONNX Runtime core, particularly for invalid binary errors during context model imports.

Enhanced exception handling with a new typed exception system that preserves error codes
Modified OvExceptionBoundary to support typed exceptions for model import operations
Added fallback logic for NPU compilation failures with better error reporting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
exceptions.h	New exception class with error code parsing and Status conversion
ov_interface.cc	Updated exception boundary template and ImportModel to use typed exceptions
openvino_execution_provider.cc	Added exception handling wrapper in Compile method
backend_manager.cc	Enhanced NPU fallback logic with typed exception handling

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

onnxruntime/core/providers/openvino/exceptions.h

onnxruntime/core/providers/openvino/ov_interface.cc

MayureshV1

Backend Manager.cc has CPU fallback flow for NPU compile failure scenario. This logic was moved to basic_backedn.cc and needs to be adapted.

https://github.com/intel/onnxruntime/pull/723/files

Per MayureshV1's review comment, the NPU->CPU fallback logic was moved to basic_backend.cc in PR #723. This commit removes the duplicate implementation from backend_manager.cc constructor to avoid conflicts and maintain single responsibility.

ankitm3k · 2025-11-11T12:34:57Z

Backend Manager.cc has CPU fallback flow for NPU compile failure scenario. This logic was moved to basic_backedn.cc and needs to be adapted.

https://github.com/intel/onnxruntime/pull/723/files

Fixed. We are ready to merge now

javier-intel

Just a small change

javier-intel · 2025-11-13T20:22:26Z

onnxruntime/core/providers/openvino/exceptions.h

+    }
+
+    std::string error_message = "Unhandled exception type: " + std::to_string(static_cast<int>(type_));
+    return {category_ort, common::FAIL, error_message};


Change FAIL to common::EP_FAIL

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-14T01:37:17Z

onnxruntime/core/providers/openvino/exceptions.h

+    // Newer drivers
+    if ((type_ == type::import_model) &&
+        (error_code_ == 0x7800000f /* ZE_RESULT_ERROR_INVALID_NATIVE_BINARY */)) {
+      std::string message{error_name_ + ", code 0x" + std::to_string(error_code_) + "\nModel needs to be recompiled\n"};


Using std::to_string() on a hexadecimal value converts it to decimal. Use a hex formatting approach (e.g., std::format or a stringstream with hex manipulator) to preserve the hexadecimal representation of error_code_.

Copilot · 2025-11-14T01:37:18Z

onnxruntime/core/providers/openvino/ov_interface.cc

    return func();
  } catch (const ov::Exception& e) {
-    ORT_THROW(log_tag + std::vformat(fmt.get(), std::make_format_args(args...)) + ": " + std::string(e.what()));
+    const auto message = log_tag + (args + ...) + ": " + std::string(e.what());


The fold expression (args + ...) requires all args to be string-like types. If any argument is not a string, this will fail to compile. Consider using string concatenation with explicit conversions or std::format as in the original implementation.

Copilot · 2025-11-14T01:37:18Z

onnxruntime/core/providers/openvino/ov_interface.cc

  },
                             " Cannot access IE Blob for input number: {}", index);


The format string and argument are passed but no longer used in the new implementation of OvExceptionBoundary. These arguments should be removed or the function signature needs to be updated to accept formatted messages.

Copilot · 2025-11-14T01:37:18Z

onnxruntime/core/providers/openvino/ov_interface.cc

  },
                      " Cannot set Remote Blob for output: {}", name);


Similar to Comment 4: the format string and argument are passed but not utilized by the updated OvExceptionBoundary function.

Copilot · 2025-11-14T01:37:18Z

onnxruntime/core/providers/openvino/ov_interface.cc

+  OvExceptionBoundary<false>([&]() {
    ovInfReq.infer();
  },
                      "In Error Couldn't start Inference");


The error message string is passed but not used by the new OvExceptionBoundary implementation.

Suggested change

"In Error Couldn't start Inference");

" In Error Couldn't start Inference");

javier-intel force-pushed the jemartin/import_failure_error_code branch from 7dbe8e9 to faf1a6e Compare June 18, 2025 08:29

javier-intel requested a review from MayureshV1 June 18, 2025 08:29

MayureshV1 reviewed Jun 18, 2025

View reviewed changes

onnxruntime/core/providers/openvino/exceptions.h Show resolved Hide resolved

onnxruntime/core/providers/openvino/exceptions.h Outdated Show resolved Hide resolved

MayureshV1 requested a review from Copilot June 18, 2025 17:38

This comment was marked as outdated.

Sign in to view

MayureshV1 approved these changes Jun 19, 2025

View reviewed changes

MayureshV1 requested a review from Copilot June 24, 2025 07:59

This comment was marked as outdated.

Sign in to view

MayureshV1 requested a review from Copilot June 24, 2025 17:32

This comment was marked as outdated.

Sign in to view

javier-intel force-pushed the jemartin/import_failure_error_code branch from c75e346 to 64bcdad Compare June 24, 2025 22:27

sfatimar requested a review from vthaniel July 14, 2025 04:50

javier-intel added the ovep_abi_1.0 PRs that need to go in ABI need to have this label. label Aug 14, 2025

javier-intel force-pushed the jemartin/import_failure_error_code branch 3 times, most recently from c3dc39d to 93a6e38 Compare August 23, 2025 01:14

MayureshV1 requested a review from Copilot August 25, 2025 18:55

Copilot AI reviewed Aug 25, 2025

View reviewed changes

onnxruntime/core/providers/openvino/exceptions.h Show resolved Hide resolved

onnxruntime/core/providers/openvino/ov_interface.cc Show resolved Hide resolved

onnxruntime/core/providers/openvino/ov_interface.cc Show resolved Hide resolved

MayureshV1 requested changes Aug 26, 2025

View reviewed changes

MayureshV1 mentioned this pull request Nov 6, 2025

CVS-167480 : Update ORT Error Codes handling during OV Import & Compilation flow #842

Open

ankitm3k added a commit that referenced this pull request Nov 10, 2025

add: Update ZE Error Code extraction logic from PR #715

995163d

ankitm3k added a commit that referenced this pull request Nov 11, 2025

add: Update ZE Error Code extraction logic from PR #715

c687c85

Catch model import failure and report the appropriate error

49fe713

ankitm3k force-pushed the jemartin/import_failure_error_code branch from 5778e4f to 49fe713 Compare November 11, 2025 10:24

ankitm3k changed the title ~~Report import failure error code~~ CVS-167480 : Report import failure error code Nov 11, 2025

ankitm3k force-pushed the jemartin/import_failure_error_code branch from 1e8d394 to 3ca0979 Compare November 11, 2025 12:16

javier-intel commented Nov 13, 2025

View reviewed changes

MayureshV1 requested a review from Copilot November 14, 2025 01:35

Copilot AI reviewed Nov 14, 2025

View reviewed changes

	"In Error Couldn't start Inference");
	" In Error Couldn't start Inference");

CVS-167480 : Report import failure error code #715

Are you sure you want to change the base?

CVS-167480 : Report import failure error code #715

Conversation

javier-intel commented Jun 18, 2025 • edited by MayureshV1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Uh oh!

MayureshV1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

MayureshV1 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sfatimar commented Jul 14, 2025

Uh oh!

sfatimar commented Aug 1, 2025

Uh oh!

sfatimar commented Aug 1, 2025

Uh oh!

javier-intel commented Aug 4, 2025

Uh oh!

javier-intel commented Aug 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MayureshV1 left a comment

Choose a reason for hiding this comment

Uh oh!

ankitm3k commented Nov 11, 2025

Uh oh!

javier-intel left a comment

Choose a reason for hiding this comment

Uh oh!

javier-intel Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

javier-intel commented Jun 18, 2025 •

edited by MayureshV1

Loading