From 2c4cc88466cd4732bca4ab242416d40360885fe9 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Thu, 6 Nov 2025 07:19:14 -0800 Subject: [PATCH 1/2] [SYCL][NFC] Fix Coverity hit in device_image_impl ctor --- sycl/source/detail/device_image_impl.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/source/detail/device_image_impl.hpp b/sycl/source/detail/device_image_impl.hpp index e688af8f3190c..a716da4514d19 100644 --- a/sycl/source/detail/device_image_impl.hpp +++ b/sycl/source/detail/device_image_impl.hpp @@ -326,7 +326,7 @@ class device_image_impl updateSpecConstSymMap(); } - device_image_impl(const std::string &Src, context Context, + device_image_impl(const std::string &Src, const context &Context, devices_range Devices, syclex::source_language Lang, include_pairs_t &&IncludePairsVec, private_tag) : MBinImage(Src), MContext(Context), From fbe39de57d151dd34a9ce751316b3fb9dc431200 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Thu, 6 Nov 2025 07:50:23 -0800 Subject: [PATCH 2/2] Switch to pass-by-value + move --- sycl/source/detail/device_image_impl.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl/source/detail/device_image_impl.hpp b/sycl/source/detail/device_image_impl.hpp index a716da4514d19..fdf1bedb89b57 100644 --- a/sycl/source/detail/device_image_impl.hpp +++ b/sycl/source/detail/device_image_impl.hpp @@ -326,10 +326,10 @@ class device_image_impl updateSpecConstSymMap(); } - device_image_impl(const std::string &Src, const context &Context, + device_image_impl(const std::string &Src, context Context, devices_range Devices, syclex::source_language Lang, include_pairs_t &&IncludePairsVec, private_tag) - : MBinImage(Src), MContext(Context), + : MBinImage(Src), MContext(std::move(Context)), MDevices(Devices.to>()), MState(bundle_state::ext_oneapi_source), MSpecConstsDefValBlob(getSpecConstsDefValBlob()),