Skip to content

Commit c0dc88d

Browse files
Remove gmock from mock_fence and mock_event
Related-To: NEO-4914 Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
1 parent 37f16ac commit c0dc88d

File tree

3 files changed

+22
-66
lines changed

3 files changed

+22
-66
lines changed
Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
/*
2-
* Copyright (C) 2020 Intel Corporation
2+
* Copyright (C) 2020-2021 Intel Corporation
33
*
44
* SPDX-License-Identifier: MIT
55
*
66
*/
77

88
#include "level_zero/core/test/unit_tests/mocks/mock_event.h"
99

10-
#include <vector>
11-
1210
namespace L0 {
1311
namespace ult {
1412

@@ -18,14 +16,5 @@ Mock<Event>::Mock() : mockAllocation(0, NEO::GraphicsAllocation::AllocationType:
1816

1917
Mock<Event>::~Mock() {}
2018

21-
Mock<EventPool>::Mock() : pool(1) {
22-
pool = std::vector<int>(1);
23-
pool[0] = 0;
24-
25-
EXPECT_CALL(*this, getPoolSize()).WillRepeatedly(testing::Return(1));
26-
}
27-
28-
Mock<EventPool>::~Mock() { pool.clear(); }
29-
3019
} // namespace ult
3120
} // namespace L0

level_zero/core/test/unit_tests/mocks/mock_event.h

Lines changed: 16 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,12 @@
66
*/
77

88
#pragma once
9-
#include "level_zero/core/source/device/device.h"
9+
#include "shared/test/common/test_macros/mock_method_macros.h"
10+
1011
#include "level_zero/core/source/event/event.h"
1112
#include "level_zero/core/test/unit_tests/mock.h"
1213
#include "level_zero/core/test/unit_tests/white_box.h"
1314

14-
#include "gmock/gmock.h"
15-
16-
#include <vector>
17-
18-
#if defined(__clang__)
19-
#pragma clang diagnostic push
20-
#pragma clang diagnostic ignored "-Winconsistent-missing-override"
21-
#endif
22-
2315
namespace L0 {
2416
namespace ult {
2517

@@ -43,14 +35,13 @@ struct Mock<Event> : public Event {
4335
Mock();
4436
~Mock() override;
4537

46-
MOCK_METHOD3(create, L0::Event *(::L0::EventPool *eventPool, const ze_event_desc_t *desc, ::L0::Device *device));
47-
MOCK_METHOD0(destroy, ze_result_t());
48-
MOCK_METHOD0(hostSignal, ze_result_t());
49-
MOCK_METHOD1(hostSynchronize, ze_result_t(uint64_t timeout));
50-
MOCK_METHOD0(queryStatus, ze_result_t());
51-
MOCK_METHOD0(reset, ze_result_t());
52-
MOCK_METHOD1(queryKernelTimestamp, ze_result_t(ze_kernel_timestamp_result_t *dstptr));
53-
MOCK_METHOD3(queryTimestampsExp, ze_result_t(::L0::Device *device, uint32_t *pCount, ze_kernel_timestamp_result_t *pTimestamps));
38+
ADDMETHOD_NOBASE(destroy, ze_result_t, ZE_RESULT_SUCCESS, ());
39+
ADDMETHOD_NOBASE(hostSignal, ze_result_t, ZE_RESULT_SUCCESS, ());
40+
ADDMETHOD_NOBASE(hostSynchronize, ze_result_t, ZE_RESULT_SUCCESS, (uint64_t timeout));
41+
ADDMETHOD_NOBASE(queryStatus, ze_result_t, ZE_RESULT_SUCCESS, ());
42+
ADDMETHOD_NOBASE(reset, ze_result_t, ZE_RESULT_SUCCESS, ());
43+
ADDMETHOD_NOBASE(queryKernelTimestamp, ze_result_t, ZE_RESULT_SUCCESS, (ze_kernel_timestamp_result_t * dstptr));
44+
ADDMETHOD_NOBASE(queryTimestampsExp, ze_result_t, ZE_RESULT_SUCCESS, (::L0::Device * device, uint32_t *pCount, ze_kernel_timestamp_result_t *pTimestamps));
5445

5546
// Fake an allocation for event memory
5647
alignas(16) uint32_t memory = -1;
@@ -61,28 +52,17 @@ struct Mock<Event> : public Event {
6152

6253
template <>
6354
struct Mock<EventPool> : public EventPool {
64-
Mock();
65-
~Mock() override;
55+
Mock() = default;
6656

67-
MOCK_METHOD0(destroy, ze_result_t());
68-
MOCK_METHOD0(getPoolSize, size_t());
69-
MOCK_METHOD0(getPoolUsedCount, uint32_t());
70-
MOCK_METHOD1(getIpcHandle, ze_result_t(ze_ipc_event_pool_handle_t *pIpcHandle));
71-
MOCK_METHOD0(closeIpcHandle, ze_result_t());
72-
MOCK_METHOD2(createEvent, ze_result_t(const ze_event_desc_t *desc, ze_event_handle_t *phEvent));
73-
MOCK_METHOD2(reserveEventFromPool, ze_result_t(int index, ::L0::Event *event));
74-
MOCK_METHOD1(releaseEventToPool, ze_result_t(::L0::Event *event));
75-
MOCK_METHOD0(getDevice, Device *());
76-
MOCK_METHOD0(getEventSize, uint32_t());
77-
78-
std::vector<int> pool;
57+
ADDMETHOD_NOBASE(destroy, ze_result_t, ZE_RESULT_SUCCESS, ());
58+
ADDMETHOD_NOBASE(getIpcHandle, ze_result_t, ZE_RESULT_SUCCESS, (ze_ipc_event_pool_handle_t * pIpcHandle));
59+
ADDMETHOD_NOBASE(closeIpcHandle, ze_result_t, ZE_RESULT_SUCCESS, ());
60+
ADDMETHOD_NOBASE(createEvent, ze_result_t, ZE_RESULT_SUCCESS, (const ze_event_desc_t *desc, ze_event_handle_t *phEvent));
61+
ADDMETHOD_NOBASE(getDevice, Device *, nullptr, ());
62+
ADDMETHOD_NOBASE(getEventSize, uint32_t, 0u, ());
7963

8064
using EventPool::eventPoolAllocations;
8165
};
8266

8367
} // namespace ult
8468
} // namespace L0
85-
86-
#if defined(__clang__)
87-
#pragma clang diagnostic pop
88-
#endif

level_zero/core/test/unit_tests/mocks/mock_fence.h

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
*/
77

88
#pragma once
9+
#include "shared/test/common/test_macros/mock_method_macros.h"
910

10-
#include "level_zero/core/source/cmdqueue/cmdqueue.h"
11-
#include "level_zero/core/source/cmdqueue/cmdqueue_imp.h"
1211
#include "level_zero/core/source/fence/fence.h"
1312
#include "level_zero/core/test/unit_tests/mock.h"
1413
#include "level_zero/core/test/unit_tests/white_box.h"
@@ -35,22 +34,10 @@ struct Mock<Fence> : public Fence {
3534
}
3635
~Mock() override = default;
3736

38-
MOCK_METHOD(ze_result_t,
39-
destroy,
40-
(),
41-
(override));
42-
MOCK_METHOD(ze_result_t,
43-
hostSynchronize,
44-
(uint64_t),
45-
(override));
46-
MOCK_METHOD(ze_result_t,
47-
queryStatus,
48-
(),
49-
(override));
50-
MOCK_METHOD(ze_result_t,
51-
reset,
52-
(),
53-
(override));
37+
ADDMETHOD_NOBASE(destroy, ze_result_t, ZE_RESULT_SUCCESS, ());
38+
ADDMETHOD_NOBASE(hostSynchronize, ze_result_t, ZE_RESULT_SUCCESS, (uint64_t timeout));
39+
ADDMETHOD_NOBASE(queryStatus, ze_result_t, ZE_RESULT_SUCCESS, ());
40+
ADDMETHOD_NOBASE(reset, ze_result_t, ZE_RESULT_SUCCESS, ());
5441

5542
// Fake an allocation for event memory
5643
alignas(16) uint32_t memory = -1;

0 commit comments

Comments
 (0)