Skip to content

Commit b1af4cc

Browse files
AdamCetnerowskiCompute-Runtime-Automation
AdamCetnerowski
authored and
Compute-Runtime-Automation
committed
ULT renaming: Copy Buffer Rect Tests
Related-To: NEO-2236 Change-Id: Ia49f75d3e7de725de4cefb2a7898e49214e8ab98 Signed-off-by: Adam Cetnerowski <adam.cetnerowski@intel.com>
1 parent 4dd1155 commit b1af4cc

File tree

1 file changed

+22
-25
lines changed

1 file changed

+22
-25
lines changed

‎unit_tests/command_queue/enqueue_copy_buffer_rect_tests.cpp‎

Lines changed: 22 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ using namespace NEO;
1919

2020
const size_t EnqueueCopyBufferRectTest::BufferRect::sizeInBytes = 100 * 100 * 100 * sizeof(cl_char);
2121

22-
HWTEST_F(EnqueueCopyBufferRectTest, null_src_mem_object) {
22+
HWTEST_F(EnqueueCopyBufferRectTest, GivenNullSrcMemObjWhenCopyingBufferRectThenClInvalidMemObjectErrorIsReturned) {
2323
auto retVal = CL_SUCCESS;
2424
size_t srcOrigin[] = {0, 0, 0};
2525
size_t dstOrigin[] = {0, 0, 0};
@@ -43,7 +43,7 @@ HWTEST_F(EnqueueCopyBufferRectTest, null_src_mem_object) {
4343
EXPECT_EQ(CL_INVALID_MEM_OBJECT, retVal);
4444
}
4545

46-
HWTEST_F(EnqueueCopyBufferRectTest, null_dst_mem_object) {
46+
HWTEST_F(EnqueueCopyBufferRectTest, GivenNullDstMemObjWhenCopyingBufferRectThenClInvalidMemObjectErrorIsReturned) {
4747
auto retVal = CL_SUCCESS;
4848
size_t srcOrigin[] = {0, 0, 0};
4949
size_t dstOrigin[] = {0, 0, 0};
@@ -67,7 +67,7 @@ HWTEST_F(EnqueueCopyBufferRectTest, null_dst_mem_object) {
6767
EXPECT_EQ(CL_INVALID_MEM_OBJECT, retVal);
6868
}
6969

70-
HWTEST_F(EnqueueCopyBufferRectTest, returnSuccess) {
70+
HWTEST_F(EnqueueCopyBufferRectTest, GivenValidParametersWhenCopyingBufferRectThenSuccessIsReturned) {
7171
auto retVal = CL_SUCCESS;
7272
size_t srcOrigin[] = {0, 0, 0};
7373
size_t dstOrigin[] = {0, 0, 0};
@@ -91,7 +91,7 @@ HWTEST_F(EnqueueCopyBufferRectTest, returnSuccess) {
9191
EXPECT_EQ(CL_SUCCESS, retVal);
9292
}
9393

94-
HWTEST_F(EnqueueCopyBufferRectTest, alignsToCSR) {
94+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenTaskCountIsAlignedWithCsr) {
9595
//this test case assumes IOQ
9696
auto &csr = pDevice->getUltCommandStreamReceiver<FamilyType>();
9797
csr.taskCount = pCmdQ->taskCount + 100;
@@ -102,7 +102,7 @@ HWTEST_F(EnqueueCopyBufferRectTest, alignsToCSR) {
102102
EXPECT_EQ(csr.peekTaskLevel(), pCmdQ->taskLevel + 1);
103103
}
104104

105-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_GPGPUWalker) {
105+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenGpgpuWalkerIsCorrect) {
106106
typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER;
107107
enqueueCopyBufferRect2D<FamilyType>();
108108

@@ -134,21 +134,21 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_GPGPUWalker) {
134134
}
135135
}
136136

137-
HWTEST_F(EnqueueCopyBufferRectTest, 2D_bumpsTaskLevel) {
137+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenTaskLevelIsIncremented) {
138138
auto taskLevelBefore = pCmdQ->taskLevel;
139139

140140
enqueueCopyBufferRect2D<FamilyType>();
141141
EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore);
142142
}
143143

144-
HWTEST_F(EnqueueCopyBufferRectTest, 2D_addsCommands) {
144+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenCommandsAreAdded) {
145145
auto usedCmdBufferBefore = pCS->getUsed();
146146

147147
enqueueCopyBufferRect2D<FamilyType>();
148148
EXPECT_NE(usedCmdBufferBefore, pCS->getUsed());
149149
}
150150

151-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_addsIndirectData) {
151+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenIndirectDataGetsAdded) {
152152
auto dshBefore = pDSH->getUsed();
153153
auto iohBefore = pIOH->getUsed();
154154
auto sshBefore = pSSH->getUsed();
@@ -184,7 +184,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_addsIndirectData) {
184184
}
185185
}
186186

187-
HWTEST_F(EnqueueCopyBufferRectTest, 2D_LoadRegisterImmediateL3CNTLREG) {
187+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenL3ProgrammingIsCorrect) {
188188
enqueueCopyBufferRect2D<FamilyType>();
189189
validateL3Programming<FamilyType>(cmdList, itorWalker);
190190
}
@@ -195,7 +195,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, When2DEnqueueIsDoneThenSt
195195
pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu);
196196
}
197197

198-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_MediaInterfaceDescriptorLoad) {
198+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenMediaInterfaceDescriptorLoadIsCorrect) {
199199
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
200200
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
201201

@@ -220,7 +220,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_MediaInterfaceDescript
220220
FamilyType::PARSE::template validateCommand<MEDIA_INTERFACE_DESCRIPTOR_LOAD *>(cmdList.begin(), itorMediaInterfaceDescriptorLoad);
221221
}
222222

223-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_InterfaceDescriptorData) {
223+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenInterfaceDescriptorDataIsCorrect) {
224224
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
225225
typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS;
226226
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
@@ -239,18 +239,18 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_InterfaceDescriptorDat
239239
EXPECT_NE(0u, IDD.getConstantIndirectUrbEntryReadLength());
240240
}
241241

242-
HWTEST_F(EnqueueCopyBufferRectTest, 2D_PipelineSelect) {
242+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenNumberOfPipelineSelectsIsOne) {
243243
enqueueCopyBufferRect2D<FamilyType>();
244244
int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect<FamilyType>();
245245
EXPECT_EQ(1, numCommands);
246246
}
247247

248-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 2D_MediaVFEState) {
248+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect2DThenMediaVfeStateIsSetCorrectly) {
249249
enqueueCopyBufferRect2D<FamilyType>();
250250
validateMediaVFEState<FamilyType>(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState);
251251
}
252252

253-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_GPGPUWalker) {
253+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenGpgpuWalkerIsCorrect) {
254254
typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER;
255255
enqueueCopyBufferRect3D<FamilyType>();
256256

@@ -280,33 +280,30 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_GPGPUWalker) {
280280
lanesPerThreadX += laneMaskRight & 1;
281281
laneMaskRight >>= 1;
282282
}
283-
284-
//auto numWorkItems = ( ( cmd->getThreadWidthCounterMaximum() - 1 ) * simd + lanesPerThreadX ) * cmd->getThreadGroupIdXDimension();
285-
//EXPECT_EQ( expectedWorkItems, numWorkItems );
286283
}
287284

288-
HWTEST_F(EnqueueCopyBufferRectTest, 3D_bumpsTaskLevel) {
285+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenTaskLevelIsIncremented) {
289286
auto taskLevelBefore = pCmdQ->taskLevel;
290287

291288
enqueueCopyBufferRect3D<FamilyType>();
292289
EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore);
293290
}
294291

295-
HWTEST_F(EnqueueCopyBufferRectTest, 3D_addsCommands) {
292+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenCommandsAreAdded) {
296293
auto usedCmdBufferBefore = pCS->getUsed();
297294

298295
enqueueCopyBufferRect3D<FamilyType>();
299296
EXPECT_NE(usedCmdBufferBefore, pCS->getUsed());
300297
}
301298

302-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_addsIndirectData) {
299+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenIndirectDataIsAdded) {
303300
auto usedIndirectHeapBefore = pDSH->getUsed();
304301

305302
enqueueCopyBufferRect3D<FamilyType>();
306303
EXPECT_NE(usedIndirectHeapBefore, pDSH->getUsed());
307304
}
308305

309-
HWTEST_F(EnqueueCopyBufferRectTest, 3D_LoadRegisterImmediateL3CNTLREG) {
306+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenL3ProgrammingIsCorrect) {
310307
enqueueCopyBufferRect3D<FamilyType>();
311308
validateL3Programming<FamilyType>(cmdList, itorWalker);
312309
}
@@ -317,7 +314,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, When3DEnqueueIsDoneThenSt
317314
pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu);
318315
}
319316

320-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_MediaInterfaceDescriptorLoad) {
317+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenMediaInterfaceDescriptorLoadIsCorrect) {
321318
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
322319
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
323320

@@ -342,7 +339,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_MediaInterfaceDescript
342339
FamilyType::PARSE::template validateCommand<MEDIA_INTERFACE_DESCRIPTOR_LOAD *>(cmdList.begin(), itorMediaInterfaceDescriptorLoad);
343340
}
344341

345-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_InterfaceDescriptorData) {
342+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenInterfaceDescriptorDataIsCorrect) {
346343
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
347344
typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS;
348345
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
@@ -361,13 +358,13 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_InterfaceDescriptorDat
361358
EXPECT_NE(0u, IDD.getConstantIndirectUrbEntryReadLength());
362359
}
363360

364-
HWTEST_F(EnqueueCopyBufferRectTest, 3D_PipelineSelect) {
361+
HWTEST_F(EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenNumberOfPipelineSelectsIsOne) {
365362
enqueueCopyBufferRect3D<FamilyType>();
366363
int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect<FamilyType>();
367364
EXPECT_EQ(1, numCommands);
368365
}
369366

370-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, 3D_MediaVFEState) {
367+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueCopyBufferRectTest, WhenCopyingBufferRect3DThenMediaVfeStateIsSetCorrectly) {
371368
enqueueCopyBufferRect3D<FamilyType>();
372369
validateMediaVFEState<FamilyType>(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState);
373370
}

0 commit comments

Comments
 (0)