Remove redundant debug flag.

- We now have ForceSystemMemoryPlacement to achieve the same.

Change-Id: I84512b0f8b070edbdbd54fdce46a2958afb8ef41
Signed-off-by: Michal Mrozek <michal.mrozek@intel.com>

Author: MichalMrozek

opencl/test/unit_test/memory_manager/memory_manager_allocate_in_preferred_pool_tests.inl

@@ -130,24 +130,6 @@ TEST(MemoryManagerGetAlloctionDataTest, givenDefaultAllocationFlagsWhenAllocatio
     EXPECT_FALSE(allocData.flags.allocateMemory);
 }
 
-TEST(MemoryManagerGetAlloctionDataTest, givenDebugModeToForceBuffersToSystemMemoryWhenGetAllocationDataIsCalledThenSystemMemoryIsRequired) {
-    DebugManagerStateRestore restorer;
-    DebugManager.flags.ForceBuffersToSystemMemory.set(true);
-
-    AllocationData allocData;
-    AllocationProperties properties(0, true, 0, GraphicsAllocation::AllocationType::BUFFER, false);
-    MockMemoryManager mockMemoryManager;
-    MockMemoryManager::getAllocationData(allocData, properties, nullptr, mockMemoryManager.createStorageInfoFromProperties(properties));
-
-    EXPECT_TRUE(allocData.flags.useSystemMemory);
-
-    //do not affect BUFFER COMPRESSED
-    allocData.flags.useSystemMemory = false;
-    AllocationProperties properties2(0, true, 0, GraphicsAllocation::AllocationType::BUFFER_COMPRESSED, false);
-    MockMemoryManager::getAllocationData(allocData, properties2, nullptr, mockMemoryManager.createStorageInfoFromProperties(properties));
-    EXPECT_FALSE(allocData.flags.useSystemMemory);
-}
-
 TEST(MemoryManagerGetAlloctionDataTest, givenDebugModeWhenCertainAllocationTypesAreSelectedThenSystemPlacementIsChoosen) {
     DebugManagerStateRestore restorer;
     auto allocationType = GraphicsAllocation::AllocationType::BUFFER;

opencl/test/unit_test/test_files/igdrcl.config

@@ -141,6 +141,5 @@ DirectSubmissionDisableMonitorFence = 0
 ForceFineGrainedSVMSupport = -1
 DirectSubmissionBufferAddressing = -1
 DirectSubmissionSemaphoreAddressing = -1
-ForceBuffersToSystemMemory = 0
 Report64BitIdentifier = 0
 DirectSubmissionDiagnosticExecutionCount = 30

shared/source/debug_settings/debug_variables_base.inl

@@ -105,7 +105,6 @@ DECLARE_DEBUG_VARIABLE(bool, UseNoRingFlushesKmdMode, true, "Windows only, passe
 DECLARE_DEBUG_VARIABLE(bool, DisableZeroCopyForUseHostPtr, false, "When active all buffer allocations created with CL_MEM_USE_HOST_PTR flag will not share memory with CPU.")
 DECLARE_DEBUG_VARIABLE(bool, DisableZeroCopyForBuffers, false, "When active all buffer allocations will not share memory with CPU.")
 DECLARE_DEBUG_VARIABLE(bool, DisableDcFlushInEpilogue, false, "Disable DC flush in epilogue")
-DECLARE_DEBUG_VARIABLE(bool, ForceBuffersToSystemMemory, false, "Forces buffers to be in system memory")
 DECLARE_DEBUG_VARIABLE(int32_t, EnableHostPtrTracking, -1, "Enable host ptr tracking: -1 - default platform setting, 0 - disabled, 1 - enabled")
 
 /*FEATURE FLAGS*/

shared/source/memory_manager/memory_manager.cpp

@@ -300,12 +300,6 @@ bool MemoryManager::getAllocationData(AllocationData &allocationData, const Allo
         break;
     }
 
-    if (DebugManager.flags.ForceBuffersToSystemMemory.get()) {
-        if (properties.allocationType == GraphicsAllocation::AllocationType::BUFFER) {
-            allocationData.flags.useSystemMemory = true;
-        }
-    }
-
     if (DebugManager.flags.ForceSystemMemoryPlacement.get()) {
         if ((1llu << (static_cast<int64_t>(properties.allocationType) - 1)) & DebugManager.flags.ForceSystemMemoryPlacement.get()) {
             allocationData.flags.useSystemMemory = true;