Do no increment ref counts when passing OsContext to residency.

- not needed anymore, memory manager manages the ilfecycle of OsContext

Change-Id: Ibcb32954522dd862187cf97d62d2e0b1b10e50e5

Author: MichalMrozek

runtime/memory_manager/residency.cpp

@@ -28,14 +28,7 @@ using namespace OCLRT;
 
 void ResidencyData::addOsContext(OsContext *osContext) {
     if (!this->osContext) {
-        osContext->incRefInternal();
         this->osContext = osContext;
     }
     DEBUG_BREAK_IF(this->osContext != osContext);
 }
-
-ResidencyData::~ResidencyData() {
-    if (osContext) {
-        osContext->decRefInternal();
-    }
-}

runtime/memory_manager/residency.h

@@ -28,7 +28,7 @@ class OsContext;
 struct ResidencyData {
     ResidencyData() = default;
     void addOsContext(OsContext *osContext);
-    ~ResidencyData();
+    ~ResidencyData() = default;
     bool resident = false;
     uint64_t lastFence = 0;
     OsContext *osContext = nullptr;

unit_tests/memory_manager/memory_manager_tests.cpp

@@ -1802,33 +1802,21 @@ TEST(GraphicsAllocation, givenSharedHandleBasedConstructorWhenGraphicsAllocation
     EXPECT_EQ(expectedGpuAddress, graphicsAllocation.getGpuAddress());
 }
 
-TEST(ResidencyDataTest, givenResidencyDataWithOsContextWhenDestructorIsCalledThenDecrementRefCount) {
-    OsContext *osContext = new OsContext(nullptr);
-    osContext->incRefInternal();
-    EXPECT_EQ(1, osContext->getRefInternalCount());
-    {
-        ResidencyData residencyData;
-        residencyData.addOsContext(osContext);
-        EXPECT_EQ(2, osContext->getRefInternalCount());
-    }
-    EXPECT_EQ(1, osContext->getRefInternalCount());
-    osContext->decRefInternal();
-}
-
-TEST(ResidencyDataTest, givenResidencyDataWhenAddTheSameOsContextTwiceThenIncrementRefCounterOnlyOnce) {
-    OsContext *osContext = new OsContext(nullptr);
-    ResidencyData residencyData;
-    EXPECT_EQ(0, osContext->getRefInternalCount());
-    residencyData.addOsContext(osContext);
-    EXPECT_EQ(1, osContext->getRefInternalCount());
-    residencyData.addOsContext(osContext);
-    EXPECT_EQ(1, osContext->getRefInternalCount());
-}
-
 TEST(ResidencyDataTest, givenOsContextWhenItIsRegisteredToMemoryManagerThenRefCountIncreases) {
     auto osContext = new OsContext(nullptr);
     OsAgnosticMemoryManager memoryManager;
     memoryManager.registerOsContext(osContext);
     EXPECT_EQ(1u, memoryManager.getOsContextCount());
     EXPECT_EQ(1, osContext->getRefInternalCount());
 }
+
+TEST(ResidencyDataTest, givenOsContextWhenItIsAddedToResidencyThenItCantBeOverwritten) {
+    ResidencyData residency;
+    OsContext osContext(nullptr);
+    OsContext osContext2(nullptr);
+    EXPECT_EQ(nullptr, residency.osContext);
+    residency.addOsContext(&osContext);
+    EXPECT_EQ(&osContext, residency.osContext);
+    residency.addOsContext(&osContext2);
+    EXPECT_EQ(&osContext, residency.osContext);
+}