Introduce SBA tracking buffer allocation

Related-To: NEO-4637

- allocate sbaAllocation in L0 debugger

Change-Id: Ia1be1ad637bbdd6e7f12ca6fdfb0c486ba23a040
Signed-off-by: Mateusz Hoppe <mateusz.hoppe@intel.com>

Author: HoppeMateusz

level_zero/core/source/debugger/debugger_l0.cpp

@@ -7,8 +7,29 @@
 
 #include "level_zero/core/source/debugger/debugger_l0.h"
 
+#include "shared/source/device/device.h"
+#include "shared/source/helpers/constants.h"
+#include "shared/source/memory_manager/allocation_properties.h"
+#include "shared/source/memory_manager/memory_manager.h"
+
 namespace L0 {
+DebuggerL0::DebuggerL0(NEO::Device *device) : device(device) {
+    isLegacyMode = false;
+
+    NEO::AllocationProperties properties{device->getRootDeviceIndex(), true, MemoryConstants::pageSize,
+                                         NEO::GraphicsAllocation::AllocationType::DEBUG_SBA_TRACKING_BUFFER,
+                                         false,
+                                         CommonConstants::allDevicesBitfield};
+
+    sbaAllocation = device->getMemoryManager()->allocateGraphicsMemoryWithProperties(properties);
+}
+
+DebuggerL0 ::~DebuggerL0() {
+    device->getMemoryManager()->freeGraphicsMemory(sbaAllocation);
+}
+
 bool DebuggerL0::isDebuggerActive() {
     return true;
 }
+
 } // namespace L0

level_zero/core/source/debugger/debugger_l0.h

@@ -13,20 +13,34 @@
 
 namespace NEO {
 class Device;
-}
+class GraphicsAllocation;
+} // namespace NEO
 
 namespace L0 {
+struct SbaTrackedAddresses {
+    uint64_t GeneralStateBaseAddress;
+    uint64_t SurfaceStateBaseAddress;
+    uint64_t DynamicStateBaseAddress;
+    uint64_t IndirectObjectBaseAddress;
+    uint64_t InstructionBaseAddress;
+    uint64_t BindlessSurfaceStateBaseAddress;
+    uint64_t BindlessSamplerStateBaseAddress;
+};
+
 class DebuggerL0 : public NEO::Debugger, NEO::NonCopyableOrMovableClass {
   public:
     static std::unique_ptr<Debugger> create(NEO::Device *device);
     bool isDebuggerActive() override;
 
-    DebuggerL0(NEO::Device *device) : device(device) {
-        isLegacyMode = false;
+    DebuggerL0(NEO::Device *device);
+    ~DebuggerL0() override;
+
+    NEO::GraphicsAllocation *getSbaTrackingBuffer() {
+        return sbaAllocation;
     }
-    ~DebuggerL0() override = default;
 
   protected:
     NEO::Device *device = nullptr;
+    NEO::GraphicsAllocation *sbaAllocation = nullptr;
 };
 } // namespace L0

level_zero/core/source/device/device.h

@@ -13,6 +13,7 @@
 #include "shared/source/helpers/hw_info.h"
 #include "shared/source/os_interface/os_interface.h"
 
+#include "level_zero/core/source/debugger/debugger_l0.h"
 #include "level_zero/core/source/driver/driver.h"
 #include "level_zero/core/source/driver/driver_handle.h"
 #include <level_zero/ze_api.h>
@@ -107,6 +108,13 @@ struct Device : _ze_device_handle_t {
     virtual const NEO::DeviceInfo &getDeviceInfo() const = 0;
     virtual NEO::Device *getNEODevice() = 0;
     NEO::SourceLevelDebugger *getSourceLevelDebugger() { return getNEODevice()->getSourceLevelDebugger(); }
+    DebuggerL0 *getL0Debugger() {
+        auto debugger = getNEODevice()->getDebugger();
+        if (debugger) {
+            return !debugger->isLegacy() ? static_cast<DebuggerL0 *>(debugger) : nullptr;
+        }
+        return nullptr;
+    }
 
     virtual NEO::GraphicsAllocation *getDebugSurface() const = 0;
 

level_zero/core/test/unit_tests/sources/debugger/test_l0_debugger.cpp

@@ -27,10 +27,21 @@ TEST_F(L0DebuggerTest, givenL0DebuggerWhenGettingSourceLevelDebuggerThenNullptrR
     EXPECT_EQ(nullptr, neoDevice->getSourceLevelDebugger());
 }
 
+TEST_F(L0DebuggerTest, givenL0DebuggerWhenGettingL0DebuggerThenValidDebuggerInstanceIsReturned) {
+    EXPECT_NE(nullptr, device->getL0Debugger());
+}
+
 TEST_F(L0DebuggerTest, givenL0DebuggerWhenCallingIsDebuggerActiveThenTrueIsReturned) {
     EXPECT_TRUE(neoDevice->getDebugger()->isDebuggerActive());
 }
 
+TEST_F(L0DebuggerTest, givenL0DebuggerWhenCreatedThenSbaTrackingBufferIsAllocated) {
+    auto debugger = device->getL0Debugger();
+    ASSERT_NE(nullptr, debugger);
+    ASSERT_NE(nullptr, debugger->getSbaTrackingBuffer());
+    EXPECT_EQ(NEO::GraphicsAllocation::AllocationType::DEBUG_SBA_TRACKING_BUFFER, debugger->getSbaTrackingBuffer()->getAllocationType());
+}
+
 HWTEST_F(L0DebuggerTest, givenDebuggingEnabledWhenCommandListIsExecutedThenKernelDebugCommandsAreAdded) {
     using MI_LOAD_REGISTER_IMM = typename FamilyType::MI_LOAD_REGISTER_IMM;
     using STATE_SIP = typename FamilyType::STATE_SIP;

level_zero/core/test/unit_tests/sources/debugger/test_source_level_debugger.cpp

@@ -78,6 +78,10 @@ TEST_F(DeviceWithDebuggerEnabledTest, givenDebuggingEnabledWhenDeviceIsCreatedTh
     EXPECT_EQ(NEO::GraphicsAllocation::AllocationType::DEBUG_CONTEXT_SAVE_AREA, deviceL0->getDebugSurface()->getAllocationType());
 }
 
+TEST_F(DeviceWithDebuggerEnabledTest, givenSldDebuggerWhenGettingL0DebuggerThenNullptrIsReturned) {
+    EXPECT_EQ(nullptr, deviceL0->getL0Debugger());
+}
+
 struct TwoSubDevicesDebuggerEnabledTest : public ActiveDebuggerFixture, public ::testing::Test {
     void SetUp() override { // NOLINT(readability-identifier-naming)
         DebugManager.flags.CreateMultipleSubDevices.set(2);

level_zero/core/test/unit_tests/sources/device/test_device.cpp

@@ -492,5 +492,9 @@ TEST_F(DeviceTest, givenNoActiveSourceLevelDebuggerWhenGetIsCalledThenNullptrIsR
     EXPECT_EQ(nullptr, device->getSourceLevelDebugger());
 }
 
+TEST_F(DeviceTest, givenNoL0DebuggerWhenGettingL0DebuggerThenNullptrReturned) {
+    EXPECT_EQ(nullptr, device->getL0Debugger());
+}
+
 } // namespace ult
 } // namespace L0

opencl/source/utilities/logger.cpp

@@ -326,6 +326,8 @@ const char *FileLogger<DebugLevel>::getAllocationTypeString(GraphicsAllocation c
         return "WRITE_COMBINED";
     case GraphicsAllocation::AllocationType::DEBUG_CONTEXT_SAVE_AREA:
         return "DEBUG_CONTEXT_SAVE_AREA";
+    case GraphicsAllocation::AllocationType::DEBUG_SBA_TRACKING_BUFFER:
+        return "DEBUG_SBA_TRACKING_BUFFER";
     default:
         return "ILLEGAL_VALUE";
     }

opencl/test/unit_test/utilities/file_logger_tests.cpp

@@ -931,7 +931,8 @@ AllocationTypeTestCase allocationTypeValues[] = {
     {GraphicsAllocation::AllocationType::TIMESTAMP_PACKET_TAG_BUFFER, "TIMESTAMP_PACKET_TAG_BUFFER"},
     {GraphicsAllocation::AllocationType::UNKNOWN, "UNKNOWN"},
     {GraphicsAllocation::AllocationType::WRITE_COMBINED, "WRITE_COMBINED"},
-    {GraphicsAllocation::AllocationType::DEBUG_CONTEXT_SAVE_AREA, "DEBUG_CONTEXT_SAVE_AREA"}};
+    {GraphicsAllocation::AllocationType::DEBUG_CONTEXT_SAVE_AREA, "DEBUG_CONTEXT_SAVE_AREA"},
+    {GraphicsAllocation::AllocationType::DEBUG_SBA_TRACKING_BUFFER, "DEBUG_SBA_TRACKING_BUFFER"}};
 
 class AllocationTypeLogging : public ::testing::TestWithParam<AllocationTypeTestCase> {};
 

shared/source/memory_manager/graphics_allocation.h

@@ -84,7 +84,8 @@ class GraphicsAllocation : public IDNode<GraphicsAllocation> {
         WRITE_COMBINED,
         RING_BUFFER,
         SEMAPHORE_BUFFER,
-        DEBUG_CONTEXT_SAVE_AREA
+        DEBUG_CONTEXT_SAVE_AREA,
+        DEBUG_SBA_TRACKING_BUFFER
     };
 
     ~GraphicsAllocation() override;