Skip to content

Commit 582a362

Browse files
Remove not needed hwHelper
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
1 parent 5a75f4b commit 582a362

File tree

6 files changed

+3
-30
lines changed

6 files changed

+3
-30
lines changed

opencl/test/unit_test/aub_tests/command_stream/aub_command_stream_fixture.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ class AUBCommandStreamFixture : public CommandStreamFixture {
6060
if (testMode == TestMode::AubTestsWithTbx) {
6161
auto tbxCsr = static_cast<CommandStreamReceiverSimulatedCommonHw<FamilyType> *>(pCommandStreamReceiver);
6262
EXPECT_TRUE(tbxCsr->expectMemoryEqual(gfxAddress, srcAddress, length));
63-
6463
csr = static_cast<CommandStreamReceiverWithAUBDump<TbxCommandStreamReceiverHw<FamilyType>> *>(pCommandStreamReceiver)->aubCSR.get();
6564
}
6665

@@ -76,7 +75,6 @@ class AUBCommandStreamFixture : public CommandStreamFixture {
7675
if (testMode == TestMode::AubTestsWithTbx) {
7776
auto tbxCsr = static_cast<CommandStreamReceiverSimulatedCommonHw<FamilyType> *>(pCommandStreamReceiver);
7877
EXPECT_TRUE(tbxCsr->expectMemoryNotEqual(gfxAddress, srcAddress, length));
79-
8078
csr = static_cast<CommandStreamReceiverWithAUBDump<TbxCommandStreamReceiverHw<FamilyType>> *>(pCommandStreamReceiver)->aubCSR.get();
8179
}
8280

opencl/test/unit_test/gmm_helper/gmm_helper_tests.cpp

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -351,18 +351,9 @@ TEST_F(GmmTests, givenNonZeroRowPitchWhenQueryImgFromBufferParamsThenUseUserValu
351351
EXPECT_EQ(imgInfo.rowPitch, expectedRowPitch);
352352
}
353353

354-
struct GmmTestsCanonize : public GmmTests {
355-
void SetUp() override {
356-
uint32_t addressWidth = 48u;
357-
HwHelper::get(renderCoreFamily).adjustAddressWidthForCanonize(addressWidth);
358-
if (addressWidth != 48u) {
359-
GTEST_SKIP();
360-
}
361-
GmmTests::SetUp();
362-
}
363-
};
354+
using GmmCanonizeTests = GmmTests;
364355

365-
TEST_F(GmmTestsCanonize, WhenCanonizingThenCorrectAddressIsReturned) {
356+
TEST_F(GmmCanonizeTests, WhenCanonizingThenCorrectAddressIsReturned) {
366357
auto hwInfo = *defaultHwInfo;
367358

368359
// 48 bit - canonize to 48 bit
@@ -385,7 +376,7 @@ TEST_F(GmmTestsCanonize, WhenCanonizingThenCorrectAddressIsReturned) {
385376
EXPECT_EQ(GmmHelper::canonize(testAddr2), goodAddr2);
386377
}
387378

388-
TEST_F(GmmTestsCanonize, WhenDecanonizingThenCorrectAddressIsReturned) {
379+
TEST_F(GmmCanonizeTests, WhenDecanonizingThenCorrectAddressIsReturned) {
389380
auto hwInfo = *defaultHwInfo;
390381

391382
// 48 bit - decanonize to 48 bit

opencl/test/unit_test/helpers/hw_helper_tests.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,14 +1158,6 @@ HWTEST_F(HwHelperTest, givenHwHelperWhenAskingForIsaSystemMemoryPlacementThenRet
11581158
EXPECT_NE(localMemoryEnabled, hwHelper.useSystemMemoryPlacementForISA(hardwareInfo));
11591159
}
11601160

1161-
HWTEST_F(HwHelperTest, givenHwHelperWhenAdjustAddressWidthForCanonizeThenAddressWidthDoesntChange) {
1162-
HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily);
1163-
uint32_t addressWidth = 48;
1164-
1165-
hwHelper.adjustAddressWidthForCanonize(addressWidth);
1166-
EXPECT_EQ(48u, addressWidth);
1167-
}
1168-
11691161
TEST_F(HwHelperTest, givenInvalidEngineTypeWhenGettingEngineGroupTypeThenThrow) {
11701162
HwHelper &hwHelper = HwHelper::get(hardwareInfo.platform.eRenderCoreFamily);
11711163
EXPECT_ANY_THROW(hwHelper.getEngineGroupType(aub_stream::EngineType::NUM_ENGINES, hardwareInfo));

shared/source/gmm_helper/gmm_helper.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ uint32_t GmmHelper::getMOCS(uint32_t type) const {
3737

3838
GmmHelper::GmmHelper(OSInterface *osInterface, const HardwareInfo *pHwInfo) : hwInfo(pHwInfo) {
3939
auto hwInfoAddressWidth = Math::log2(hwInfo->capabilityTable.gpuAddressSpace + 1);
40-
HwHelper::get(hwInfo->platform.eRenderCoreFamily).adjustAddressWidthForCanonize(hwInfoAddressWidth);
4140
GmmHelper::addressWidth = std::max(hwInfoAddressWidth, static_cast<uint32_t>(48));
4241

4342
gmmClientContext = GmmHelper::createGmmContextWrapperFunc(osInterface, const_cast<HardwareInfo *>(pHwInfo));

shared/source/helpers/hw_helper.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ class HwHelper {
132132
virtual bool isCooperativeDispatchSupported(const EngineGroupType engineGroupType, const PRODUCT_FAMILY productFamily) const = 0;
133133
virtual size_t getMaxFillPaternSizeForCopyEngine() const = 0;
134134
virtual bool isCopyOnlyEngineType(EngineGroupType type) const = 0;
135-
virtual void adjustAddressWidthForCanonize(uint32_t &addressWidth) const = 0;
136135
virtual bool isSipWANeeded(const HardwareInfo &hwInfo) const = 0;
137136
virtual bool isDisableOverdispatchAvailable(const HardwareInfo &hwInfo) const = 0;
138137
virtual bool isCpuImageTransferPreferred(const HardwareInfo &hwInfo) const = 0;
@@ -355,8 +354,6 @@ class HwHelperHw : public HwHelper {
355354

356355
bool isCopyOnlyEngineType(EngineGroupType type) const override;
357356

358-
void adjustAddressWidthForCanonize(uint32_t &addressWidth) const override;
359-
360357
bool isSipWANeeded(const HardwareInfo &hwInfo) const override;
361358

362359
bool isDisableOverdispatchAvailable(const HardwareInfo &hwInfo) const override;

shared/source/helpers/hw_helper_base.inl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -621,10 +621,6 @@ bool HwHelperHw<GfxFamily>::isCopyOnlyEngineType(EngineGroupType type) const {
621621
return NEO::EngineGroupType::Copy == type;
622622
}
623623

624-
template <typename GfxFamily>
625-
void HwHelperHw<GfxFamily>::adjustAddressWidthForCanonize(uint32_t &addressWidth) const {
626-
}
627-
628624
template <typename GfxFamily>
629625
bool HwHelperHw<GfxFamily>::isSipWANeeded(const HardwareInfo &hwInfo) const {
630626
return false;

0 commit comments

Comments
 (0)