Minor code cleanup

prevent nullptr dereference

Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>

Author: JablonskiMateusz

opencl/source/memory_manager/migration_controller.cpp

@@ -17,9 +17,6 @@
 #include "opencl/source/mem_obj/mem_obj.h"
 
 namespace NEO {
-class MemoryManager;
-class CommandStreamReceiver;
-class MultiGraphicsAllocation;
 void MigrationController::handleMigration(Context &context, CommandStreamReceiver &targetCsr, MemObj *memObj) {
     auto memoryManager = targetCsr.getMemoryManager();
     auto targetRootDeviceIndex = targetCsr.getRootDeviceIndex();

shared/source/memory_manager/multi_graphics_allocation.cpp

@@ -74,7 +74,9 @@ StackVec<GraphicsAllocation *, 1> const &MultiGraphicsAllocation::getGraphicsAll
 void MultiGraphicsAllocation::setMultiStorage(bool value) {
     isMultiStorage = value;
     if (isMultiStorage && !migrationSyncData) {
-        migrationSyncData = createMigrationSyncDataFunc(getDefaultGraphicsAllocation()->getUnderlyingBufferSize());
+        auto graphicsAllocation = getDefaultGraphicsAllocation();
+        UNRECOVERABLE_IF(!graphicsAllocation);
+        migrationSyncData = createMigrationSyncDataFunc(graphicsAllocation->getUnderlyingBufferSize());
         migrationSyncData->incRefInternal();
     }
 }

shared/test/unit_test/memory_manager/multi_graphics_allocation_tests.cpp

@@ -255,6 +255,12 @@ TEST_F(MigrationSyncDataTests, whenMigrationSyncDataExistsAndSetMultiStorageIsCa
     EXPECT_EQ(migrationSyncData, multiGraphicsAllocation.getMigrationSyncData());
 }
 
+TEST(MigrationSyncDataTest, givenEmptyMultiGraphicsAllocationWhenSetMultiStorageIsCalledThenAbortIsCalled) {
+    MultiGraphicsAllocation multiGraphicsAllocation(1);
+    EXPECT_EQ(nullptr, multiGraphicsAllocation.getDefaultGraphicsAllocation());
+    EXPECT_THROW(multiGraphicsAllocation.setMultiStorage(true), std::exception);
+}
+
 TEST_F(MigrationSyncDataTests, whenMigrationIsNotStartedThenMigrationIsNotInProgress) {
     EXPECT_FALSE(migrationSyncData->isMigrationInProgress());