Skip to content

Commit 4786f1a

Browse files
Refactor HardwareCommandsHelper
Change-Id: I15dcbf445565228a0e520b25265a1752ead70a28 Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
1 parent 9dc7e2c commit 4786f1a

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

opencl/source/helpers/hardware_commands_helper.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,15 @@ struct HardwareCommandsHelper : public PerThreadDataHelper {
4242
uint64_t offsetInterfaceDescriptor,
4343
INTERFACE_DESCRIPTOR_DATA *inlineInterfaceDescriptor);
4444

45-
static void setAdditionalInfo(
45+
static void setGrfInfo(
4646
INTERFACE_DESCRIPTOR_DATA *pInterfaceDescriptor,
4747
const Kernel &kernel,
4848
const size_t &sizeCrossThreadData,
49-
const size_t &sizePerThreadData,
49+
const size_t &sizePerThreadData);
50+
51+
static void setAdditionalInfo(
52+
INTERFACE_DESCRIPTOR_DATA *pInterfaceDescriptor,
53+
const Kernel &kernel,
5054
const uint32_t threadsPerThreadGroup);
5155

5256
inline static uint32_t additionalSizeRequiredDsh();

opencl/source/helpers/hardware_commands_helper_base.inl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,8 @@ size_t HardwareCommandsHelper<GfxFamily>::sendInterfaceDescriptorData(
194194

195195
pInterfaceDescriptor->setDenormMode(INTERFACE_DESCRIPTOR_DATA::DENORM_MODE_SETBYKERNEL);
196196

197-
setAdditionalInfo(pInterfaceDescriptor, kernel, sizeCrossThreadData, sizePerThreadData, threadsPerThreadGroup);
197+
setGrfInfo(pInterfaceDescriptor, kernel, sizeCrossThreadData, sizePerThreadData);
198+
setAdditionalInfo(pInterfaceDescriptor, kernel, threadsPerThreadGroup);
198199

199200
pInterfaceDescriptor->setBindingTablePointer(static_cast<uint32_t>(bindingTablePointer));
200201

opencl/source/helpers/hardware_commands_helper_bdw_plus.inl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,8 @@ typename HardwareCommandsHelper<GfxFamily>::INTERFACE_DESCRIPTOR_DATA *HardwareC
2525
}
2626

2727
template <typename GfxFamily>
28-
void HardwareCommandsHelper<GfxFamily>::setAdditionalInfo(
29-
INTERFACE_DESCRIPTOR_DATA *pInterfaceDescriptor,
30-
const Kernel &kernel,
31-
const size_t &sizeCrossThreadData,
32-
const size_t &sizePerThreadData,
33-
const uint32_t threadsPerThreadGroup) {
28+
void HardwareCommandsHelper<GfxFamily>::setGrfInfo(INTERFACE_DESCRIPTOR_DATA *pInterfaceDescriptor, const Kernel &kernel,
29+
const size_t &sizeCrossThreadData, const size_t &sizePerThreadData) {
3430
auto grfSize = sizeof(typename GfxFamily::GRF);
3531
DEBUG_BREAK_IF((sizeCrossThreadData % grfSize) != 0);
3632
auto numGrfCrossThreadData = static_cast<uint32_t>(sizeCrossThreadData / grfSize);
@@ -45,6 +41,9 @@ void HardwareCommandsHelper<GfxFamily>::setAdditionalInfo(
4541
pInterfaceDescriptor->setConstantIndirectUrbEntryReadLength(numGrfPerThreadData);
4642
}
4743

44+
template <typename GfxFamily>
45+
void HardwareCommandsHelper<GfxFamily>::setAdditionalInfo(INTERFACE_DESCRIPTOR_DATA *pInterfaceDescriptor, const Kernel &kernel, const uint32_t threadsPerThreadGroup) {}
46+
4847
template <typename GfxFamily>
4948
uint32_t HardwareCommandsHelper<GfxFamily>::additionalSizeRequiredDsh() {
5049
return sizeof(INTERFACE_DESCRIPTOR_DATA);

0 commit comments

Comments
 (0)