fix flaky unit test MockSingleThreadJobScheduler.Run

Jaesoo Lee · facebook-github-bot · commit 623e51946a36 · 2023-09-28T21:12:48.000-07:00
Summary: This change fixes the unit test MockSingleThreadJobScheduler.Run which is flaky (e.g, https://fburl.com/testinfra/bocbnkui). The reason for failures are that the main thread checks the stats before the job just unblocked by SeqPoints returns and is completed. The test was timing dependent. Reviewed By: therealgymmy Differential Revision: D49478329 fbshipit-source-id: ffae0df67858f216e0165be45bf314da6227fec8
diff --git a/cachelib/navy/testing/tests/MockJobSchedulerTest.cpp b/cachelib/navy/testing/tests/MockJobSchedulerTest.cpp
@@ -144,6 +144,7 @@ TEST(MockSingleThreadJobScheduler, Run) {
   sp.wait(0);
   sp.wait(1);
   sp.wait(2);
+  ex.finish();
   EXPECT_EQ(3, ex.getDoneCount());
 }
 } // namespace tests

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ TEST(MockSingleThreadJobScheduler, Run) {`
`144`	`144`	`sp.wait(0);`
`145`	`145`	`sp.wait(1);`
`146`	`146`	`sp.wait(2);`
	`147`	`+ ex.finish();`
`147`	`148`	`EXPECT_EQ(3, ex.getDoneCount());`
`148`	`149`	`}`
`149`	`150`	`} // namespace tests`