nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets

jtlayton · chucklever · commit 91da337e5d50 · 2024-07-22T09:47:39.000-04:00
When creating nfsd sockets via the netlink interface, we do want to register with the portmapper. Don't set SVC_SOCK_ANONYMOUS. Reported-by: Steve Dickson <steved@redhat.com> Fixes: 16a4711 ("NFSD: add listener-{set,get} netlink command") Cc: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
@@ -2069,8 +2069,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
 			continue;
 		}
 
-		ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,
-					      SVC_SOCK_ANONYMOUS,
+		ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,
 					      get_current_cred());
 		/* always save the latest error */
 		if (ret < 0)

Original file line number	Diff line number	Diff line change
`@@ -2069,8 +2069,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff skb, struct genl_info info)`
`2069`	`2069`	`continue;`
`2070`	`2070`	`}`
`2071`	`2071`
`2072`		`- ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,`
`2073`		`- SVC_SOCK_ANONYMOUS,`
	`2072`	`+ ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,`
`2074`	`2073`	`get_current_cred());`
`2075`	`2074`	`/* always save the latest error */`
`2076`	`2075`	`if (ret < 0)`