SUNRPC: Remove return value of svc_pool_wake_idle_thread()

neilbrown · chucklever · commit 2a4557452aac · 2023-08-29T17:45:22.000-04:00
The returned value is not used (any more), so don't return it.

Signed-off-by: NeilBrown &lt;neilb@suse.de&gt;
Signed-off-by: Chuck Lever &lt;chuck.lever@oracle.com&gt;
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
@@ -420,7 +420,7 @@ int		   svc_register(const struct svc_serv *, struct net *, const int,
 
 void		   svc_wake_up(struct svc_serv *);
 void		   svc_reserve(struct svc_rqst *rqstp, int space);
-bool		   svc_pool_wake_idle_thread(struct svc_pool *pool);
+void		   svc_pool_wake_idle_thread(struct svc_pool *pool);
 struct svc_pool   *svc_pool_for_cpu(struct svc_serv *serv);
 char *		   svc_print_addr(struct svc_rqst *, char *, size_t);
 const char *	   svc_proc_name(const struct svc_rqst *rqstp);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
@@ -697,11 +697,8 @@ svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool, int node)
  * service thread and marking it BUSY is atomic with respect to
  * other calls to svc_pool_wake_idle_thread().
  *
- * Return value:
- *   %true: An idle thread was awoken
- *   %false: No idle thread was found
  */
-bool svc_pool_wake_idle_thread(struct svc_pool *pool)
+void svc_pool_wake_idle_thread(struct svc_pool *pool)
 {
 	struct svc_rqst	*rqstp;
 
@@ -715,12 +712,11 @@ bool svc_pool_wake_idle_thread(struct svc_pool *pool)
 		rcu_read_unlock();
 		percpu_counter_inc(&pool->sp_threads_woken);
 		trace_svc_wake_up(rqstp->rq_task->pid);
-		return true;
+		return;
 	}
 	rcu_read_unlock();
 
 	set_bit(SP_CONGESTED, &pool->sp_flags);
-	return false;
 }
 
 static struct svc_pool *

Original file line number	Diff line number	Diff line change
`@@ -697,11 +697,8 @@ svc_prepare_thread(struct svc_serv serv, struct svc_pool pool, int node)`
`697`	`697`	`* service thread and marking it BUSY is atomic with respect to`
`698`	`698`	`* other calls to svc_pool_wake_idle_thread().`
`699`	`699`	`*`
`700`		`- * Return value:`
`701`		`- * %true: An idle thread was awoken`
`702`		`- * %false: No idle thread was found`
`703`	`700`	`*/`
`704`		`-bool svc_pool_wake_idle_thread(struct svc_pool *pool)`
	`701`	`+void svc_pool_wake_idle_thread(struct svc_pool *pool)`
`705`	`702`	`{`
`706`	`703`	`struct svc_rqst *rqstp;`
`707`	`704`
`@@ -715,12 +712,11 @@ bool svc_pool_wake_idle_thread(struct svc_pool *pool)`
`715`	`712`	`rcu_read_unlock();`
`716`	`713`	`percpu_counter_inc(&pool->sp_threads_woken);`
`717`	`714`	`trace_svc_wake_up(rqstp->rq_task->pid);`
`718`		`- return true;`
	`715`	`+ return;`
`719`	`716`	`}`
`720`	`717`	`rcu_read_unlock();`
`721`	`718`
`722`	`719`	`set_bit(SP_CONGESTED, &pool->sp_flags);`
`723`		`- return false;`
`724`	`720`	`}`
`725`	`721`
`726`	`722`	`static struct svc_pool *`