rtc: rx8025: fix incorrect register reference

yuta-hayama · alexandrebelloni · commit 162f24cbb0f6 · 2025-11-08T20:56:12.000+01:00
This code is intended to operate on the CTRL1 register, but ctrl[1] is actually CTRL2. Correctly, ctrl[0] is CTRL1. Signed-off-by: Yuta Hayama <hayama@lineo.co.jp> Fixes: 71af915 ("rtc: rx8025: fix 12/24 hour mode detection on RX-8035") Cc: stable@vger.kernel.org Link: https://patch.msgid.link/eae5f479-5d28-4a37-859d-d54794e7628c@lineo.co.jp Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
@@ -316,7 +316,7 @@ static int rx8025_init_client(struct i2c_client *client)
 			return hour_reg;
 		rx8025->is_24 = (hour_reg & RX8035_BIT_HOUR_1224);
 	} else {
-		rx8025->is_24 = (ctrl[1] & RX8025_BIT_CTRL1_1224);
+		rx8025->is_24 = (ctrl[0] & RX8025_BIT_CTRL1_1224);
 	}
 out:
 	return err;

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ static int rx8025_init_client(struct i2c_client *client)`
`316`	`316`	`return hour_reg;`
`317`	`317`	`rx8025->is_24 = (hour_reg & RX8035_BIT_HOUR_1224);`
`318`	`318`	`} else {`
`319`		`- rx8025->is_24 = (ctrl[1] & RX8025_BIT_CTRL1_1224);`
	`319`	`+ rx8025->is_24 = (ctrl[0] & RX8025_BIT_CTRL1_1224);`
`320`	`320`	`}`
`321`	`321`	`out:`
`322`	`322`	`return err;`