Skip to content

Commit 3f9dc73

Browse files
authored
fix(transport): change rate limit log messages from DEBUG to WARN level (#2687)
Rate limiting and abuse detection are important operational events that should be more visible than debug level logging. These conditions indicate potential issues with API usage patterns that operators should be aware of. Signed-off-by: Tomas Dabašinskas <tomas@dabasinskas.net>
1 parent 36bf7c9 commit 3f9dc73

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

github/transport.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (rlt *RateLimitTransport) RoundTrip(req *http.Request) (*http.Response, err
9191
if arlErr, ok := ghErr.(*github.AbuseRateLimitError); ok {
9292
rlt.nextRequestDelay = 0
9393
retryAfter := arlErr.GetRetryAfter()
94-
log.Printf("[DEBUG] Abuse detection mechanism triggered, sleeping for %s before retrying",
94+
log.Printf("[WARN] Abuse detection mechanism triggered, sleeping for %s before retrying",
9595
retryAfter)
9696
time.Sleep(retryAfter)
9797
rlt.smartLock(false)
@@ -101,7 +101,7 @@ func (rlt *RateLimitTransport) RoundTrip(req *http.Request) (*http.Response, err
101101
if rlErr, ok := ghErr.(*github.RateLimitError); ok {
102102
rlt.nextRequestDelay = 0
103103
retryAfter := time.Until(rlErr.Rate.Reset.Time)
104-
log.Printf("[DEBUG] Rate limit %d reached, sleeping for %s (until %s) before retrying",
104+
log.Printf("[WARN] Rate limit %d reached, sleeping for %s (until %s) before retrying",
105105
rlErr.Rate.Limit, retryAfter, time.Now().Add(retryAfter))
106106
time.Sleep(retryAfter)
107107
rlt.smartLock(false)

0 commit comments

Comments
 (0)