Allow borrowed ReconstructionSettings constructor args

Author: zaneduffield

core/src/formatter.rs

@@ -964,8 +964,7 @@ mod tests {
             .parser(DelphiLogicalLineParser {})
             .file_formatter(IndentBasedOnLineNumber {})
             .reconstructor(DelphiLogicalLinesReconstructor::new(
-                ReconstructionSettings::new("\n".to_owned(), " ".to_owned(), " ".to_owned())
-                    .unwrap(),
+                ReconstructionSettings::new("\n", " ", " ").unwrap(),
             ))
             .build();
         run_test(
@@ -1000,8 +999,7 @@ mod tests {
             .file_formatter(IndentBasedOnLineNumber {})
             .file_formatter(IndentSecondLine3SpacesIfNoNewLine {})
             .reconstructor(DelphiLogicalLinesReconstructor::new(
-                ReconstructionSettings::new("\n".to_owned(), " ".to_owned(), " ".to_owned())
-                    .unwrap(),
+                ReconstructionSettings::new("\n", " ", " ").unwrap(),
             ))
             .build();
         run_test(
@@ -1054,8 +1052,7 @@ mod tests {
             .file_formatter(IndentSecondLine3SpacesIfNoNewLine {})
             .line_formatter(RetainSpacesLogcialLinesOnNewLines {})
             .reconstructor(DelphiLogicalLinesReconstructor::new(
-                ReconstructionSettings::new("\n".to_owned(), " ".to_owned(), " ".to_owned())
-                    .unwrap(),
+                ReconstructionSettings::new("\n", " ", " ").unwrap(),
             ))
             .build();
         run_test(

core/src/formatter_selector.rs

@@ -72,8 +72,7 @@ mod tests {
                 },
             })
             .reconstructor(DelphiLogicalLinesReconstructor::new(
-                ReconstructionSettings::new("\n".to_owned(), "\t".to_owned(), "\r".to_owned())
-                    .unwrap(),
+                ReconstructionSettings::new("\n", "\t", "\r").unwrap(),
             ))
             .build();
         run_test(formatter, "a;", "\ta;\r");

core/src/lang.rs

@@ -514,15 +514,15 @@ pub struct ReconstructionSettings {
     continuation_str: String,
 }
 impl ReconstructionSettings {
-    pub fn new(
-        newline_str: String,
-        indentation_str: String,
-        continuation_str: String,
+    pub fn new<S: Into<String> + AsRef<str>>(
+        newline_str: S,
+        indentation_str: S,
+        continuation_str: S,
     ) -> Result<Self, InvalidReconstructionSettingsError> {
         for (name, val) in &[
-            ("newline", &newline_str),
-            ("indentation", &indentation_str),
-            ("continuation", &continuation_str),
+            ("newline", newline_str.as_ref()),
+            ("indentation", indentation_str.as_ref()),
+            ("continuation", continuation_str.as_ref()),
         ] {
             if val.is_empty() {
                 return Err(InvalidReconstructionSettingsError::new(format!(
@@ -536,9 +536,9 @@ impl ReconstructionSettings {
         }
 
         Ok(ReconstructionSettings {
-            newline_str,
-            indentation_str,
-            continuation_str,
+            newline_str: newline_str.into(),
+            indentation_str: indentation_str.into(),
+            continuation_str: continuation_str.into(),
         })
     }
     pub fn get_newline_str(&self) -> &str {