#4 Reveal mystery guests

Author: Willem Wigman

src/view/frontend/layout/cms_page_view_selectable_0_test-file.xml

@@ -16,7 +16,7 @@
 class CategoryFrontendControllerTest extends AbstractFrontendControllerTest
 {
     /** @var int */
-    const CATEGORY_ID = 5;
+    const CATEGORY_ID_FROM_FIXTURE = 5;
 
     /** @var CategoryRepositoryInterface $repository */
     protected $repository;
@@ -82,7 +82,7 @@ protected function givenGlobalCustomUpdateSelected()
      */
     protected function givenDefaultCustomUpdateSelected()
     {
-        $this->setCustomUpdate(self::CATEGORY_ID);
+        $this->setCustomUpdate(self::CATEGORY_ID_FROM_FIXTURE);
     }
 
     /**
@@ -110,7 +110,7 @@ protected function setCustomUpdate(int $forCategoryId, string $fileName = self::
     protected function whenCategoryViewed(?int $categoryId = null)
     {
         if (!$categoryId) {
-            $categoryId = self::CATEGORY_ID;
+            $categoryId = self::CATEGORY_ID_FROM_FIXTURE;
         }
         $this->dispatch("catalog/category/view/id/{$categoryId}");
     }
@@ -122,7 +122,7 @@ protected function thenContainsGlobalUpdateHandle()
 
     protected function thenContainsDefaultUpdateHandle()
     {
-        $this->containsUpdateHandle(self::CATEGORY_ID, self::TEST_FILE);
+        $this->containsUpdateHandle(self::CATEGORY_ID_FROM_FIXTURE, self::TEST_FILE);
     }
 
     /**
@@ -146,7 +146,7 @@ protected function containsUpdateHandle(
      * @return CategoryInterface
      * @throws NoSuchEntityException
      */
-    protected function getCategory(int $categoryId = self::CATEGORY_ID): CategoryInterface
+    protected function getCategory(int $categoryId = self::CATEGORY_ID_FROM_FIXTURE): CategoryInterface
     {
         if (!$this->category) {
             $this->category = $this->repository->get($categoryId);

tests/Integration/CategoryFrontendControllerTest.php

@@ -12,7 +12,7 @@
 class PageFrontendControllerTest extends AbstractFrontendControllerTest
 {
     /** @var string */
-    const PAGE_IDENTIFIER = 'page100';
+    const PAGE_ID_FROM_FIXTURE = 'page100';
 
     /** @var PageLayoutUpdateManager */
     protected $layoutManager;
@@ -98,7 +98,7 @@ protected function thenContainsGlobalUpdateHandle()
 
     protected function thenContainsDefaultUpdateHandle()
     {
-        $this->containsUpdateHandle(self::PAGE_IDENTIFIER);
+        $this->containsUpdateHandle(self::PAGE_ID_FROM_FIXTURE);
     }
 
     /**
@@ -131,7 +131,7 @@ protected function setCustomUpdate(int $forPageId, string $fileName = self::TEST
      * @param string $pageIdentifier
      * @return Page
      */
-    protected function createPage(?string $pageIdentifier = self::PAGE_IDENTIFIER): Page
+    protected function createPage(?string $pageIdentifier = self::PAGE_ID_FROM_FIXTURE): Page
     {
         $page = $this->pageFactory->create(['customLayoutRepository' => $this->repository]);
         $page->setStoreId(self::STORE_ID);

tests/Integration/PageFrontendControllerTest.php

@@ -14,7 +14,7 @@
 class ProductFrontendControllerTest extends AbstractFrontendControllerTest
 {
     /** @var string */
-    const PRODUCT_SKU = 'simple_product_1';
+    const PRODUCT_SKU_FROM_FIXTURE = 'simple_product_1';
 
     /** @var ProductRepositoryInterface $repository */
     protected $repository;
@@ -110,7 +110,7 @@ protected function thenContainsGlobalUpdateHandle()
 
     protected function thenContainsDefaultUpdateHandle()
     {
-        $this->containsUpdateHandle(self::PRODUCT_SKU);
+        $this->containsUpdateHandle(self::PRODUCT_SKU_FROM_FIXTURE);
     }
 
     /**
@@ -152,7 +152,7 @@ protected function setCustomUpdate(int $forProductId, string $fileName = self::T
      * @return ProductInterface
      * @throws NoSuchEntityException
      */
-    protected function getProduct(string $sku = self::PRODUCT_SKU): ProductInterface
+    protected function getProduct(string $sku = self::PRODUCT_SKU_FROM_FIXTURE): ProductInterface
     {
         if (!$this->product) {
             $this->product = $this->repository->get($sku);