refactor: moved agent config types to collector #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
refactor-agent-config-types
branch
from
cfb4855 to
826553d
Compare
kirrg001
commented
Sep 18, 2025
| @@ -1,4 +1,21 @@ | |||
| import { GenericLogger } from '@instana/core/src/core'; | |||
| import { IgnoreEndpoints, Disable } from '@instana/core/src/config/types'; | |||
Contributor
Author
There was a problem hiding this comment.
Moving AgentConfig into a ts declaration file requires to move its dependencies to other types too. But its so much better to use the types files anyway.
kirrg001
commented
Sep 18, 2025
| @@ -0,0 +1,16 @@ | |||
| export interface IgnoreEndpoints { | |||
Contributor
Author
There was a problem hiding this comment.
This is our new config types file. A good beginning for a better config module
kirrg001
force-pushed
the
refactor-agent-config-types
branch
from
b0c5833 to
c9c3571
Compare
aryamohanan
approved these changes
Sep 18, 2025
kirrg001
force-pushed
the
refactor-agent-config-types
branch
from
c9c3571 to
5a346aa
Compare
kirrg001
force-pushed
the
refactor-agent-config-types
branch
from
5a346aa to
b4ee572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectorConfig should include AgentConfig.
AgentOpts will be removed and moved into CollectorConfig.
This PR just moves the Types to Collector.
From #2010