Skip to content

Commit c9c3571

Browse files
committed
chore: fixed tests
1 parent f9799c9 commit c9c3571

File tree

8 files changed

+31
-35
lines changed

8 files changed

+31
-35
lines changed

packages/collector/src/announceCycle/unannounced.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ const maxRetryDelay = 60 * 1000; // one minute
4343
* @typedef {Object} TracingConfig
4444
* @property {Array.<string>} [extra-http-headers]
4545
* @property {KafkaTracingConfig} [kafka]
46-
* @property {import('@instana/core/src/tracing').IgnoreEndpoints} [ignore-endpoints]
46+
* @property {import('@instana/core/src/config/types').IgnoreEndpoints} [ignore-endpoints]
4747
* @property {boolean} [span-batching-enabled]
48-
* @property {import('@instana/core/src/tracing').Disable} [disable]
48+
* @property {import('@instana/core/src/config/types').Disable} [disable]
4949
*/
5050

5151
/**

packages/collector/src/types/collector.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { GenericLogger } from '@instana/core/src/core';
2+
import { IgnoreEndpoints, Disable } from '@instana/core/src/config/types';
23

34
export interface AgentConfig {
45
tracing?: {
@@ -9,8 +10,8 @@ export interface AgentConfig {
910
traceCorrelation?: boolean;
1011
};
1112
spanBatchingEnabled?: boolean | string;
12-
ignoreEndpoints?: import('@instana/core/src/tracing').IgnoreEndpoints;
13-
disable?: import('@instana/core/src/tracing').Disable;
13+
ignoreEndpoints?: IgnoreEndpoints;
14+
disable?: Disable;
1415
[key: string]: any;
1516
};
1617
[key: string]: any;

packages/core/src/config/configNormalizers/disable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ exports.normalizeExternalConfig = function normalizeExternalConfig(config) {
104104
* 3. INSTANA_TRACING_DISABLE=list
105105
* 4. INSTANA_DISABLED_TRACERS (deprecated)
106106
*
107-
* @returns {import('../../tracing').Disable}
107+
* @returns {import('../../config/types').Disable}
108108
*/
109109
function getDisableFromEnv() {
110110
const disable = {};

packages/core/src/config/configNormalizers/ignoreEndpoints.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ exports.init = function init(config) {
2525
* Normalized internal structure:
2626
* - { [serviceName: string]: [{ methods: string[], endpoints: string[] }] }
2727
*
28-
* @param {import('../../tracing').IgnoreEndpoints} ignoreEndpointConfig
29-
* @returns {import('../../tracing').IgnoreEndpoints}
28+
* @param {import('../../config/types').IgnoreEndpoints} ignoreEndpointConfig
29+
* @returns {import('../../config/types').IgnoreEndpoints}
3030
*/
3131

3232
exports.normalizeConfig = function normalizeConfig(ignoreEndpointConfig) {

packages/core/src/config/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ const deepMerge = require('../util/deepMerge');
2323
* @property {number} [transmissionDelay]
2424
* @property {number} [stackTraceLength]
2525
* @property {HTTPTracingOptions} [http]
26-
* @property {import('../tracing').Disable} [disable]
26+
* @property {import('../config/types').Disable} [disable]
2727
* @property {Array<string>} [disabledTracers]
2828
* @property {boolean} [spanBatchingEnabled]
2929
* @property {boolean} [disableW3cTraceCorrelation]
3030
* @property {KafkaTracingOptions} [kafka]
3131
* @property {boolean} [allowRootExitSpan]
32-
* @property {import('../tracing').IgnoreEndpoints} [ignoreEndpoints]
32+
* @property {import('../config/types').IgnoreEndpoints} [ignoreEndpoints]
3333
* @property {boolean} [ignoreEndpointsDisableSuppression]
3434
* @property {boolean} [disableEOLEvents]
3535
*/
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
export interface IgnoreEndpoints {
2+
[key: string]: IgnoreEndpointsFields[];
3+
}
4+
5+
export interface IgnoreEndpointsFields {
6+
methods?: string[];
7+
endpoints?: string[];
8+
connections?: string[];
9+
}
10+
11+
export interface TracingDisableOptions {
12+
instrumentations?: string[];
13+
groups?: string[];
14+
}
15+
16+
export type Disable = TracingDisableOptions | boolean;

packages/core/src/tracing/index.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -118,27 +118,6 @@ if (customInstrumentations.length > 0) {
118118
* @property {boolean} [traceCorrelation]
119119
*/
120120

121-
/**
122-
* @typedef {Object.<string,IgnoreEndpointsFields[]>} IgnoreEndpoints
123-
*/
124-
125-
/**
126-
* @typedef {Object} IgnoreEndpointsFields
127-
* @property {string[]} [methods]
128-
* @property {string[]} [endpoints]
129-
* @property {string[]} [connections]
130-
*/
131-
132-
/**
133-
* @typedef {TracingDisableOptions|boolean} Disable
134-
*/
135-
136-
/**
137-
* @typedef {Object} TracingDisableOptions
138-
* @property {string[]} [instrumentations]
139-
* @property {string[]} [groups]
140-
*/
141-
142121
/** @type {Array.<InstanaInstrumentedModule>} */
143122
let additionalInstrumentationModules = [];
144123
/** @type {Object.<string, InstanaInstrumentedModule>} */

packages/core/src/util/spanFilter.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
'use strict';
66

77
/**
8-
* @type {import('../tracing').IgnoreEndpoints}
8+
* @type {import('../config/types').IgnoreEndpoints}
99
*/
1010
let ignoreEndpoints;
1111

@@ -48,7 +48,7 @@ const IGNORABLE_SPAN_TYPES = ['redis', 'dynamodb', 'kafka', 'node.http.server'];
4848
/**
4949
* @param {import('../core').InstanaBaseSpan} span
5050
* @param {string} spanTypeKey
51-
* @param {import('../tracing').IgnoreEndpointsFields} ignoreconfig
51+
* @param {import('../config/types').IgnoreEndpointsFields} ignoreconfig
5252
* @returns {boolean}
5353
*/
5454
function matchEndpoints(span, spanTypeKey, ignoreconfig) {
@@ -87,7 +87,7 @@ function matchEndpoints(span, spanTypeKey, ignoreconfig) {
8787
/**
8888
* @param {import("../core").InstanaBaseSpan} span
8989
* @param {string} spanTypeKey
90-
* @param {import('../tracing').IgnoreEndpointsFields} ignoreconfig
90+
* @param {import('../config/types').IgnoreEndpointsFields} ignoreconfig
9191
* @returns {boolean}
9292
*/
9393
function matchMethods(span, spanTypeKey, ignoreconfig) {
@@ -107,7 +107,7 @@ function matchMethods(span, spanTypeKey, ignoreconfig) {
107107
/**
108108
* @param {import("../core").InstanaBaseSpan} span
109109
* @param {string} spanTypeKey
110-
* @param {import('../tracing').IgnoreEndpointsFields} ignoreconfig
110+
* @param {import('../config/types').IgnoreEndpointsFields} ignoreconfig
111111
* @returns {boolean}
112112
*/
113113
function matchConnections(span, spanTypeKey, ignoreconfig) {
@@ -127,7 +127,7 @@ function matchConnections(span, spanTypeKey, ignoreconfig) {
127127

128128
/**
129129
* @param {import("../core").InstanaBaseSpan} span
130-
* @param {import('../tracing').IgnoreEndpoints} ignoreEndpointsConfig
130+
* @param {import('../config/types').IgnoreEndpoints} ignoreEndpointsConfig
131131
* @returns {boolean}
132132
*/
133133
function shouldIgnore(span, ignoreEndpointsConfig) {

0 commit comments

Comments
 (0)