phpstan config (up to level 4) + cleanup

Author: robocoder

lib/WebDriver/AbstractWebDriver.php

@@ -90,11 +90,11 @@ public function getURL()
     /**
      * Curl request to webdriver server.
      *
-     * @param string $requestMethod HTTP request method, e.g., 'GET', 'POST', or 'DELETE'
-     * @param string $command       If not defined in methods() this function will throw.
-     * @param array  $parameters    If an array(), they will be posted as JSON parameters
-     *                              If a number or string, "/$params" is appended to url
-     * @param array  $extraOptions  key=>value pairs of curl options to pass to curl_setopt()
+     * @param string               $requestMethod HTTP request method, e.g., 'GET', 'POST', or 'DELETE'
+     * @param string               $command       If not defined in methods() this function will throw.
+     * @param array|integer|string $parameters    If an array(), they will be posted as JSON parameters
+     *                                            If a number or string, "/$params" is appended to url
+     * @param array                $extraOptions  key=>value pairs of curl options to pass to curl_setopt()
      *
      * @return array array('value' => ..., 'info' => ...)
      *

lib/WebDriver/Container.php

@@ -224,6 +224,8 @@ protected function webDriverElement($value)
                 $value[self::WEBDRIVER_ELEMENT_ID] // id
             );
         }
+
+        return null;
     }
 
     /**

lib/WebDriver/Exception/CurlExec.php

@@ -38,22 +38,22 @@ final class CurlExec extends BaseException
     private $curlInfo = array();
 
     /**
-     * {@inheritdoc}
+     * Get curl info
+     *
+     * @return array
      */
-    public function __construct($message = null, $code = 0, \Exception $previous = null, $curlInfo = array())
+    public function getCurlInfo()
     {
-        parent::__construct($message, $code, $previous);
-
-        $this->curlInfo = $curlInfo;
+        return $this->curlInfo;
     }
 
     /**
-     * Get curl info
+     * Set curl info
      *
-     * @return array
+     * @param array $curlInfo
      */
-    public function getCurlInfo()
+    public function setCurlInfo($curlInfo)
     {
-        return $this->curlInfo;
+        $this->curlInfo = $curlInfo;
     }
 }

lib/WebDriver/SauceLabs/SauceRest.php

@@ -292,7 +292,7 @@ public function getStatus()
      *
      * @return array
      */
-    public function getBrowsers($termination = false)
+    public function getBrowsers($termination = '')
     {
         if ($termination) {
             return $this->execute('GET', 'info/browsers/' . $termination);

lib/WebDriver/ServiceFactory.php

@@ -66,7 +66,7 @@ private function __construct()
      */
     public static function getInstance()
     {
-        if (!self::$instance) {
+        if (self::$instance === null) {
             self::$instance = new self;
         }
 

lib/WebDriver/Timeouts.php

@@ -47,7 +47,7 @@ protected function methods()
     /**
      * helper method to wait until user-defined condition is met
      *
-     * @param function $callback      callback which returns non-false result if wait condition was met
+     * @param callable $callback      callback which returns non-false result if wait condition was met
      * @param integer  $maxIterations maximum number of iterations
      * @param integer  $sleep         sleep duration in seconds between iterations
      * @param array    $args          optional args; if the callback needs $this, then pass it here

lib/WebDriver/WebDriver.php

@@ -27,7 +27,7 @@
  *
  * @package WebDriver
  *
- * @method status
+ * @method array status() Returns information about whether a remote end is in a state in which it can create new sessions.
  */
 class WebDriver extends AbstractWebDriver implements WebDriverInterface
 {

phpstan.neon.dist

@@ -0,0 +1,4 @@
+parameters:
+    level: 4
+    paths:
+        - lib