create LegacyElement (similar to LegacyWindow)

Author: robocoder

lib/WebDriver/Container.php

@@ -33,9 +33,6 @@
  */
 abstract class Container extends AbstractWebDriver
 {
-    const LEGACY_ELEMENT_ID = 'ELEMENT';
-    const WEB_ELEMENT_ID    = 'element-6066-11e4-a52e-4f735466cecf';
-
     /**
      * @var array
      */
@@ -212,22 +209,18 @@ public function locate($using, $value)
      */
     protected function webDriverElement($value)
     {
-        if (array_key_exists(self::LEGACY_ELEMENT_ID, (array) $value)) {
-            assert($this->legacy === false);
-
-            return new Element(
-                $this->getElementPath($value[self::LEGACY_ELEMENT_ID]), // url
-                $value[self::LEGACY_ELEMENT_ID], // id
+        if (array_key_exists(LegacyElement::LEGACY_ELEMENT_ID, (array) $value)) {
+            return new LegacyElement(
+                $this->getElementPath($value[LegacyElement::LEGACY_ELEMENT_ID]), // url
+                $value[LegacyElement::LEGACY_ELEMENT_ID], // id
                 $this->legacy
             );
         }
 
-        if (array_key_exists(self::WEB_ELEMENT_ID, (array) $value)) {
-            assert($this->legacy === true);
-
+        if (array_key_exists(Element::WEB_ELEMENT_ID, (array) $value)) {
             return new Element(
-                $this->getElementPath($value[self::WEB_ELEMENT_ID]), // url
-                $value[self::WEB_ELEMENT_ID], // id
+                $this->getElementPath($value[Element::WEB_ELEMENT_ID]), // url
+                $value[Element::WEB_ELEMENT_ID], // id
                 $this->legacy
             );
         }

lib/WebDriver/Element.php

@@ -47,8 +47,10 @@
  * @method string text() Returns the visible text for the element.
  * @method void postValue($json) Send a sequence of key strokes to an element.
  */
-final class Element extends Container
+class Element extends Container
 {
+    const WEB_ELEMENT_ID = 'element-6066-11e4-a52e-4f735466cecf';
+
     /**
      * {@inheritdoc}
      */

lib/WebDriver/Execute.php

@@ -82,8 +82,12 @@ private function serializeArguments(array $arguments)
     {
         foreach ($arguments as $key => $value) {
             switch (true) {
+                case $value instanceof LegacyElement:
+                    $arguments[$key] = [LegacyElement::LEGACY_ELEMENT_ID => $value->getID()];
+                    break;
+
                 case $value instanceof Element:
-                    $arguments[$key] = [$this->isLegacy() ? Container::LEGACY_ELEMENT_ID : Container::WEB_ELEMENT_ID => $value->getID()];
+                    $arguments[$key] = [Element::WEB_ELEMENT_ID => $value->getID()];
                     break;
 
                 case $value instanceof Shadow:
@@ -134,18 +138,18 @@ protected function webDriverElement($value)
     {
         $basePath = preg_replace('~/execute$~', '', $this->url);
 
-        if (array_key_exists(Container::LEGACY_ELEMENT_ID, $value)) {
-            return new Element(
-                $basePath . '/element/' . $value[Container::LEGACY_ELEMENT_ID], // url
-                $value[Container::LEGACY_ELEMENT_ID], // id
+        if (array_key_exists(LegacyElement::LEGACY_ELEMENT_ID, $value)) {
+            return new LegacyElement(
+                $basePath . '/element/' . $value[LegacyElement::LEGACY_ELEMENT_ID], // url
+                $value[LegacyElement::LEGACY_ELEMENT_ID], // id
                 $this->legacy
             );
         }
 
-        if (array_key_exists(Container::WEB_ELEMENT_ID, $value)) {
+        if (array_key_exists(Element::WEB_ELEMENT_ID, $value)) {
             return new Element(
-                $basePath . '/element/' . $value[Container::WEB_ELEMENT_ID], // url
-                $value[Container::WEB_ELEMENT_ID], // id
+                $basePath . '/element/' . $value[Element::WEB_ELEMENT_ID], // url
+                $value[Element::WEB_ELEMENT_ID], // id
                 $this->legacy
             );
         }

lib/WebDriver/LegacyElement.php

@@ -0,0 +1,51 @@
+<?php
+
+/**
+ * Copyright 2022-2022 Anthon Pang. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * @package WebDriver
+ *
+ * @author Anthon Pang <apang@softwaredevelopment.ca>
+ */
+
+namespace WebDriver;
+
+/**
+ * WebDriver\LegacyElement class
+ *
+ * @package WebDriver
+ *
+ * @method string attribute($attributeName) Get the value of an element's attribute.
+ * @method void clear() Clear a TEXTAREA or text INPUT element's value.
+ * @method void click() Click on an element.
+ * @method string css($propertyName) Query the value of an element's computed CSS property.
+ * @method boolean displayed() Determine if an element is currently displayed.
+ * @method boolean enabled() Determine if an element is currently enabled.
+ * @method boolean equals($otherId) Test if two element IDs refer to the same DOM element.
+ * @method array location() Determine an element's location on the page.
+ * @method array location_in_view() Determine an element's location on the screen once it has been scrolled into view.
+ * @method string name() Query for an element's tag name.
+ * @method array property($propertyName) Get Element Property
+ * @method array rect() Get Element Rect
+ * @method array screenshot() Take Element Screenshot
+ * @method array size() Determine an element's size in pixels.
+ * @method void submit() Submit a FORM element.
+ * @method string text() Returns the visible text for the element.
+ * @method void postValue($json) Send a sequence of key strokes to an element.
+ */
+class LegacyElement extends Element
+{
+    const LEGACY_ELEMENT_ID = 'ELEMENT';
+}