Fix: make sure http errors from the requested resource are caught and exceptions thrown

gggeek · gggeek · commit 3b11d17e0ff0 · 2014-12-04T15:47:09.000Z
diff --git a/lib/WebDriver/Service/CurlService.php b/lib/WebDriver/Service/CurlService.php
@@ -81,6 +81,7 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions
         }
 
         curl_setopt($curl, CURLOPT_HTTPHEADER, $customHeaders);
+        curl_setopt($curl, CURLOPT_FAILONERROR, true);
 
         $rawResult = trim(curl_exec($curl));
         $info = curl_getinfo($curl);

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ public function execute($requestMethod, $url, $parameters = null, $extraOptions`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`curl_setopt($curl, CURLOPT_HTTPHEADER, $customHeaders);`
	`84`	`+ curl_setopt($curl, CURLOPT_FAILONERROR, true);`
`84`	`85`
`85`	`86`	`$rawResult = trim(curl_exec($curl));`
`86`	`87`	`$info = curl_getinfo($curl);`