[Tests] add linting

Author: ljharb

.eslintignore

@@ -0,0 +1,4 @@
+# eslintignore
+
+# TODO: fix
+index.js

.eslintrc

@@ -0,0 +1,44 @@
+{
+    "root": true,
+    "extends": "@ljharb",
+    "rules": {
+        "indent": [2, 4],
+        "strict": 1,
+        "no-octal-escape": 1,
+    },
+    "globals": {
+        "BigInt": false,
+    },
+    "overrides": [
+        {
+            "files": ["test/**", "test-*", "example/**"],
+            "rules": {
+              "array-bracket-newline": 0,
+              "max-params": 0,
+              "max-statements": 0,
+              "max-statements-per-line": 0,
+              "no-magic-numbers": 0,
+              "object-curly-newline": 0,
+              "sort-keys": 0,
+            },
+        },
+        {
+            "files": ["example/**"],
+            "rules": {
+                "no-console": 0,
+            },
+        },
+        {
+            "files": ["test/browser/**"],
+            "env": {
+                "browser": true,
+            },
+        },
+        {
+            "files": ["test/bigint*"],
+            "rules": {
+                "new-cap": [2, { "capIsNewExceptions": ["BigInt"] }],
+            },
+        },
+    ],
+}

.travis.yml

@@ -35,6 +35,8 @@ matrix:
   include:
     - node_js: "10.0"
       env: BIGINT=true
+    - node_js: "lts/*"
+      env: PRETEST=true
     - node_js: "node"
       env: COVERAGE=true
     - node_js: "9.10"

example/all.js

@@ -1,19 +1,23 @@
+'use strict';
+
 var inspect = require('../');
 var Buffer = require('safer-buffer').Buffer;
 
-var holes = [ 'a', 'b' ];
-holes[4] = 'e', holes[6] = 'g';
+var holes = ['a', 'b'];
+holes[4] = 'e';
+holes[6] = 'g';
+
 var obj = {
     a: 1,
-    b: [ 3, 4, undefined, null ],
+    b: [3, 4, undefined, null],
     c: undefined,
     d: null,
     e: {
         regex: /^x/i,
         buf: Buffer.from('abc'),
         holes: holes
     },
-    now: new Date
+    now: new Date()
 };
 obj.self = obj;
 console.log(inspect(obj));

example/circular.js

@@ -1,4 +1,6 @@
+'use strict';
+
 var inspect = require('../');
-var obj = { a: 1, b: [3,4] };
+var obj = { a: 1, b: [3, 4] };
 obj.c = obj;
 console.log(inspect(obj));

example/fn.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var inspect = require('../');
-var obj = [ 1, 2, function f (n) { return n + 5 }, 4 ];
+var obj = [1, 2, function f(n) { return n + 5; }, 4];
 console.log(inspect(obj));

example/inspect.js

@@ -1,7 +1,10 @@
+'use strict';
+
+/* eslint-env browser */
 var inspect = require('../');
 
 var d = document.createElement('div');
 d.setAttribute('id', 'beep');
 d.innerHTML = '<b>wooo</b><i>iiiii</i>';
 
-console.log(inspect([ d, { a: 3, b : 4, c: [5,6,[7,[8,[9]]]] } ]));
+console.log(inspect([d, { a: 3, b: 4, c: [5, 6, [7, [8, [9]]]] }]));

package.json

@@ -4,11 +4,15 @@
   "description": "string representations of objects in node and the browser",
   "main": "index.js",
   "devDependencies": {
+    "@ljharb/eslint-config": "^13.1.1",
     "core-js": "^2.5.5",
+    "eslint": "^5.16.0",
     "nyc": "^10.3.2",
     "tape": "^4.9.0"
   },
   "scripts": {
+    "pretest": "npm run lint",
+    "lint": "eslint .",
     "test": "npm run tests-only",
     "posttest": "npm run test:bigint",
     "pretests-only": "node test-core-js",

test/bigint.js

@@ -2,29 +2,30 @@ var inspect = require('../');
 var test = require('tape');
 
 test('bigint', { skip: typeof BigInt === 'undefined' }, function (t) {
-  t.test('primitives', function (st) {
-    st.plan(3);
+    t.test('primitives', function (st) {
+        st.plan(3);
 
-    st.equal(inspect(BigInt(-256)), '-256n');
-    st.equal(inspect(BigInt(0)), '0n');
-    st.equal(inspect(BigInt(256)), '256n');
-  });
+        st.equal(inspect(BigInt(-256)), '-256n');
+        st.equal(inspect(BigInt(0)), '0n');
+        st.equal(inspect(BigInt(256)), '256n');
+    });
 
-  t.test('objects', function (st) {
-    st.plan(3);
+    t.test('objects', function (st) {
+        st.plan(3);
 
-    st.equal(inspect(Object(BigInt(-256))), 'Object(-256n)');
-    st.equal(inspect(Object(BigInt(0))), 'Object(0n)');
-    st.equal(inspect(Object(BigInt(256))), 'Object(256n)');
-  });
+        st.equal(inspect(Object(BigInt(-256))), 'Object(-256n)');
+        st.equal(inspect(Object(BigInt(0))), 'Object(0n)');
+        st.equal(inspect(Object(BigInt(256))), 'Object(256n)');
+    });
 
-  t.test('syntactic primitives', function (st) {
-    st.plan(3);
+    t.test('syntactic primitives', function (st) {
+        st.plan(3);
 
-    st.equal(inspect(Function('return -256n')()), '-256n');
-    st.equal(inspect(Function('return 0n')()), '0n');
-    st.equal(inspect(Function('return 256n')()), '256n');
-  });
+        /* eslint-disable no-new-func */
+        st.equal(inspect(Function('return -256n')()), '-256n');
+        st.equal(inspect(Function('return 0n')()), '0n');
+        st.equal(inspect(Function('return 256n')()), '256n');
+    });
 
-  t.end();
+    t.end();
 });

test/browser/dom.js

@@ -3,13 +3,13 @@ var test = require('tape');
 
 test('dom element', function (t) {
     t.plan(1);
-    
+
     var d = document.createElement('div');
     d.setAttribute('id', 'beep');
     d.innerHTML = '<b>wooo</b><i>iiiii</i>';
-    
+
     t.equal(
-        inspect([ d, { a: 3, b : 4, c: [5,6,[7,[8,[9]]]] } ]),
+        inspect([d, { a: 3, b: 4, c: [5, 6, [7, [8, [9]]]] }]),
         '[ <div id="beep">...</div>, { a: 3, b: 4, c: [ 5, 6, [ 7, [ 8, [Object] ] ] ] } ]'
     );
 });