Skip to content

Commit ed476ae

Browse files
committed
fix: breaking change in 'warp' crate '0.4' from '0.3'
1 parent 9fad922 commit ed476ae

File tree

5 files changed

+55
-13
lines changed

5 files changed

+55
-13
lines changed

Cargo.lock

Lines changed: 39 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,4 @@ strum = { version = "0.27.2", features = ["derive"] }
7171
thiserror = "2.0.16"
7272
tokio = { version = "1.47.1", features = ["rt", "sync", "time"] }
7373
tracing = "0.1.41"
74-
warp = "0.4.2"
74+
warp = { version = "0.4.2", features = ["server", "websocket"] }

internal/tests/mithril-test-http-server/src/test_http_server.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,11 @@ where
5858
.build()
5959
.expect("new rt");
6060
let (shutdown_tx, shutdown_rx) = oneshot::channel();
61-
let (address, server) = rt.block_on(async move {
62-
warp::serve(filters).bind_with_graceful_shutdown(socket_addr, async {
63-
shutdown_rx.await.ok();
64-
})
61+
let listener =
62+
rt.block_on(async move { tokio::net::TcpListener::bind(socket_addr).await.unwrap() });
63+
let address = listener.local_addr().unwrap();
64+
let server = warp::serve(filters).incoming(listener).graceful(async {
65+
shutdown_rx.await.ok();
6566
});
6667

6768
let (panic_tx, _) = std_mpsc::channel();
@@ -72,7 +73,7 @@ where
7273
thread::Builder::new()
7374
.name(thread_name)
7475
.spawn(move || {
75-
rt.block_on(server);
76+
rt.block_on(server.run());
7677
let _ = panic_tx.send(());
7778
})
7879
.expect("thread spawn");

mithril-aggregator/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ mockall = { workspace = true }
8888
slog-scope = "4.4.0"
8989
slog-term = { workspace = true }
9090
tempfile = "3.21.0"
91+
warp = { workspace = true, features = ["test"] }
9192

9293
[[bench]]
9394
name = "cardano_transactions_import"

mithril-aggregator/src/commands/serve_command.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,16 +182,17 @@ impl ServeCommand {
182182
.with_context(|| "Dependencies Builder can not create http routes")?;
183183
let mut stop_rx_clone = stop_rx.clone();
184184
join_set.spawn(async move {
185-
let (_, server) = warp::serve(routes).bind_with_graceful_shutdown(
186-
(
185+
warp::serve(routes)
186+
.bind((
187187
config.server_ip.clone().parse::<IpAddr>().unwrap(),
188188
config.server_port,
189-
),
190-
async move {
189+
))
190+
.await
191+
.graceful(async move {
191192
stop_rx_clone.changed().await.ok();
192-
},
193-
);
194-
server.await;
193+
})
194+
.run()
195+
.await;
195196

196197
Ok(())
197198
});

0 commit comments

Comments
 (0)