chore: apply review comments

Author: jpraynaud

mithril-client/src/aggregator_client.rs

@@ -827,14 +827,12 @@ mod tests {
             when.matches(|req| {
                 let headers = req.headers();
                 let accept_encoding_header = headers
-                    .iter()
-                    .find(|(name, _values)| name.to_string().to_lowercase() == "accept-encoding")
+                    .get("accept-encoding")
                     .expect("Accept-Encoding header not found");
 
-                let header_value = accept_encoding_header.1;
-                ["gzip", "br", "deflate", "zstd"]
-                    .iter()
-                    .all(|&value| header_value.to_str().unwrap().contains(value))
+                ["gzip", "br", "deflate", "zstd"].iter().all(|&encoding| {
+                    accept_encoding_header.to_str().is_ok_and(|h| h.contains(encoding))
+                })
             });
 
             then.status(200).body("ok");
@@ -855,14 +853,12 @@ mod tests {
             when.matches(|req| {
                 let headers = req.headers();
                 let accept_encoding_header = headers
-                    .iter()
-                    .find(|(name, _values)| name.to_string().to_lowercase() == "accept-encoding")
+                    .get("accept-encoding")
                     .expect("Accept-Encoding header not found");
 
-                let header_value = accept_encoding_header.1;
-                ["gzip", "br", "deflate", "zstd"]
-                    .iter()
-                    .all(|&value| header_value.to_str().unwrap().contains(value))
+                ["gzip", "br", "deflate", "zstd"].iter().all(|&encoding| {
+                    accept_encoding_header.to_str().is_ok_and(|h| h.contains(encoding))
+                })
             });
 
             then.status(200).body("ok");

mithril-common/src/crypto_helper/codec/binary.rs

@@ -21,7 +21,7 @@ pub trait TryFromBytes: Sized {
     /// Try to convert from hex string encoded bytes.
     fn try_from_bytes_hex(hex_string: &str) -> StdResult<Self> {
         let bytes = Vec::from_hex(hex_string)
-            .map_err(|e| anyhow::anyhow!("Could not deserialize binary from hex string: {}", e))?;
+            .map_err(|e| anyhow::anyhow!("Could not deserialize binary from hex string: {e}"))?;
 
         Self::try_from_bytes(&bytes)
     }

mithril-relay/src/relay/aggregator.rs

@@ -253,14 +253,12 @@ mod tests {
             when.is_true(|req| {
                 let headers = req.headers();
                 let accept_encoding_header = headers
-                    .iter()
-                    .find(|(name, _values)| name.to_string().to_lowercase() == "accept-encoding")
+                    .get("accept-encoding")
                     .expect("Accept-Encoding header not found");
 
-                let header_value = accept_encoding_header.1;
-                ["gzip", "br", "deflate", "zstd"]
-                    .iter()
-                    .all(|&value| header_value.to_str().unwrap().contains(value))
+                ["gzip", "br", "deflate", "zstd"].iter().all(|&encoding| {
+                    accept_encoding_header.to_str().is_ok_and(|h| h.contains(encoding))
+                })
             });
 
             then.status(201).body("ok");

mithril-relay/src/relay/signer.rs

@@ -555,14 +555,12 @@ mod tests {
             when.is_true(|req| {
                 let headers = req.headers();
                 let accept_encoding_header = headers
-                    .iter()
-                    .find(|(name, _values)| name.to_string().to_lowercase() == "accept-encoding")
+                    .get("accept-encoding")
                     .expect("Accept-Encoding header not found");
 
-                let header_value = accept_encoding_header.1;
-                ["gzip", "br", "deflate", "zstd"]
-                    .iter()
-                    .all(|&value| header_value.to_str().unwrap().contains(value))
+                ["gzip", "br", "deflate", "zstd"].iter().all(|&encoding| {
+                    accept_encoding_header.to_str().is_ok_and(|h| h.contains(encoding))
+                })
             });
 
             then.status(200).body("ok");

mithril-signer/src/services/aggregator_client.rs

@@ -1025,14 +1025,12 @@ mod tests {
             when.is_true(|req| {
                 let headers = req.headers();
                 let accept_encoding_header = headers
-                    .iter()
-                    .find(|(name, _values)| name.to_string().to_lowercase() == "accept-encoding")
+                    .get("accept-encoding")
                     .expect("Accept-Encoding header not found");
 
-                let header_value = accept_encoding_header.1;
-                ["gzip", "br", "deflate", "zstd"]
-                    .iter()
-                    .all(|&value| header_value.to_str().unwrap().contains(value))
+                ["gzip", "br", "deflate", "zstd"].iter().all(|&encoding| {
+                    accept_encoding_header.to_str().is_ok_and(|h| h.contains(encoding))
+                })
             });
 
             then.status(201);