change log and crates version

revert mithril common stm version

common - stm version

Apply suggestions from code review

Co-authored-by: Jean-Philippe Raynaud <jp.raynaud@gmail.com>
Co-authored-by: DJO <790521+Alenar@users.noreply.github.com>

code review suggestions

Author: curiecrypt

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithrildemo"
-version = "0.1.50"
+version = "0.1.51"
 authors = { workspace = true }
 edition = { workspace = true }
 documentation = { workspace = true }

demo/protocol-demo/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.5.29"
+version = "0.5.30"
 description = "Common types, interfaces, and utilities for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }
@@ -47,7 +47,9 @@ kes-summed-ed25519 = { version = "0.2.1", features = [
     "serde_enabled",
     "sk_clone_enabled",
 ] }
-mithril-stm = { path = "../mithril-stm", version = "0.3", default-features = false, features = ["batch-verify-aggregates"] }
+mithril-stm = { path = "../mithril-stm", version = ">=0.3", default-features = false, features = [
+    "batch-verify-aggregates"
+] }
 nom = "8.0.0"
 pallas-addresses = { version = "0.32.0", optional = true }
 pallas-codec = { version = "0.32.0", optional = true }

mithril-common/Cargo.toml

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.4.0 (15-05-2025)
+
+### Added
+
+- Added a `participant` module and `StmInitializer` and `StmSigner` functionality covered by its submodules.
+
+### Changed
+
+- STM module visibilities are changed.
+
 ## 0.3.44 (28-04-2025)
 
 - Removed the build script and deprecated `batch-verify-aggregate` feature as the code behind this feature is now

mithril-stm/CHANGELOG.md

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-stm"
-version = "0.3.46"
+version = "0.4.0"
 edition = { workspace = true }
 authors = { workspace = true }
 homepage = { workspace = true }

mithril-stm/Cargo.toml

@@ -2,27 +2,25 @@
 //! Implementation of Stake-based Threshold Multisignatures
 
 mod bls_multi_signature;
-
 mod eligibility_check;
 mod error;
 mod key_reg;
 mod merkle_tree;
 mod participant;
 mod stm;
 
-pub use crate::error::{
+pub use error::{
     AggregationError, CoreVerifierError, RegisterError, StmAggregateSignatureError,
     StmSignatureError,
 };
+pub use key_reg::{ClosedKeyReg, KeyReg};
 pub use participant::{StmInitializer, StmSigner, StmVerificationKey, StmVerificationKeyPoP};
 pub use stm::{
     CoreVerifier, Index, Stake, StmAggrSig, StmAggrVerificationKey, StmClerk, StmParameters,
     StmSig, StmSigRegParty,
 };
 
 #[cfg(feature = "benchmark-internals")]
-pub use crate::bls_multi_signature::{
+pub use bls_multi_signature::{
     ProofOfPossession, Signature, SigningKey, VerificationKey, VerificationKeyPoP,
 };
-
-pub use key_reg::{ClosedKeyReg, KeyReg};

mithril-stm/src/lib.rs

@@ -1,12 +1,13 @@
+use blake2::digest::Digest;
+use digest::FixedOutput;
+use rand_core::{CryptoRng, RngCore};
+use serde::{Deserialize, Serialize};
+
 use crate::bls_multi_signature::{SigningKey, VerificationKeyPoP};
 use crate::key_reg::{ClosedKeyReg, RegParty};
 use crate::participant::StmSigner;
 use crate::stm::{Stake, StmParameters};
 use crate::RegisterError;
-use blake2::digest::Digest;
-use digest::FixedOutput;
-use rand_core::{CryptoRng, RngCore};
-use serde::{Deserialize, Serialize};
 
 /// Wrapper of the MultiSignature Verification key with proof of possession
 pub type StmVerificationKeyPoP = VerificationKeyPoP;

mithril-stm/src/participant/initializer.rs

@@ -3,5 +3,5 @@
 mod initializer;
 mod signer;
 
-pub use crate::participant::initializer::{StmInitializer, StmVerificationKeyPoP};
-pub use crate::participant::signer::{StmSigner, StmVerificationKey};
+pub use initializer::{StmInitializer, StmVerificationKeyPoP};
+pub use signer::{StmSigner, StmVerificationKey};

mithril-stm/src/participant/mod.rs

@@ -135,8 +135,8 @@ impl<D: Clone + Digest + FixedOutput> StmSigner<D> {
     }
 
     /// Get closed key registration
-    pub fn get_closed_reg(&self) -> ClosedKeyReg<D> {
-        self.closed_reg.clone().unwrap()
+    pub fn get_closed_reg(&self) -> Option<ClosedKeyReg<D>> {
+        self.closed_reg.clone()
     }
 
     /// Get verification key

mithril-stm/src/participant/signer.rs

@@ -425,7 +425,7 @@ impl<D: Digest + Clone + FixedOutput> StmClerk<D> {
         let closed_reg = signer
             .get_closed_reg()
             .clone()
-            // .expect("Core signer does not include closed registration. StmClerk, and so, the Stm certificate cannot be built without closed registration!")
+            .expect("Core signer does not include closed registration. StmClerk, and so, the Stm certificate cannot be built without closed registration!")
             ;
 
         Self {