fix: clippy warnings with Rust '1.78.0'

Author: jpraynaud

internal/mithril-build-script/src/open_api.rs

@@ -145,7 +145,7 @@ info:
         write_minimal_open_api_file("2.0.0", &sub_folder.join("openapi-thales.yaml"));
 
         let expected = r#"("openapi-thales.yaml".to_string(), semver::Version::new(2, 0, 0)), ("openapi.yaml".to_string(), semver::Version::new(1, 0, 0))"#;
-        let generated_code = generate_open_api_versions_mapping(&[&parent_folder, &sub_folder]);
+        let generated_code = generate_open_api_versions_mapping(&[parent_folder, &sub_folder]);
 
         assert_open_api_content_contains(expected, &generated_code);
     }
@@ -162,7 +162,7 @@ info:
         let expected = r#"HashMap::from([
         ("openapi.yaml".to_string(), semver::Version::new(2, 0, 0)), 
     ])"#;
-        let generated_code = generate_open_api_versions_mapping(&[&parent_folder, &sub_folder]);
+        let generated_code = generate_open_api_versions_mapping(&[parent_folder, &sub_folder]);
 
         assert_open_api_content_contains(expected, &generated_code);
     }

internal/mithril-doc/src/lib.rs

@@ -87,13 +87,14 @@ impl StructDoc {
             } else {
                 let mut d = data_map1.get(&field_doc.parameter).unwrap().clone();
                 if d.default_value.is_none() {
-                    d.default_value = field_doc.default_value.clone();
+                    d.default_value.clone_from(&field_doc.default_value);
                 }
                 if d.example.is_none() {
-                    d.example = field_doc.example.clone();
+                    d.example.clone_from(&field_doc.example);
                 }
                 if d.environment_variable.is_none() {
-                    d.environment_variable = field_doc.environment_variable.clone();
+                    d.environment_variable
+                        .clone_from(&field_doc.environment_variable);
                 }
                 data_map1.insert(field_doc.parameter.clone(), d);
             }

mithril-aggregator/src/signer_registerer.rs

@@ -251,7 +251,7 @@ impl SignerRegisterer for MithrilSignerRegisterer {
                 .get(&party_id_save)
                 .unwrap(),
         );
-        signer_save.party_id = party_id_save.clone();
+        signer_save.party_id.clone_from(&party_id_save);
 
         self.signer_recorder
             .record_signer_registration(party_id_save)

mithril-aggregator/src/tools/certificates_hash_migrator.rs

@@ -66,12 +66,12 @@ impl CertificatesHashMigrator {
                 certificate.previous_hash.clone()
             } else {
                 let old_previous_hash = certificate.previous_hash.clone();
-                certificate.previous_hash = old_and_new_hashes
+                old_and_new_hashes
                     .get(&certificate.previous_hash)
                     .ok_or(anyhow!(
                         "Could not migrate certificate previous_hash: The hash '{}' doesn't exist in the certificate table",
                         &certificate.previous_hash
-                    ))?.to_owned();
+                    ))?.clone_into(&mut certificate.previous_hash);
 
                 old_previous_hash
             };
@@ -332,7 +332,7 @@ mod test {
 
         for (mut certificate, signed_entity_maybe) in certificates_and_signed_entity {
             if let Some(hash) = old_and_new_hashes.get(&certificate.previous_hash) {
-                certificate.previous_hash = hash.clone();
+                certificate.previous_hash.clone_from(hash);
             }
 
             let new_hash = certificate.compute_hash();
@@ -342,7 +342,7 @@ mod test {
             let signed_entity_maybe = match signed_entity_maybe {
                 None => None,
                 Some(mut signed_entity) => {
-                    signed_entity.certificate_id = certificate.hash.clone();
+                    signed_entity.certificate_id.clone_from(&certificate.hash);
                     Some(signed_entity)
                 }
             };

mithril-common/build.rs

@@ -7,7 +7,7 @@ use std::path::Path;
 
 fn main() {
     let out_dir = env::var_os("OUT_DIR").unwrap();
-    let open_api_code = generate_open_api_versions_mapping(&[Path::new("./"), &Path::new("../")]);
+    let open_api_code = generate_open_api_versions_mapping(&[Path::new("./"), (Path::new("../"))]);
 
     fs::write(Path::new(&out_dir).join("open_api.rs"), open_api_code).unwrap();
 }

mithril-common/src/certificate_chain/certificate_verifier.rs

@@ -468,7 +468,9 @@ mod tests {
             "another-avk".to_string(),
         );
         fake_certificate2.hash = fake_certificate2.compute_hash();
-        fake_certificate1.previous_hash = fake_certificate2.hash.clone();
+        fake_certificate1
+            .previous_hash
+            .clone_from(&fake_certificate2.hash);
         fake_certificate1.hash = fake_certificate1.compute_hash();
         let mut mock_certificate_retriever = MockCertificateRetrieverImpl::new();
         mock_certificate_retriever

mithril-common/src/chain_observer/cli_observer.rs

@@ -635,9 +635,7 @@ mod tests {
                 .get("pool1qz2vzszautc2c8mljnqre2857dpmheq7kgt6vav0s38tvvhxm6w")
                 .unwrap()
         );
-        assert!(results
-            .get("pool1qpqvz90w7qsex2al2ejjej0rfgrwsguch307w8fraw7a7adf6g8")
-            .is_none());
+        assert!(!results.contains_key("pool1qpqvz90w7qsex2al2ejjej0rfgrwsguch307w8fraw7a7adf6g8"));
     }
 
     #[tokio::test]

mithril-common/src/crypto_helper/merkle_tree.rs

@@ -8,6 +8,7 @@ use ckb_merkle_mountain_range::{
 use serde::{Deserialize, Serialize};
 use std::{
     collections::{BTreeMap, HashMap},
+    fmt::Display,
     ops::{Add, Deref},
     sync::Arc,
 };
@@ -82,9 +83,9 @@ impl TryFrom<&MKTree> for MKTreeNode {
     }
 }
 
-impl ToString for MKTreeNode {
-    fn to_string(&self) -> String {
-        String::from_utf8_lossy(&self.hash).to_string()
+impl Display for MKTreeNode {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}", String::from_utf8_lossy(&self.hash))
     }
 }
 

mithril-common/src/digesters/immutable_file.rs

@@ -117,9 +117,9 @@ impl ImmutableFile {
     }
 
     /// Compute the hash of this immutable file.
-    pub fn compute_raw_hash<D: Digest>(&self) -> Result<Output<D>, io::Error>
+    pub fn compute_raw_hash<D>(&self) -> Result<Output<D>, io::Error>
     where
-        D: io::Write,
+        D: Digest + io::Write,
     {
         let mut hasher = D::new();
         let mut file = File::open(&self.path)?;

mithril-stm/src/merkle_tree.rs

@@ -375,8 +375,8 @@ impl<D: Clone + Digest> MerkleTreeCommitmentBatchCompat<D> {
                 }
                 i += 1;
             }
-            leaves = new_hashes.clone();
-            ordered_indices = new_indices.clone();
+            leaves.clone_from(&new_hashes);
+            ordered_indices.clone_from(&new_indices);
         }
 
         if leaves.len() == 1 && leaves[0] == self.root {
@@ -541,7 +541,7 @@ impl<D: Digest + FixedOutput> MerkleTree<D> {
                 }
                 i += 1;
             }
-            ordered_indices = new_indices.clone();
+            ordered_indices.clone_from(&new_indices);
         }
 
         BatchPath {