Merge pull request #2513 from input-output-hk/dlachaume/display-error-logs-in-ci-tests-clients

Fix: display missing logs in `Mithril Client multi-platform test`

Author: dlachaume

.github/workflows/test-client.yml

@@ -160,7 +160,7 @@ jobs:
       - name: Cardano Database Snapshot / download & restore latest
         shell: bash
         working-directory: ./bin
-        run: ./mithril-client ${{ steps.prepare.outputs.debug_level }} --origin-tag CI cardano-db download $CDB_SNAPSHOT_DIGEST ${{ matrix.extra_args }} > cdb-download-output.txt 2>&1
+        run: ./mithril-client ${{ steps.prepare.outputs.debug_level }} --origin-tag CI cardano-db download $CDB_SNAPSHOT_DIGEST ${{ matrix.extra_args }} 2>&1 | tee cdb-download-output.txt
 
       - name: Cardano Database Snapshot / verify Cardano node starts successfully
         if: runner.os == 'Linux'
@@ -239,7 +239,7 @@ jobs:
         if: steps.aggregator_capability_unix.outputs.cardano_database_v2_enabled == 'true' || steps.aggregator_capability_windows.outputs.cardano_database_v2_enabled == 'true'
         shell: bash
         working-directory: ./bin
-        run: ./mithril-client ${{ steps.prepare.outputs.debug_level }} --unstable --origin-tag CI cardano-db-v2 download $CARDANO_DATABASE_V2_SNAPSHOT_HASH ${{ matrix.extra_args }} > cdb-v2-download-output.txt 2>&1
+        run: ./mithril-client ${{ steps.prepare.outputs.debug_level }} --unstable --origin-tag CI cardano-db-v2 download $CARDANO_DATABASE_V2_SNAPSHOT_HASH ${{ matrix.extra_args }} 2>&1 | tee cdb-download-output.txt
 
       - name: Cardano Database V2 Snapshot / verify Cardano node starts successfully
         if: runner.os == 'Linux' && steps.aggregator_capability_unix.outputs.cardano_database_v2_enabled == 'true'

Cargo.toml

@@ -3,31 +3,31 @@
 resolver = "2"
 
 members = [
-  "demo/protocol-demo",
-  "examples/client-cardano-database",
-  "examples/client-cardano-database-v2",
-  "examples/client-cardano-stake-distribution",
-  "examples/client-cardano-transaction",
-  "examples/client-mithril-stake-distribution",
-  "internal/mithril-build-script",
-  "internal/mithril-cli-helper",
-  "internal/mithril-doc",
-  "internal/mithril-doc-derive",
-  "internal/mithril-metric",
-  "internal/mithril-persistence",
-  "internal/mithril-resource-pool",
-  "internal/signed-entity/mithril-signed-entity-lock",
-  "internal/signed-entity/mithril-signed-entity-preloader",
-  "mithril-aggregator",
-  "mithril-client",
-  "mithril-client-cli",
-  "mithril-client-wasm",
-  "mithril-common",
-  "mithril-relay",
-  "mithril-signer",
-  "mithril-stm",
-  "mithril-test-lab/mithril-aggregator-fake",
-  "mithril-test-lab/mithril-end-to-end",
+    "demo/protocol-demo",
+    "examples/client-cardano-database",
+    "examples/client-cardano-database-v2",
+    "examples/client-cardano-stake-distribution",
+    "examples/client-cardano-transaction",
+    "examples/client-mithril-stake-distribution",
+    "internal/mithril-build-script",
+    "internal/mithril-cli-helper",
+    "internal/mithril-doc",
+    "internal/mithril-doc-derive",
+    "internal/mithril-metric",
+    "internal/mithril-persistence",
+    "internal/mithril-resource-pool",
+    "internal/signed-entity/mithril-signed-entity-lock",
+    "internal/signed-entity/mithril-signed-entity-preloader",
+    "mithril-aggregator",
+    "mithril-client",
+    "mithril-client-cli",
+    "mithril-client-wasm",
+    "mithril-common",
+    "mithril-relay",
+    "mithril-signer",
+    "mithril-stm",
+    "mithril-test-lab/mithril-aggregator-fake",
+    "mithril-test-lab/mithril-end-to-end",
 ]
 
 [workspace.package]
@@ -48,9 +48,9 @@ config = "0.15.11"
 digest = { version = "0.10.7", features = ["alloc"] }
 hex = "0.4.3"
 mockall = "0.13.1"
-rayon = "1.10.0"
-rand_core = { version = "0.6.4", features = ["std"] }
 rand_chacha = "0.3.1"
+rand_core = { version = "0.6.4", features = ["std"] }
+rayon = "1.10.0"
 reqwest = { version = "0.12.15", default-features = false, features = ["json"] }
 semver = "1.0.26"
 serde = { version = "1.0.219", features = ["derive", "rc"] }
@@ -61,6 +61,6 @@ slog-bunyan = "2.5.0"
 slog-term = "2.9.1"
 strum = { version = "0.27.1", features = ["derive"] }
 thiserror = "2.0.12"
-tracing = "0.1.41"
 tokio = { version = "1.44.2", features = ["rt", "sync", "time"] }
+tracing = "0.1.41"
 warp = "0.3.7"

internal/mithril-cli-helper/Cargo.toml

@@ -9,12 +9,12 @@ license = { workspace = true }
 repository = { workspace = true }
 include = ["**/*.rs", "Cargo.toml", "README.md", ".gitignore"]
 
+[features]
+default = []
+
 [dependencies]
 config = { workspace = true }
 serde = { workspace = true }
 
 #[dev-dependencies]
 serde_json = { workspace = true }
-
-[features]
-default = []

internal/mithril-doc-derive/Cargo.toml

@@ -11,9 +11,9 @@ repository = { workspace = true }
 [lib]
 proc-macro = true
 
+[features]
+default = []
+
 [dependencies]
 quote = "1.0.40"
 syn = { version = "2.0.101", features = ["full"] }
-
-[features]
-default = []

internal/mithril-doc/Cargo.toml

@@ -9,6 +9,9 @@ license = { workspace = true }
 repository = { workspace = true }
 include = ["**/*.rs", "Cargo.toml", "README.md", ".gitignore"]
 
+[features]
+default = []
+
 [dependencies]
 clap = { workspace = true }
 config = { workspace = true }
@@ -17,6 +20,3 @@ mithril-doc-derive = { path = "../mithril-doc-derive" }
 [dev-dependencies]
 mithril-cli-helper = { path = "../mithril-cli-helper" }
 regex = "1.11.1"
-
-[features]
-default = []

mithril-aggregator/Cargo.toml

@@ -9,13 +9,11 @@ homepage = { workspace = true }
 license = { workspace = true }
 repository = { workspace = true }
 
-[[bench]]
-name = "cardano_transactions_import"
-harness = false
+[features]
+default = ["jemallocator"]
 
-[[bench]]
-name = "cardano_transactions_get"
-harness = false
+bundle_tls = ["reqwest/native-tls-vendored"]
+jemallocator = ["dep:tikv-jemallocator"]
 
 [dependencies]
 anyhow = { workspace = true }
@@ -84,8 +82,10 @@ slog-scope = "4.4.0"
 slog-term = { workspace = true }
 tempfile = "3.19.1"
 
-[features]
-default = ["jemallocator"]
+[[bench]]
+name = "cardano_transactions_import"
+harness = false
 
-bundle_tls = ["reqwest/native-tls-vendored"]
-jemallocator = ["dep:tikv-jemallocator"]
+[[bench]]
+name = "cardano_transactions_get"
+harness = false

mithril-client-cli/Cargo.toml

@@ -9,10 +9,6 @@ homepage = { workspace = true }
 license = { workspace = true }
 repository = { workspace = true }
 
-[[bin]]
-name = "mithril-client"
-path = "src/main.rs"
-
 [package.metadata.deb]
 depends = "$auto"
 section = "utility"
@@ -21,6 +17,13 @@ extended-description = """Shows, downloads and verifies certified blockchain art
 Run `mithril-client --help` to display the available options."""
 assets = [["../target/release/mithril-client", "usr/bin/", "755"]]
 
+[[bin]]
+name = "mithril-client"
+path = "src/main.rs"
+
+[features]
+bundle_tls = ["mithril-client/native-tls-vendored"]
+
 [dependencies]
 anyhow = { workspace = true }
 async-trait = { workspace = true }
@@ -49,6 +52,3 @@ tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }
 
 [dev-dependencies]
 mithril-common = { path = "../mithril-common", features = ["test_tools"] }
-
-[features]
-bundle_tls = ["mithril-client/native-tls-vendored"]

mithril-client-wasm/Cargo.toml

@@ -9,9 +9,23 @@ license = { workspace = true }
 repository = { workspace = true }
 categories = ["cryptography"]
 
+[package.metadata.docs.rs]
+all-features = true
+# enable unstable features in the documentation
+rustdoc-args = ["--cfg", "docsrs"]
+
+[package.metadata.cargo-machete]
+# wasm-bindgen-futures is required to build the project, but it's not used in the code
+ignored = ["wasm-bindgen-futures"]
+
 [lib]
 crate-type = ["cdylib"]
 
+[features]
+# Include nothing by default
+default = []
+test-node = []
+
 [dependencies]
 anyhow = { workspace = true }
 async-trait = { workspace = true }
@@ -24,22 +38,8 @@ wasm-bindgen = "0.2.100"
 wasm-bindgen-futures = "0.4.50"
 web-sys = { version = "0.3.77", features = ["BroadcastChannel", "console", "Storage", "Window"] }
 
-[dev-dependencies]
-wasm-bindgen-test = "0.3.50"
-
 [build-dependencies]
 mithril-build-script = { path = "../internal/mithril-build-script" }
 
-[features]
-# Include nothing by default
-default = []
-test-node = []
-
-[package.metadata.docs.rs]
-all-features = true
-# enable unstable features in the documentation
-rustdoc-args = ["--cfg", "docsrs"]
-
-[package.metadata.cargo-machete]
-# wasm-bindgen-futures is required to build the project, but it's not used in the code
-ignored = ["wasm-bindgen-futures"]
+[dev-dependencies]
+wasm-bindgen-test = "0.3.50"

mithril-client/Cargo.toml

@@ -10,23 +10,45 @@ repository = { workspace = true }
 categories = ["cryptography"]
 include = ["**/*.rs", "Cargo.toml", "README.md", ".gitignore"]
 
+[package.metadata.docs.rs]
+all-features = true
+# enable unstable features in the documentation
+rustdoc-args = ["--cfg", "docsrs"]
+
 [lib]
 crate-type = ["lib", "cdylib", "staticlib"]
 
-[[test]]
-name = "snapshot_list_get_show_download_verify"
-path = "tests/snapshot_list_get_show_download_verify.rs"
-required-features = ["fs"]
+[features]
+# Include native-tls in reqwest by default
+default = ["native-tls", "rug-backend", "enable-http-compression"]
 
-[[test]]
-name = "cardano_transaction_proof"
-path = "tests/cardano_transaction_proof.rs"
-required-features = ["unstable"]
+# Full feature set
+full = ["fs"]
 
-[[test]]
-name = "cardano_db_snapshot_list_get_download_verify"
-path = "tests/cardano_db_snapshot_list_get_download_verify.rs"
-required-features = ["unstable", "fs"]
+# Enable file system related functionality, right now that mean only snapshot download
+fs = ["flate2", "flume", "tar", "tokio/rt", "zstd"]
+portable = []                                       # deprecated, will be removed soon
+unstable = []
+
+# These features are for support of dependent crates only.
+# They do not change the operation of the main crate.
+native-tls = ["reqwest/native-tls"]
+native-tls-alpn = ["reqwest/native-tls-alpn"]
+native-tls-vendored = ["reqwest/native-tls-vendored"]
+
+rustls-tls = ["reqwest/rustls-tls"]
+rustls-tls-manual-roots = ["reqwest/rustls-tls-manual-roots"]
+rustls-tls-webpki-roots = ["reqwest/rustls-tls-webpki-roots"]
+rustls-tls-native-roots = ["reqwest/rustls-tls-native-roots"]
+
+# Support compressed traffic with `reqwest`
+enable-http-compression = ["reqwest/gzip", "reqwest/zstd", "reqwest/deflate", "reqwest/brotli"]
+
+# Enables usage of `rug` numerical backend in `mithril-stm` (dependency of `mithril-common`).
+rug-backend = ["mithril-common/rug-backend"]
+# Enables usage of `num-integer` numerical backend in `mithril-stm` (dependency of `mithril-common`)
+# by default it's `rug-backend`
+num-integer-backend = ["mithril-common/num-integer-backend"]
 
 [dependencies]
 anyhow = { workspace = true }
@@ -77,39 +99,17 @@ slog-term = { workspace = true }
 tokio = { workspace = true, features = ["macros"] }
 warp = { workspace = true }
 
-[features]
-# Include native-tls in reqwest by default
-default = ["native-tls", "rug-backend", "enable-http-compression"]
-
-# Full feature set
-full = ["fs"]
-
-# Enable file system related functionality, right now that mean only snapshot download
-fs = ["flate2", "flume", "tar", "tokio/rt", "zstd"]
-portable = []                                       # deprecated, will be removed soon
-unstable = []
-
-# These features are for support of dependent crates only.
-# They do not change the operation of the main crate.
-native-tls = ["reqwest/native-tls"]
-native-tls-alpn = ["reqwest/native-tls-alpn"]
-native-tls-vendored = ["reqwest/native-tls-vendored"]
-
-rustls-tls = ["reqwest/rustls-tls"]
-rustls-tls-manual-roots = ["reqwest/rustls-tls-manual-roots"]
-rustls-tls-webpki-roots = ["reqwest/rustls-tls-webpki-roots"]
-rustls-tls-native-roots = ["reqwest/rustls-tls-native-roots"]
-
-# Support compressed traffic with `reqwest`
-enable-http-compression = ["reqwest/gzip", "reqwest/zstd", "reqwest/deflate", "reqwest/brotli"]
+[[test]]
+name = "snapshot_list_get_show_download_verify"
+path = "tests/snapshot_list_get_show_download_verify.rs"
+required-features = ["fs"]
 
-# Enables usage of `rug` numerical backend in `mithril-stm` (dependency of `mithril-common`).
-rug-backend = ["mithril-common/rug-backend"]
-# Enables usage of `num-integer` numerical backend in `mithril-stm` (dependency of `mithril-common`)
-# by default it's `rug-backend`
-num-integer-backend = ["mithril-common/num-integer-backend"]
+[[test]]
+name = "cardano_transaction_proof"
+path = "tests/cardano_transaction_proof.rs"
+required-features = ["unstable"]
 
-[package.metadata.docs.rs]
-all-features = true
-# enable unstable features in the documentation
-rustdoc-args = ["--cfg", "docsrs"]
+[[test]]
+name = "cardano_db_snapshot_list_get_download_verify"
+path = "tests/cardano_db_snapshot_list_get_download_verify.rs"
+required-features = ["unstable", "fs"]