fix: warnings about using 'std::slice::from_ref' instead of '&[T.clone()]'

Author: jpraynaud

mithril-aggregator/src/http_server/validators/prover_transactions_hash_validator.rs

@@ -96,7 +96,7 @@ mod tests {
         for invalid_char in ["g", "x", ";", " ", "à"].iter() {
             let hash = format!("{}{}", "a".repeat(63), invalid_char);
             let error = ProverTransactionsHashValidator::default()
-                .validate(&[hash.clone()])
+                .validate(std::slice::from_ref(&hash))
                 .expect_err("Should return an error");
             assert_eq!(
                 error,

mithril-aggregator/src/services/message.rs

@@ -621,7 +621,7 @@ mod tests {
         async fn get_certificate() {
             let genesis_certificate = fake_data::genesis_certificate("genesis_hash");
             let service = MessageServiceBuilder::new()
-                .with_certificates(&[genesis_certificate.clone()])
+                .with_certificates(std::slice::from_ref(&genesis_certificate))
                 .build()
                 .await;
 
@@ -705,7 +705,7 @@ mod tests {
             let message: SnapshotMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 
@@ -778,7 +778,7 @@ mod tests {
             let message: CardanoDatabaseSnapshotMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 
@@ -869,7 +869,7 @@ mod tests {
             let message: MithrilStakeDistributionMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 
@@ -949,7 +949,7 @@ mod tests {
             let message: CardanoTransactionSnapshotMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 
@@ -1028,7 +1028,7 @@ mod tests {
             let message: CardanoStakeDistributionMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 
@@ -1066,7 +1066,7 @@ mod tests {
             let message: CardanoStakeDistributionMessage = record.clone().try_into().unwrap();
 
             let service = MessageServiceBuilder::new()
-                .with_signed_entity_records(&[record.clone()])
+                .with_signed_entity_records(std::slice::from_ref(&record))
                 .build()
                 .await;
 

mithril-aggregator/tests/prove_transactions.rs

@@ -115,7 +115,7 @@ async fn prove_transactions() {
     let proof_for_last_transaction = prover
         .compute_transactions_proofs(
             last_tx_snapshot.artifact.block_number,
-            &[last_transaction_hash.clone()],
+            std::slice::from_ref(&last_transaction_hash),
         )
         .await
         .unwrap()

mithril-client-cli/src/utils/feedback_receiver.rs

@@ -421,7 +421,8 @@ mod tests {
         #[tokio::test]
         async fn starting_full_immutables_and_ancillary_together_spawn_two_progress_bars() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db_v1, full_immutables_dl, started => sender, digest:"digest", size:123);
             send_event!(cardano_db_v1, ancillary_dl, started =>  sender, size:456);
@@ -433,7 +434,8 @@ mod tests {
         #[tokio::test]
         async fn start_and_progress_ancillary_download_with_a_size_of_zero_should_not_crash() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db_v1, ancillary_dl, started => sender, size:0);
             send_event!(cardano_db_v1, ancillary_dl, progress => sender, bytes:124, size:0);
@@ -444,7 +446,8 @@ mod tests {
         #[tokio::test]
         async fn start_then_complete_should_remove_immutables_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db_v1, full_immutables_dl, started => sender, digest:"digest", size:123);
             send_event!(cardano_db_v1, full_immutables_dl, completed => sender);
@@ -455,7 +458,8 @@ mod tests {
         #[tokio::test]
         async fn start_then_complete_should_remove_ancillary_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db_v1, ancillary_dl, started =>  sender, size:456);
             send_event!(cardano_db_v1, ancillary_dl, completed =>  sender);
@@ -470,7 +474,8 @@ mod tests {
         #[tokio::test]
         async fn starting_should_add_multi_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:99, ancillary:false);
 
@@ -480,7 +485,8 @@ mod tests {
         #[tokio::test]
         async fn start_then_complete_should_remove_multi_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:99, ancillary:false);
             send_event!(cardano_db, dl_completed => sender);
@@ -491,7 +497,8 @@ mod tests {
         #[tokio::test]
         async fn start_including_ancillary_add_one_to_total_downloads() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:99, ancillary:true);
 
@@ -509,7 +516,8 @@ mod tests {
         #[tokio::test]
         async fn starting_twice_should_supersede_first_multi_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:50, ancillary:false);
             send_event!(cardano_db, dl_started => sender, total:99, ancillary:false);
@@ -528,15 +536,17 @@ mod tests {
         #[tokio::test]
         async fn complete_without_start_should_not_panic() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_completed => sender);
         }
 
         #[tokio::test]
         async fn starting_immutable_downloads_should_not_add_progress_bars() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:50, ancillary:false);
 
@@ -551,7 +561,8 @@ mod tests {
         #[tokio::test]
         async fn completed_immutable_downloads_bump_progress() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:50, ancillary:false);
 
@@ -566,7 +577,8 @@ mod tests {
         #[tokio::test]
         async fn starting_digests_downloads_should_not_add_progress_bars() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:50, ancillary:false);
 
@@ -581,7 +593,8 @@ mod tests {
         #[tokio::test]
         async fn starting_ancillary_downloads_should_add_a_progress_bar() {
             let receiver = build_feedback_receiver(ProgressOutputType::Hidden);
-            let sender = FeedbackSender::new(&[receiver.clone()]);
+            let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+            let sender = FeedbackSender::new(&[receiver_clone]);
 
             send_event!(cardano_db, dl_started => sender, total:50, ancillary:false);
 

mithril-client/src/feedback.rs

@@ -590,7 +590,8 @@ mod tests {
     #[tokio::test]
     async fn send_event_same_thread() {
         let receiver = Arc::new(StackFeedbackReceiver::new());
-        let sender = FeedbackSender::new(&[receiver.clone()]);
+        let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
+        let sender = FeedbackSender::new(&[receiver_clone]);
 
         sender
             .send_event(SnapshotDownloadStarted {
@@ -716,8 +717,9 @@ mod tests {
     #[tokio::test]
     async fn send_event_in_one_thread_and_receive_in_another_thread() {
         let receiver = Arc::new(StackFeedbackReceiver::new());
+        let receiver_clone = receiver.clone() as Arc<dyn FeedbackReceiver>;
         let receiver2 = receiver.clone();
-        let sender = FeedbackSender::new(&[receiver.clone()]);
+        let sender = FeedbackSender::new(&[receiver_clone]);
         let mut join_set = JoinSet::new();
 
         join_set.spawn(async move {

mithril-client/src/file_downloader/http.rs

@@ -245,7 +245,9 @@ mod tests {
     use mithril_common::{entities::FileUri, test::TempDir};
 
     use crate::{
-        feedback::{MithrilEvent, MithrilEventCardanoDatabase, StackFeedbackReceiver},
+        feedback::{
+            FeedbackReceiver, MithrilEvent, MithrilEventCardanoDatabase, StackFeedbackReceiver,
+        },
         test_utils::TestLogger,
     };
 
@@ -288,8 +290,9 @@ mod tests {
                 .header(reqwest::header::CONTENT_LENGTH.as_str(), size.to_string());
         });
         let feedback_receiver = Arc::new(StackFeedbackReceiver::new());
+        let feedback_receiver_clone = feedback_receiver.clone() as Arc<dyn FeedbackReceiver>;
         let http_file_downloader = HttpFileDownloader::new(
-            FeedbackSender::new(&[feedback_receiver.clone()]),
+            FeedbackSender::new(&[feedback_receiver_clone]),
             TestLogger::stdout(),
         )
         .unwrap();
@@ -339,8 +342,9 @@ mod tests {
         file.write_all(content.as_bytes()).unwrap();
 
         let feedback_receiver = Arc::new(StackFeedbackReceiver::new());
+        let feedback_receiver_clone = feedback_receiver.clone() as Arc<dyn FeedbackReceiver>;
         let http_file_downloader = HttpFileDownloader::new(
-            FeedbackSender::new(&[feedback_receiver.clone()]),
+            FeedbackSender::new(&[feedback_receiver_clone]),
             TestLogger::stdout(),
         )
         .unwrap();

mithril-common/src/test/double/certificate_retriever.rs

@@ -53,7 +53,7 @@ mod tests {
         let certificate = fake_data::certificate("certificate-hash-123".to_string());
         let certificate_hash = certificate.hash.clone();
         let certificate_retriever =
-            FakeCertificaterRetriever::from_certificates(&[certificate.clone()]);
+            FakeCertificaterRetriever::from_certificates(std::slice::from_ref(&certificate));
 
         let retrieved_certificate = certificate_retriever
             .get_certificate_details(&certificate_hash)

mithril-test-lab/mithril-end-to-end/src/stress_test/fake_signer.rs

@@ -73,7 +73,7 @@ pub async fn try_register_signer_until_registration_round_is_open(
     timeout: Duration,
 ) -> StdResult<()> {
     let mut register_message =
-        payload_builder::generate_register_signer_message(&[signer.clone()], epoch);
+        payload_builder::generate_register_signer_message(std::slice::from_ref(signer), epoch);
     let register_message = register_message.swap_remove(0);
     let party_id = register_message.party_id.clone();