test(aggregator-client): add test to CertificateDetailsQuery and get latest genesis

imported and adapted from the associated route tests in the
`mithril-aggregator` aggregator client.

Author: Alenar

internal/mithril-aggregator-client/src/client.rs

@@ -109,24 +109,13 @@ impl AggregatorClient {
 #[cfg(test)]
 mod tests {
     use http::StatusCode;
-    use httpmock::MockServer;
 
     use mithril_common::test::api_version_extensions::ApiVersionProviderTestExtension;
 
-    use crate::test::TestLogger;
+    use crate::test::{TestLogger, setup_server_and_client};
 
     use super::*;
 
-    fn setup_server_and_client() -> (MockServer, AggregatorClient) {
-        let server = MockServer::start();
-        let client = AggregatorClient::builder(server.base_url())
-            .with_logger(TestLogger::stdout())
-            .build()
-            .unwrap();
-
-        (server, client)
-    }
-
     #[derive(Debug, Eq, PartialEq, serde::Deserialize)]
     struct TestResponse {
         foo: String,

internal/mithril-aggregator-client/src/query/certificate/get_certificate_details.rs

@@ -16,8 +16,15 @@ pub struct CertificateDetailsQuery {
 
 impl CertificateDetailsQuery {
     /// Instantiate a query to get a certificate by hash
-    pub fn by_hash(hash: String) -> Self {
-        Self { hash }
+    pub fn by_hash<H: Into<String>>(hash: H) -> Self {
+        Self { hash: hash.into() }
+    }
+
+    /// Instantiate a query to get the latest genesis certificate
+    pub fn latest_genesis() -> Self {
+        Self {
+            hash: "genesis".to_string(),
+        }
     }
 }
 
@@ -51,3 +58,111 @@ impl AggregatorQuery for CertificateDetailsQuery {
         }
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use serde_json::json;
+
+    use mithril_common::test::double::Dummy;
+
+    use crate::test::setup_server_and_client;
+
+    use super::*;
+
+    #[tokio::test]
+    async fn test_certificates_details_ok_200() {
+        let (server, client) = setup_server_and_client();
+        let expected_message = CertificateMessage::dummy();
+        let _server_mock = server.mock(|when, then| {
+            when.path(format!("/certificate/{}", expected_message.hash));
+            then.status(200).body(json!(expected_message).to_string());
+        });
+
+        let fetched_message = client
+            .send(CertificateDetailsQuery::by_hash(&expected_message.hash))
+            .await
+            .unwrap();
+
+        assert_eq!(Some(expected_message), fetched_message);
+    }
+
+    #[tokio::test]
+    async fn test_certificates_details_ok_404() {
+        let (server, client) = setup_server_and_client();
+        let _server_mock = server.mock(|when, then| {
+            when.any_request();
+            then.status(404);
+        });
+
+        let fetched_message = client
+            .send(CertificateDetailsQuery::by_hash("whatever"))
+            .await
+            .unwrap();
+
+        assert_eq!(None, fetched_message);
+    }
+
+    #[tokio::test]
+    async fn test_certificates_details_ko_500() {
+        let (server, client) = setup_server_and_client();
+        let _server_mock = server.mock(|when, then| {
+            when.any_request();
+            then.status(500).body("an error occurred");
+        });
+
+        match client
+            .send(CertificateDetailsQuery::by_hash("whatever"))
+            .await
+            .unwrap_err()
+        {
+            AggregatorClientError::RemoteServerTechnical(_) => (),
+            e => panic!("Expected Aggregator::RemoteServerTechnical error, got '{e:?}'."),
+        };
+    }
+
+    #[tokio::test]
+    async fn test_latest_genesis_ok_200() {
+        let (server, client) = setup_server_and_client();
+        let genesis_message = CertificateMessage::dummy();
+        let _server_mock = server.mock(|when, then| {
+            when.path("/certificate/genesis");
+            then.status(200).body(json!(genesis_message).to_string());
+        });
+
+        let fetched = client.send(CertificateDetailsQuery::latest_genesis()).await.unwrap();
+
+        assert_eq!(Some(genesis_message), fetched);
+    }
+
+    #[tokio::test]
+    async fn test_latest_genesis_ok_404() {
+        let (server, client) = setup_server_and_client();
+        let _server_mock = server.mock(|when, then| {
+            when.path("/certificate/genesis");
+            then.status(404);
+        });
+
+        let fetched = client.send(CertificateDetailsQuery::latest_genesis()).await.unwrap();
+
+        assert_eq!(None, fetched);
+    }
+
+    #[tokio::test]
+    async fn test_latest_genesis_ko_500() {
+        let (server, client) = setup_server_and_client();
+        let _server_mock = server.mock(|when, then| {
+            when.path("/certificate/genesis");
+            then.status(500).body("an error occurred");
+        });
+
+        let error = client
+            .send(CertificateDetailsQuery::latest_genesis())
+            .await
+            .unwrap_err();
+
+        assert!(
+            matches!(error, AggregatorClientError::RemoteServerTechnical(_)),
+            "Expected Aggregator::RemoteServerTechnical error, got {error:?}"
+        );
+    }
+}

internal/mithril-aggregator-client/src/query/mod.rs

@@ -1,7 +1,7 @@
 //! Provides queries to retrieve or send data to a Mithril aggregator
 //!
 //! Available queries
-//! - Certificate: Get by hash
+//! - Certificate: Get by hash, get latest genesis certificate
 //!
 mod api;
 mod certificate;

internal/mithril-aggregator-client/src/test/mod.rs

@@ -1,2 +1,17 @@
+use httpmock::MockServer;
+
+use crate::AggregatorClient;
+
 #[cfg(test)]
 mithril_common::define_test_logger!();
+
+#[cfg(test)]
+pub(crate) fn setup_server_and_client() -> (MockServer, AggregatorClient) {
+    let server = MockServer::start();
+    let client = AggregatorClient::builder(server.base_url())
+        .with_logger(TestLogger::stdout())
+        .build()
+        .unwrap();
+
+    (server, client)
+}