fix: warnings about never used structs

Author: jpraynaud

mithril-aggregator/src/services/aggregator_client.rs

@@ -379,41 +379,6 @@ impl RemoteCertificateRetriever for AggregatorHTTPClient {
     }
 }
 
-#[cfg(test)]
-pub(crate) mod dumb {
-    use tokio::sync::RwLock;
-
-    use mithril_common::test::double::Dummy;
-
-    use super::*;
-
-    /// This aggregator client is intended to be used by test services.
-    /// It actually does not communicate with an aggregator host but mimics this behavior.
-    /// It is driven by a Tester that controls the data it can return, and it can return its internal state for testing.
-    pub struct DumbAggregatorClient {
-        epoch_settings: RwLock<Option<LeaderAggregatorEpochSettings>>,
-    }
-
-    impl Default for DumbAggregatorClient {
-        fn default() -> Self {
-            Self {
-                epoch_settings: RwLock::new(Some(LeaderAggregatorEpochSettings::dummy())),
-            }
-        }
-    }
-
-    #[async_trait]
-    impl LeaderAggregatorClient for DumbAggregatorClient {
-        async fn retrieve_epoch_settings(
-            &self,
-        ) -> StdResult<Option<LeaderAggregatorEpochSettings>> {
-            let epoch_settings = self.epoch_settings.read().await.clone();
-
-            Ok(epoch_settings)
-        }
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use http::response::Builder as HttpResponseBuilder;

mithril-aggregator/src/store/epoch_settings_storer.rs

@@ -1,7 +1,9 @@
+#[cfg(test)]
 use std::collections::HashMap;
 
 use async_trait::async_trait;
 use mithril_common::StdResult;
+#[cfg(test)]
 use tokio::sync::RwLock;
 
 use mithril_common::entities::{Epoch, ProtocolParameters};
@@ -56,18 +58,20 @@ pub trait EpochSettingsStorer:
     }
 }
 
+#[cfg(test)]
 pub struct FakeEpochSettingsStorer {
     pub epoch_settings: RwLock<HashMap<Epoch, AggregatorEpochSettings>>,
 }
 
+#[cfg(test)]
 impl FakeEpochSettingsStorer {
-    #[cfg(test)]
     pub fn new(data: Vec<(Epoch, AggregatorEpochSettings)>) -> Self {
         let epoch_settings = RwLock::new(data.into_iter().collect());
         Self { epoch_settings }
     }
 }
 
+#[cfg(test)]
 #[async_trait]
 impl ProtocolParametersRetriever for FakeEpochSettingsStorer {
     async fn get_protocol_parameters(&self, epoch: Epoch) -> StdResult<Option<ProtocolParameters>> {
@@ -78,6 +82,7 @@ impl ProtocolParametersRetriever for FakeEpochSettingsStorer {
     }
 }
 
+#[cfg(test)]
 #[async_trait]
 impl EpochSettingsStorer for FakeEpochSettingsStorer {
     async fn save_epoch_settings(
@@ -97,6 +102,7 @@ impl EpochSettingsStorer for FakeEpochSettingsStorer {
     }
 }
 
+#[cfg(test)]
 #[async_trait]
 impl EpochPruningTask for FakeEpochSettingsStorer {
     fn pruned_data(&self) -> &'static str {

mithril-aggregator/src/tools/file_archiver/appender.rs

@@ -24,18 +24,19 @@ pub trait TarAppender: Send {
     }
 }
 
+#[cfg(test)]
 pub struct AppenderDirAll {
     target_directory: PathBuf,
 }
-
+#[cfg(test)]
 impl AppenderDirAll {
     // Note: Not used anymore outside of tests but useful tool to keep around if we ever need to archive a directory
-    #[cfg(test)]
     pub fn new(target_directory: PathBuf) -> Self {
         Self { target_directory }
     }
 }
 
+#[cfg(test)]
 impl TarAppender for AppenderDirAll {
     fn append<T: Write>(&self, tar: &mut tar::Builder<T>) -> StdResult<()> {
         tar.append_dir_all(".", &self.target_directory).with_context(|| {