refactor(protocol-config): comments and variable init refactoring

Author: turmelclem

internal/mithril-protocol-config/src/interface.rs

@@ -1,4 +1,4 @@
-//! Interface definition for Mithril Protocol Configuration.
+//! Interface definition for Mithril Protocol Configuration provider.
 
 use async_trait::async_trait;
 use mithril_common::StdResult;

internal/mithril-protocol-config/src/lib.rs

@@ -1,5 +1,5 @@
 #![warn(missing_docs)]
-//! This crate provides functionality for interacting with Mithril Network
+//! This crate provides mechanisms to read and check the configuration parameters of a Mithril network.
 
 mod aggregator_client;
 /// HTTP client Implementation for interacting with Mithril Network.

internal/mithril-protocol-config/src/model.rs

@@ -8,7 +8,7 @@ use mithril_common::entities::{
 
 #[derive(PartialEq, Clone, Debug)]
 
-/// Custom configuration for a signed entity type
+/// Custom configuration for the signed entity types
 pub struct SignedEntityTypeConfiguration {
     /// Cardano Transactions
     pub cardano_transactions: Option<CardanoTransactionsSigningConfig>,

internal/mithril-protocol-config/src/test/double/dummies.rs

@@ -12,9 +12,8 @@ impl Dummy for MithrilNetworkConfiguration {
     fn dummy() -> Self {
         let beacon = fake_data::beacon();
         let signer_registration_protocol_parameters = fake_data::protocol_parameters();
-        let mut available_signed_entity_types = BTreeSet::new();
-
-        available_signed_entity_types.insert(SignedEntityTypeDiscriminants::CardanoTransactions);
+        let available_signed_entity_types =
+            BTreeSet::from([SignedEntityTypeDiscriminants::CardanoTransactions]);
         let signed_entity_types_config = SignedEntityTypeConfiguration {
             cardano_transactions: Some(CardanoTransactionsSigningConfig::dummy()),
         };